From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26579C30653 for ; Thu, 4 Jul 2024 10:32:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ez/HjLuhYleL/QEd52EOK8crO8Jmr05TUrEGvxOv85s=; b=UjBWBAgv6hq+pRSpDyWWnc/rrt pIXq1OvX2s6MCIWdprPGnCFH3MXSMJkr31AUMWFlEY11V98dPlDjom7ajN5VoneDysKoWJs+rw9lQ 7a/Oe5V7SFCLbw62frON6zY+TW0cRqnV3YTEc1XxI4EmDIxN7OL+6xMc0INpoInapi2ibq2IxBG3o SVI1tUKaQSWJHtjOJMtIYdNiNOZRehe2PDpPoXitVkQL2mM+IjadRrsFugCSS3rPvNq7PvQXSJPGC 3bJotLjoxAF5wSIaPNXv+UpeO7VgGZEnB68BaXTyokdHidwncGloNK5JO5Dp2rQfCo+e4T61GKJXr QxAgGaHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPJlj-0000000Csa8-0XjH; Thu, 04 Jul 2024 10:32:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPJlU-0000000CsUk-1iwu for linux-arm-kernel@lists.infradead.org; Thu, 04 Jul 2024 10:32:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4E801367; Thu, 4 Jul 2024 03:33:00 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6A1A53F762; Thu, 4 Jul 2024 03:32:33 -0700 (PDT) Date: Thu, 4 Jul 2024 11:32:30 +0100 From: Sudeep Holla To: Sibi Sankar Cc: , , , , , , , , , Sudeep Holla , Subject: Re: [PATCH] pmdomain: arm: Fix debugfs node creation failure Message-ID: References: <20240703110741.2668800-1-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240703110741.2668800-1-quic_sibis@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_033236_518628_F9D30649 X-CRM114-Status: GOOD ( 11.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 03, 2024 at 04:37:41PM +0530, Sibi Sankar wrote: > The domain attributes returned by the perf protocol can end up > reporting identical names across domains, resulting in debugfs > node creation failure. Fix this duplication by appending the > domain-id to the domain name. > > Logs: > debugfs: Directory 'NCC' with parent 'pm_genpd' already present! > debugfs: Directory 'NCC' with parent 'pm_genpd' already present! > If there are 2 perf domains for a device or group of devices, there must be something unique about each of these domains. Why can't the firmware specify the uniqueness or the difference via the name? The example above seems firmware is being just lazy to update it. Also for the user/developer/debugger, the unique name might be more useful than just this number. So please use the name(we must now have extended name if 16bytes are less) to provide unique names. Please stop working around such silly firmware bugs like this, it just makes using debugfs for anything useful harder. -- Regards, Sudeep