From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35E51C30653 for ; Thu, 4 Jul 2024 10:43:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Mt+wM3Ce8rR2yFCOovHJL/Ie0bcCHj0BJc+Uz3+Nc9Y=; b=AVr7goYukMWKsSiwmNhTzNVQnR r7PlFh7G3juaiuKlUK8IvV0J9DMdwtdQdrPIl5l1yoHpmjRihsUKffk21vYOYRvVIgKMWtM65CKkv cgoAMDxPGtWFaLTozpT6kH/IrRwmu3lrV+aG2EZ1hDP26yJP3qEl/wiJbCzaVJBmo1V1l2coalgSL jXDgFcnuXW7ure9M0dT+/mZeRdu5iU+nRqZjCq7+3c0dvDnkwghe4qCs5EZEzpGPZNr0r6BxQ0bGd eqpwP8AKvKsDiH0a4GEb7PvtgoeAg6BAsE1Dm3QSE7SkE8F0FB4OLRPGwTz0iJMu2VijgfIfijKmK renZPaPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPJva-0000000CuBk-44Rx; Thu, 04 Jul 2024 10:43:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPJvO-0000000CuAB-0nY5 for linux-arm-kernel@lists.infradead.org; Thu, 04 Jul 2024 10:42:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A66FA367; Thu, 4 Jul 2024 03:43:14 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E1FE43F762; Thu, 4 Jul 2024 03:42:47 -0700 (PDT) Date: Thu, 4 Jul 2024 11:42:45 +0100 From: Sudeep Holla To: Peng Fan Cc: "Peng Fan (OSS)" , "cristian.marussi@arm.com" , Sudeep Holla , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm-scmi@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH V2 1/2] dt-bindings: firmware: arm,scmi: introduce property mbox-rx-timeout-ms Message-ID: References: <20240703031715.379815-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_034250_374980_211DAED3 X-CRM114-Status: GOOD ( 26.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 04, 2024 at 10:39:53AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH V2 1/2] dt-bindings: firmware: arm,scmi: introduce > > property mbox-rx-timeout-ms > > > > On Wed, Jul 03, 2024 at 11:17:14AM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > > > System Controller Management Interface(SCMI) firmwares might > > have > > > different designs by SCMI firmware developers. So the maximum > > receive > > > channel timeout value might also varies in the various designs. > > > > > > So introduce property mbox-rx-timeout-ms to let each platform could > > > set its own timeout value in device tree. > > > > > > Signed-off-by: Peng Fan > > > --- > > > > > > V2: > > > Drop defaults, update description. > > > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 6 > > ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git > > a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > index ebf384e76df1..dcac0b36c76f 100644 > > > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > @@ -121,6 +121,12 @@ properties: > > > atomic mode of operation, even if requested. > > > default: 0 > > > > > > + max-rx-timeout-ms: > > > + description: > > > + An optional time value, expressed in milliseconds, representing > > the > > > + mailbox maximum timeout value for receive channel. The value > > should > > > + be a non-zero value if set. > > > + > > > > IIRC, you had the min and max constraint in the earlier response. You > > need to have rushed and posted another version before I could respond > > with my preference. > > > > So there is no rush, these are v6.12 material. Take time for respining > > and give some time for the review. > > Sure. I just not sure what the maximum should be set, so I drop > the minimum and maximum from my previous email. > Worst case we can just have min constraint to indicate it must be non-zero value as you have mentioned above and drop that statement as it becomes explicit with the constraint. -- Regards, Sudeep