From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FFD7C3DA41 for ; Thu, 11 Jul 2024 13:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B3nue/3ptpdQ56WdMat9sQ/mDmVmDrkokleqwT9Rx6s=; b=NBB1zJbyH3VpZhIs48BjKCe7us Kys/bM5QTnfI/cLsW5pXwTduNqRAq45MzMh861GtorhydARWL1MvfTnb6PMLWbIjIIBawrXyh03iU khbuOBuqPZAmzkeoFILb98p2fJizjApsYkW+Nerws+OGGnHgUhc+MN5fTUDQdsXxczEOjNubUI03b pXGmNTCduSRYbEDpEKnNwrTWlUbdMPrhbc2+aCAflQYX/geWgvNOhSqDkmkW/fEnOp8mmK1infq33 E0/QILoQ6HnA25hX7AENHQEnuXxDG/wAMm1XSjSvwOL6ieP3LHwSmEb9QN0ZUT8+t8GGwNJHXGmtu Y1bCk9qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRtVV-0000000E5Fj-04j1; Thu, 11 Jul 2024 13:06:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRtU0-0000000E4Oh-3a5y for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2024 13:05:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A97C1007; Thu, 11 Jul 2024 06:05:35 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0D3C33F766; Thu, 11 Jul 2024 06:05:06 -0700 (PDT) Date: Thu, 11 Jul 2024 14:04:58 +0100 From: Cristian Marussi To: "Peng Fan (OSS)" Cc: Jonathan Corbet , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peng Fan , Alexandre Belloni , Dmitry Torokhov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, arm-scmi@vger.kernel.org, linux-rtc@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v5 2/7] dt-bindings: firmware: add i.MX95 SCMI Extension protocol Message-ID: References: <20240621-imx95-bbm-misc-v2-v5-0-b85a6bf778cb@nxp.com> <20240621-imx95-bbm-misc-v2-v5-2-b85a6bf778cb@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621-imx95-bbm-misc-v2-v5-2-b85a6bf778cb@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_060513_123762_A235C3E6 X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 21, 2024 at 03:04:37PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > LGTM. Reviewed-by: Cristian Marussi Thanks, Cristian > Add i.MX SCMI Extension protocols bindings for: > - Battery Backed Module(BBM) Protocol > This contains persistent storage (GPR), an RTC, and the ON/OFF button. > The protocol can also provide access to similar functions implemented via > external board components. > - MISC Protocol. > This includes controls that are misc settings/actions that must be exposed > from the SM to agents. They are device specific and are usually define to > access bit fields in various mix block control modules, IOMUX_GPR, and > other GPR/CSR owned by the SM. > > Reviewed-by: "Rob Herring (Arm)" > Signed-off-by: Peng Fan > --- > .../devicetree/bindings/firmware/arm,scmi.yaml | 5 ++- > .../bindings/firmware/nxp,imx95-scmi.yaml | 43 ++++++++++++++++++++++ > 2 files changed, 47 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 4d823f3b1f0e..47f0487e35de 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -22,6 +22,9 @@ description: | > > [0] https://developer.arm.com/documentation/den0056/latest > > +anyOf: > + - $ref: /schemas/firmware/nxp,imx95-scmi.yaml > + > properties: > $nodename: > const: scmi > @@ -284,7 +287,7 @@ properties: > required: > - reg > > -additionalProperties: false > +unevaluatedProperties: false > > $defs: > protocol-node: > diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml > new file mode 100644 > index 000000000000..1a95010a546b > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2024 NXP > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/nxp,imx95-scmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX95 System Control and Management Interface(SCMI) Vendor Protocols Extension > + > +maintainers: > + - Peng Fan > + > +properties: > + protocol@81: > + $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node' > + unevaluatedProperties: false > + > + properties: > + reg: > + const: 0x81 > + > + protocol@84: > + $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node' > + unevaluatedProperties: false > + > + properties: > + reg: > + const: 0x84 > + > + nxp,ctrl-ids: > + description: > + Each entry consists of 2 integers, represents the ctrl id and the value > + items: > + items: > + - description: the ctrl id index > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 0x8000, 0x8001, 0x8002, 0x8003, > + 0x8004, 0x8005, 0x8006, 0x8007] > + - description: the value assigned to the ctrl id > + minItems: 1 > + maxItems: 16 > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + > +additionalProperties: true > > -- > 2.37.1 >