From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BFBEC3DA45 for ; Thu, 11 Jul 2024 14:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OHGDiATR+gJ3Cqj0KSepTs01rdvjzS0Fk70dcfTsApc=; b=PUo/NdKVNs4851RVbJeksm3Vbo rmMe/wLR0nhmIs9Jx/EMyJ86CWzAbfRiJ5cqUAOaSfZ/1V4MLLhRKESmaWDxH4BwzYz9GmnJCW+Fy VDIwteNLGg9xsKNvQPw5aXLjPCCC/wQDas8rmWv595GyFDdOZAUHBrVODw0nAdsT5gpHqeTnX6h+3 Q6O6xiYSjrloBnFwpwuMfbmX/uEPJ9qLVJH7TM5z+AHA5oAUWDMiMWAMdtQHVijPW3qGWGYA8qSLi V9ANOxW9bSohCt3fovgbUizTEUx0+54du0K+Wac/lqpnwfNfHKJbSqmE+Ctj8w+5j5TmvskRfQ0km qZb5j8OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRuQy-0000000EGso-0gaX; Thu, 11 Jul 2024 14:06:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRuQf-0000000EGn9-2jrX for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2024 14:05:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F328FEC; Thu, 11 Jul 2024 07:06:13 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5EEFC3F766; Thu, 11 Jul 2024 07:05:45 -0700 (PDT) Date: Thu, 11 Jul 2024 15:05:42 +0100 From: Cristian Marussi To: "Peng Fan (OSS)" Cc: Jonathan Corbet , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peng Fan , Alexandre Belloni , Dmitry Torokhov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, arm-scmi@vger.kernel.org, linux-rtc@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v5 0/7] firmware: support i.MX95 SCMI BBM/MISC Extenstion Message-ID: References: <20240621-imx95-bbm-misc-v2-v5-0-b85a6bf778cb@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621-imx95-bbm-misc-v2-v5-0-b85a6bf778cb@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_070549_761700_EECD393F X-CRM114-Status: UNSURE ( 7.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 21, 2024 at 03:04:35PM +0800, Peng Fan (OSS) wrote: > i.MX95 System Manager Firmware source: https://github.com/nxp-imx/imx-sm > To generate html from the repo: make html > Hi Peng, thanks for upstreaming this Vendor protocol. LGTM, beside minor nitpicks I mentioned. Please run checkpatch.pl --strict on series before next rebase, though, that I spotted a few minor not-so-stylish things :D Thanks, Cristian