Re: [PATCH v2 2/8] firmware: arm_scmi: Introduce packet handling helpers

[Cristian Marussi <cristian.marussi@arm.com>]

On Thu, Jul 11, 2024 at 10:43:23AM +0000, Peng Fan wrote:
> > Subject: [PATCH v2 2/8] firmware: arm_scmi: Introduce packet
> > handling helpers
> > 

Hi Peng,

thanks for having a look.

> > Introduce a pair of structures initialized to contain all the existing
> > packet handling helpers, both for transports based on shared memory
> > and messages.
> > 
> > No functional change.
> > 
> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> > ---
> > v1 --> v2
> > - fixed commit message
> > ---
> ......
> 
> > d33a704e5814..f4ba38afe0bb 100644
> > --- a/drivers/firmware/arm_scmi/msg.c
> > +++ b/drivers/firmware/arm_scmi/msg.c
> > @@ -4,8 +4,8 @@
> >   *
> >   * Derived from shm.c.
> >   *
> > - * Copyright (C) 2019-2021 ARM Ltd.
> > - * Copyright (C) 2020-2021 OpenSynergy GmbH
> > + * Copyright (C) 2019-2024 ARM Ltd.
> > + * Copyright (C) 2020-2024 OpenSynergy GmbH
> 
> Nitpick: OpenSynergy year should be kept unchanged?
> 
> Otherwise looks good:
> Reviewed-by: Peng Fan <peng.fan@nxp.com>

Yeah, I am not sure how to go around years of Copyrights...moreover I
received some auto-responder email from OpenSynergy saying thay have
been acquired by Qualcomm....I suppose I have to stick anyway with the
original autorship/copyright.

Thanks,
Cristian