From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DDD2C3DA45 for ; Thu, 11 Jul 2024 14:08:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8xxY1U3KW3CRstihDR5EK9w11TDkQD1kGdKHK+DUwb4=; b=mswt5tz9j7KLPA0TUA0jFzBv8l 6+Ov9ioSwrXE/8z+SlDNgiWxBeKE4+o5d4R+I4QuB629TJmc9XT8R1NiEPJpwSVnjR3Z28phQ0uPA g8Pe2jvlSDb8I/dy+NfNiI7Y5wO4xqWvKpF/soH9mE/Ii6uOpu5V9sfbRkHjrQTG6sOpRgZnXNgl8 OMEdkMXp7rp6JckH4pwYhvcK5kdTjodD/C7UYCpiWiiRnqMdTq5WFNNgtL1ejHF43ATUtVKkHGCYL 9nU7VFTzJwANC03m7yUrKkxGjwOTpMLFqUjJrnFjTX5yrtphgtTZPS+8cb4fKmYV2OqXrvwNBKsUt ipmaUenA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRuTL-0000000EHUu-0vlL; Thu, 11 Jul 2024 14:08:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRuT3-0000000EHOF-2UCS for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2024 14:08:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B79D8FEC; Thu, 11 Jul 2024 07:08:40 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 429C13F766; Thu, 11 Jul 2024 07:08:13 -0700 (PDT) Date: Thu, 11 Jul 2024 15:08:10 +0100 From: Cristian Marussi To: Peng Fan Cc: Cristian Marussi , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "arm-scmi@vger.kernel.org" , "sudeep.holla@arm.com" , "james.quinlan@broadcom.com" , "f.fainelli@gmail.com" , "vincent.guittot@linaro.org" , "etienne.carriere@st.com" , "Peng Fan (OSS)" , "michal.simek@amd.com" , "quic_sibis@quicinc.com" , "quic_nkela@quicinc.com" , "ptosi@google.com" , "dan.carpenter@linaro.org" , "souvik.chakravarty@arm.com" Subject: Re: [PATCH v2 2/8] firmware: arm_scmi: Introduce packet handling helpers Message-ID: References: <20240710173153.4060457-1-cristian.marussi@arm.com> <20240710173153.4060457-3-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_070817_710590_0D9A7124 X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 11, 2024 at 10:43:23AM +0000, Peng Fan wrote: > > Subject: [PATCH v2 2/8] firmware: arm_scmi: Introduce packet > > handling helpers > > Hi Peng, thanks for having a look. > > Introduce a pair of structures initialized to contain all the existing > > packet handling helpers, both for transports based on shared memory > > and messages. > > > > No functional change. > > > > Signed-off-by: Cristian Marussi > > --- > > v1 --> v2 > > - fixed commit message > > --- > ...... > > > d33a704e5814..f4ba38afe0bb 100644 > > --- a/drivers/firmware/arm_scmi/msg.c > > +++ b/drivers/firmware/arm_scmi/msg.c > > @@ -4,8 +4,8 @@ > > * > > * Derived from shm.c. > > * > > - * Copyright (C) 2019-2021 ARM Ltd. > > - * Copyright (C) 2020-2021 OpenSynergy GmbH > > + * Copyright (C) 2019-2024 ARM Ltd. > > + * Copyright (C) 2020-2024 OpenSynergy GmbH > > Nitpick: OpenSynergy year should be kept unchanged? > > Otherwise looks good: > Reviewed-by: Peng Fan Yeah, I am not sure how to go around years of Copyrights...moreover I received some auto-responder email from OpenSynergy saying thay have been acquired by Qualcomm....I suppose I have to stick anyway with the original autorship/copyright. Thanks, Cristian