From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4B30C3DA41 for ; Thu, 11 Jul 2024 14:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FyBiUbSI+aZl9Kj97BzzjrD5r04DQqr5s5WFP2Jm1tw=; b=pV+sLvNt/ceqk044pvBIZYriNP tK1t0QBY367LWMe8mX7PG9b1YSxJ84zqHKpx7+TOfuZdD9gfyggsY7CDZW4LCL3+e+HrLI+bNn6Qr L36M6iZIg6+es5rg8rwavwYsdAKeW9doFfX/8iy3kf+qWdH1mgqmrI67qSS4DCAVD/Bx75ucsw3Rx /Hey0r36noPUnY7ioykFF46Zw2ziPZb+GFHoRCRFrGNeD/3g3J2o+rfXf36/2SpBa55uOY6a9SriO HvX1qkZTPc3jNZGMwkiKKtckn0m1Tf2bJhImcIsOi7KkO9knDCdx40IEhTYVG3tipP6Zp8bSA/yOX Hfo+mFiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRugw-0000000EKhh-3z12; Thu, 11 Jul 2024 14:22:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRuge-0000000EKav-3o8n for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2024 14:22:22 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 65FA6FEC; Thu, 11 Jul 2024 07:22:45 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EBD783F766; Thu, 11 Jul 2024 07:22:17 -0700 (PDT) Date: Thu, 11 Jul 2024 15:22:15 +0100 From: Cristian Marussi To: Peng Fan Cc: Cristian Marussi , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "arm-scmi@vger.kernel.org" , "sudeep.holla@arm.com" , "james.quinlan@broadcom.com" , "f.fainelli@gmail.com" , "vincent.guittot@linaro.org" , "etienne.carriere@st.com" , "Peng Fan (OSS)" , "michal.simek@amd.com" , "quic_sibis@quicinc.com" , "quic_nkela@quicinc.com" , "ptosi@google.com" , "dan.carpenter@linaro.org" , "souvik.chakravarty@arm.com" Subject: Re: [PATCH 0/8] Make SCMI transport as standalone drivers Message-ID: References: <20240710173153.4060457-1-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_072221_073798_814430B9 X-CRM114-Status: GOOD ( 36.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 11, 2024 at 01:26:16PM +0000, Peng Fan wrote: > > Subject: [PATCH 0/8] Make SCMI transport as standalone drivers > > You may need use V2 here :) ...oh damn :P > > > > Hi all, > > > > Till now the SCMI transport layer was being built embedded into in the > > core SCMI stack. > > > > Some of these transports, despite being currently part of the main > > SCMI module, are indeed also registered with different subsystems like > > optee or virtio, and actively probed also by those: this led to a few > > awkward and convoluted tricks to properly handle such interactions at > > boot time in the SCMI stack. > > > > Moreover some partner expressed the desire to be able to fully > > modularize the transports components. > > > > This series aim to make all such transports as standalone drivers that > > can be optionally loaded as modules. > > > > In order to do this, at first some new mechanism is introduced to > > support this new capability while maintaining, in parallel, the old > > legacy embedded transports; then each transport, one by one, is > > transitioned to be a standalone driver and finally the old legacy > > support for embedded transport is removed. > > > > Patch [1/8] is a mostly unrelated (but much needed) clean-up from > > Peng, which I included in this series to avoid conflicts at merge. > > > > Patch [2/8] simply collects the existing datagram manipulation helpers > > in a pair of function pointers structures, in preparation for later reworks. > > > > Patch [3/8] adds the bulk of the new logic to the core SCMI stack and > > then each existing transport is transitioned to be a standalone driver in > > patches 4,5,6,7 while shuffling around the compatibles. (no DT change > > is needed of curse for backward compatibility) While doing this I kept > > the module authorship in line with the main > > author(S) as spitted out by git-blame. > > > > Finally patch [8/8] removes all the legacy dead code from the core > > SCMI stack. > > > > No new symbol EXPORT has been added. > > > > The new transport drivers have been tested, as built-in and LKM, as > > follows: > > > > - mailbox on JUNO > > - virtio on emulation > > - optee on QEMU/optee using Linaro setup > > > > Exercised using the regular SCMI drivers stack and the SCMI ACS suite, > > testing commands, replies, delayed responses and notification. > > > > Multiple virtual SCMI instances support has been tested too. > > > > SMC has NOT been tested/exercised at run-time, only compile-tested. > > (due to lack of hardware) > > > > Note that in this new setup, all the probe deferral and retries between > > the SCMI core stack and the transports has been removed, since no > > more needed. > > > > Moreover the new drivers have been tested also with a fully > > modularized SCMI stack, i.e.: > > > > scmi-core.ko + scmi-module.ko + scmi_transport_*.ko [ + vendor > > modules ] > > > > ToBeDone: > > - completely remove any dependency at build time at the Kconfig level > > between > > the SCMI core and the transport drivers: so that the transports will be > > dependent only on the related subsystems (optee/virtio/mailbox/smc) > > (easy to be done but maybe it is not worth...) > > - integrate per-platform transport configuration capabilities > > (max_rx_timeout_ms & friends..) > > > > Based on sudeep/for-next/scmi/updates. > > > > Any feedback, and especially testing (:D) is welcome. > > > > For the v2 patchset: > Tested-by: Peng Fan #i.MX95-19x19-EVK > Thanks a lot for the review and testing, Cristian