Re: [PATCH net v3] net: dsa: mt7530: fix impossible MDIO address and issue warning

[Daniel Golle <daniel@makrotopia.org>]

On Thu, Jul 04, 2024 at 04:46:29PM +0200, Florian Fainelli wrote:
> On 7/3/2024 12:44 AM, Daniel Golle wrote:
> > [...]
> > This is imporant also to not break compatibility with older Device Trees
> > as with commit 868ff5f4944a ("net: dsa: mt7530-mdio: read PHY address of
> > switch from device tree") the address in device tree will be taken into
> > account, while before it was hard-coded to 0x1f.
> > 
> > Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch")
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> > Only tested on BPi-R3 (with various deliberately broken DT) for now!
> 
> This seems like a whole lot of code just to auto-magically fix an issue that
> could be caught with a warning. I appreciate that most of these devices
> might be headless, and therefore having some attempt at getting functional
> networking goes a long way into allowing users to correct their mistakes.

My initial motivation was to preserve compatibility with existing broken
device trees.

I then had given up on it because nobody seemed to care, but have
resumed and completed the patch now that reverting the change taking the
address in DT into account became the only alternative.

In OpenWrt all device trees with broken switch MDIO address have been
fixed long ago... (and we always ship the DT along with the kernel, so
DT backward-compatibility doesn't play a role there)