From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABF0BC30653 for ; Thu, 4 Jul 2024 11:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kvRShMxu8ENYQKvuGD1ARbRIh16vBuw9N7RnsKu6f9o=; b=sKGjvQ1pS5lrjw1Dn5/eR53RvO w2KuRm5VElfj8p8QRhFRm/Jt0uhItJRIe+hoLAiZwXgECFslTZyNtLDt9IIcFZaHpztvJ9BjCszam 3JJRpWnE0WTb1OqW2LsnFwfD1eeFVN5oP747tf1q0YqyQ6cl5Sr1APjJYST3tnP5Ew+TTjoxYf/+A cGb+5NM6oiPQH1SU1HYHjaEMPpcwP+bLXG2qNsBrk+evK4KgedljpaArK6AqN6egc7i5hCpdVlBVP 9iH2RH/xTzQF1u+hAL3rshdEccHAA0yjN7vheSOXUeb2qVP5sFVtoWeY7gh8G5hfBOMVkmjb8tgMI ULKZP9Wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPKLT-0000000Cxt0-2Uy9; Thu, 04 Jul 2024 11:09:47 +0000 Received: from mgamail.intel.com ([192.198.163.8]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPKLF-0000000Cxpa-3ScB; Thu, 04 Jul 2024 11:09:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720091374; x=1751627374; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=xFlcXSQRLzYQueQGzIC4URJ+mHKe7b+sLTbVHlvLibI=; b=KlyZuSPI8oDLb35Ygmwl8JEFadlPojC1cgCTOOJ5pAK8uk4LKh5ym6Wf ytiMlN7iPj063SoreOh6G2OmLGV1KQ21/gUhgq3MVFCtrVZVYWYvJfZ4S f+QF16qZAZAGUsPas7hh43O0txGElbeiqEGhjJ0RM3llNVWTGv/SI9aEE yaeFB2OWSmlcNdy2d+lS/Pf+IzQBSjxdBkBDD10R9/aPPX5qo9xupiGJv TZmLDgSUbMXXC0xY/Raa34yK6efUh1+rrWB/HgVWfbZQ30r7oszfFDNlt XTDfOst5b0tZy/4XlR0H5P4FW6RTDhYXq5yMTze5aJsvhu/mZGmD1OnZa Q==; X-CSE-ConnectionGUID: cnD+HlsRSruvf6XltL3LHA== X-CSE-MsgGUID: Rg9rG35cR0mm2CJVhNZazg== X-IronPort-AV: E=McAfee;i="6700,10204,11122"; a="34906643" X-IronPort-AV: E=Sophos;i="6.09,183,1716274800"; d="scan'208";a="34906643" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2024 04:09:28 -0700 X-CSE-ConnectionGUID: qHhFrFs4QQ2apFjubh2zGw== X-CSE-MsgGUID: jE78b+seTrKAq59JkDqBvQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,183,1716274800"; d="scan'208";a="51153662" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Jul 2024 04:09:28 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 4 Jul 2024 04:09:27 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 4 Jul 2024 04:09:26 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 4 Jul 2024 04:09:26 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 4 Jul 2024 04:09:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V5y6sivjLTeJM0TsZsFZ6eFNVdX9X9vAqfkZxxEJSdxUDC5V8gJogjJT+sc+GLjaGlewEfWni8fcyPp+muJFL0/x1vwbeS/N9vwTrDXUroRPTXEUV4ky/vuYL6bgJLEyxg+EUk8RYHvnDUX/rlw9L7r8wFjN2ipKR5TBr0NeS3OqNalnYlX2bhrifhLp1TTnHh9qC6kTc7STEet4WBIpvD15Vzzxet7derYsrHr0SL2lPeoCuDH0t/9jFcbcJxLqpqP9Q7r9NqksPSC8wp4pLoelbEnkP6wBryAEz1Ap3ezktAV01ivpavpC1QkBDpMKnTZgVDg1yl9m23jWkJxr5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kvRShMxu8ENYQKvuGD1ARbRIh16vBuw9N7RnsKu6f9o=; b=R+DRE21ctRkXYQob2kQDrsM9PkU6IrYWCVjJvzcCrfmr6UtxuzA65ZyyuRJ+VNWVzvFw6RGbKdQaZnqLJpGPZexUigUDibU0SDzZG3gsZy3ZuqRGaZTZc81TceO4NPIsEoCbv6OUWM6YZ89V/Q/RHwuwlbFF54r9xyvU8s+kVjgrti2q+rVo41D/VFwmxu39d49icGrkVvoHvywYipwse1T00LZTwCngXq5oidbjIHW6MT0Nik3wS6mRMh3SI1M5LAR62df3sbIURc6VLlAkvsLAAGhxvJ7b8JDryZ82XcMTSVGPdPgvF4Y2hj6xiV+QN5URF/TuZE4IkBpY4YDV1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5782.namprd11.prod.outlook.com (2603:10b6:510:147::11) by MW3PR11MB4522.namprd11.prod.outlook.com (2603:10b6:303:2d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.32; Thu, 4 Jul 2024 11:09:19 +0000 Received: from PH0PR11MB5782.namprd11.prod.outlook.com ([fe80::9696:a886:f70a:4e01]) by PH0PR11MB5782.namprd11.prod.outlook.com ([fe80::9696:a886:f70a:4e01%7]) with mapi id 15.20.7741.027; Thu, 4 Jul 2024 11:09:19 +0000 Date: Thu, 4 Jul 2024 13:09:04 +0200 From: Michal Kubiak To: Daniel Golle CC: John Crispin , Felix Fietkau , Sean Wang , Mark Lee , "Lorenzo Bianconi" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Paolo Abeni" , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , , , , Subject: Re: [PATCH net-next] net: ethernet: mtk_eth_soc: implement .{get,set}_pauseparam ethtool ops Message-ID: References: Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MI1P293CA0003.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:2::19) To PH0PR11MB5782.namprd11.prod.outlook.com (2603:10b6:510:147::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR11MB5782:EE_|MW3PR11MB4522:EE_ X-MS-Office365-Filtering-Correlation-Id: e8747339-3142-4969-87fa-08dc9c19c044 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LrG4HK/7bQqQir4aJbxATSLBCTkx6Tm8AGHVaB4LHvGBayZAqXbxlqxlsRbU?= =?us-ascii?Q?T1uZ9dpru9bnhIYH5UAuSyE+vOI9q6yyL9ml6Nwn/pxsScaY6y29UE+FNCS3?= =?us-ascii?Q?MdTCzuzBVnbXMpKKxRf+LdSkm6FWiLumLuisIcLVlG471qCQhF4/atqrKlTT?= =?us-ascii?Q?8tJ8RHH0nvbLvNktLmW0UoEqs0nKaS063iE+nmcU3IBed+SlI71Rom5IhrlF?= =?us-ascii?Q?ZXNU94Lq5tQGyr32y8cZ8BPIc+YDwBVP1s953yXRM6ovPEy2x+XAaCLRgvio?= =?us-ascii?Q?NvRSBuXkMBsVo74JZ7G4tGMs/4RCEHx9aQvOoB7FthjCwc7wU7/5E5/c1RPv?= =?us-ascii?Q?ydvph6GvE2VwWAtdewTWRH3emBUXiKho0MviUbhIpEw1CWbn4MKkY+3d0yre?= =?us-ascii?Q?e12UJ6LRcOp5jirtoUf+mS/S1mCvtESrcu5CiTI/SXBeksmcmWEbni1JV8Vz?= =?us-ascii?Q?kZW4Vx92xKNPZub5hRJaGsGOnZLFMLX1CGWnq4euibLt9QSHj/uBaDKHNeNt?= =?us-ascii?Q?uab7EqXnI9Z/cPOd/StJC6wNczw8hO8Bj4poIw0w4Y+hZDEv72TOJhjA5QeY?= =?us-ascii?Q?++QZocMOnMx1ymoDC64k0lCl0K5L+r2UlBacfpvhD3EQngrjKf2lVJSYy+z7?= =?us-ascii?Q?8ixt/+eniFQGjWNw7XtNThwJBLjf3lUyo8mwdEvcBd5ScJY2NG7scddoDJlG?= =?us-ascii?Q?AXmv6PCn+lfzk82nsrQU1rNorRu5h0HBGx7/K+4SRdjO0zrnQOhZKeN4Wqpa?= =?us-ascii?Q?fHACtco/+jON2Uah2C2nF2X4qQzkjoBZd5mQTBTtvrP/L3skCG0SBjBCRggY?= =?us-ascii?Q?ozud9DM2D0FE/UtuYiLYR8UWPp4j2QEmhMljYpF5jPg0hFhhyyKF3gnR3X/l?= =?us-ascii?Q?e/hFckAPliL08TouwpRcoyzlOOM+VLY7F5+ysQoH3jB6iQaxFIJAmbI1c6ex?= =?us-ascii?Q?zSxRtKwAWK0ieg3Za01zQHM/d4LkWQ3ZDSeBzVZZYKvov8mgIkfAtEb4RcZE?= =?us-ascii?Q?VZt1fQgTrp64QU5SGPkXQ/GGwmChsIvNfM9c2/0f33Te6EyQFUF5GzN5pe/D?= =?us-ascii?Q?cYPmL86I/365QHCubylr822YyVNRUpKMjB1CUCFoxQbTSo6vkVu28TZDlNyc?= =?us-ascii?Q?W8TsqEKgGpXUR3fTzc9gU83sbbRKZta1jOuiCjLLwpaf4bEFGlOOLI6NGhgO?= =?us-ascii?Q?47+XNzyx2LnlsREffKkPqXYlwQGybf10Ix7VupT30STf2nhBnV2qe0vxPBHs?= =?us-ascii?Q?RRAJ7eMRg/u/TDB4SYLqJImKps3U3jQJk9hoNpJn7/XIx43BTlCbeiI15pnC?= =?us-ascii?Q?c7eN1JYMuuSFs/VEQuvgMWy9grSb3KSCtq0sNmAj33hmjg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5782.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ozV7ZBjA1XnPY6BgZmWrwhqfISVLR83HmlFDkX2806iOlyuy8Q0WrPv/VDSU?= =?us-ascii?Q?8uJT6URzVo/QsKm+gzKZ4dFkSzheM5jDPtgEWzWBzOj7ZqqNz+Pl4ULydzpx?= =?us-ascii?Q?+ZpdGUEwieqeXSPCmF9w1LJhg7JdxZo2Fv+MyKFWdoPB4agz1cFfs2b17tec?= =?us-ascii?Q?3kENs+GMyb5JgIG7ofkvTRwrLQCO6Sv0ctOt8XN32A3l/KZVl83mG2wPXlkP?= =?us-ascii?Q?b9hwyVVt38CZ2kArUWVSH95hb/Sa+mKDfNyMipDd7lawulnSJT1bmg0NyVSC?= =?us-ascii?Q?Sriy/xRm/G6vZJtu69z77njQCztqRpgix9Dmo4AnwQglcYeVfD3RWAR1JPrN?= =?us-ascii?Q?umXzo/+iQVtY7wWPfGV4Vk9MTIE8YF4zLdz0pRi6kYnrIL2yZpbkAxu9uAm4?= =?us-ascii?Q?tPPoPx7YC+j7TCCyeNzdXftsA2NtzMiDOkW2TSiE015pxFTgBttZz8ZsrR1w?= =?us-ascii?Q?R64VXU+mgdaNJA1iUKsudMz6mXt/AW6Xx4V8UPDEo77v5vujkvvxRNLywsYm?= =?us-ascii?Q?bRAhhhvRx+l80PGPVgzsPiPbINVkHJLjQuBIEbLnYYYQOLYSwmzTiM2kLJxK?= =?us-ascii?Q?Twc4HYXN8VL7vLqZjy7L4Swn79KVbf6wQKNNLeN4uZzC1tG0ribz5/VbeTgv?= =?us-ascii?Q?6Jx/7bvTv5gUY9nw7ObOBmlGlWHG5a6BKYisFwlX17KibglU7fg8iCuHLYA5?= =?us-ascii?Q?pGODX2Kv1PZazyL2Fm8eFOhGLHXQ0HcK0NCsIRHULjT4la4Bzr9xsww6CGVh?= =?us-ascii?Q?dpEsOa4YhWcEFE1fyUX0aR05ahUWn0SUd2KNLFCr0En+pEYTckUHXlTFpJSu?= =?us-ascii?Q?1tI49u9/6HjwfIt8PUC9qMDU61dCRcKGxz1AFgah5pCa8cuIMS6fAM//nhMm?= =?us-ascii?Q?/+mc7AU2uVfz72sbdoZeQJWdj1m47nfOYq+WLyIwGc7/2wEQcQP4uRRA7w0w?= =?us-ascii?Q?kWmbuBr6HuOqJjOBDrbUk057D0UPCHleUfxZTYFm9sY/LooIK9ddbrlkjQvu?= =?us-ascii?Q?VA+B3PIEjUkxW027MOjNaqTOzXHQBuaEgwky5iJLtV6pwz/QNXS3+M5KwoEf?= =?us-ascii?Q?mtMqDGGIQzXyH9k7tuyLNf16g1DhLTbjcuXra4UNvFeRf27/s84hHrQ09Rmh?= =?us-ascii?Q?/bTkRszgUsQ9dLypYYkTSyYBVCz86HpGwxQBgD+4PRKE4dUf61ufrJz+vpcv?= =?us-ascii?Q?1tQaRanOeDSpRZImVv88v/rs+hUqJxBL7qMTvM/AW0U32yqn0Z11stshO4LN?= =?us-ascii?Q?YVgiQT50hNRmrBTs/F7M51PRQIMkfcWW5EQoGH/hh2mK9JgOG85Dsp74/F/D?= =?us-ascii?Q?ZH53p2gP5xpw981uVL8tt8rh0qP7QnI9RIz/1X541Lf6+kLSHlnvixbTTCO6?= =?us-ascii?Q?mGApg9xoSqqXylxkzYAojNaVbB9CxCauOQQloWMBIDlKapUfGV8YrCEK/j9P?= =?us-ascii?Q?GfyCo6ImtwjAUqHZ24/wGObja3PSDfUVU4vL42AblEz16wkLgB1x0jvqigdi?= =?us-ascii?Q?AKZQv3GAU5p425dzWXxtf+GrwXD5Aeeikdusl9QGwZGJwhnlHh/NkBSpECtv?= =?us-ascii?Q?egIMf8nvKemhoXy+KFRqA+eqF9tj0AbNrPeI0G4iFqT9af2SJ38aW0C7ps/v?= =?us-ascii?Q?1w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e8747339-3142-4969-87fa-08dc9c19c044 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5782.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2024 11:09:19.4504 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MffnwU6iYwkfhwEHJI5V+5UybW4qT/USWEG3a61PJr/4exWC2xnD8NwLlC1PFp9z9VlchaLfho13fUENW6ACgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4522 X-OriginatorOrg: intel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_040933_905642_F8D0DCFE X-CRM114-Status: GOOD ( 21.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 04, 2024 at 11:14:55AM +0100, Daniel Golle wrote: > Implement operations to get and set flow-control link parameters. > Both is done by simply calling phylink_ethtool_{get,set}_pauseparam(). > Fix whitespace in mtk_ethtool_ops while at it. > > Signed-off-by: Daniel Golle > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index 13d78d9b3197..fbf5f566fdc5 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -4464,6 +4464,20 @@ static int mtk_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd) > return ret; > } > > +static void mtk_get_pauseparam(struct net_device *dev, struct ethtool_pauseparam *pause) > +{ > + struct mtk_mac *mac = netdev_priv(dev); > + > + phylink_ethtool_get_pauseparam(mac->phylink, pause); > +} > + > +static int mtk_set_pauseparam(struct net_device *dev, struct ethtool_pauseparam *pause) > +{ > + struct mtk_mac *mac = netdev_priv(dev); > + > + return phylink_ethtool_set_pauseparam(mac->phylink, pause); > +} > + > static u16 mtk_select_queue(struct net_device *dev, struct sk_buff *skb, > struct net_device *sb_dev) > { > @@ -4492,8 +4506,10 @@ static const struct ethtool_ops mtk_ethtool_ops = { > .get_strings = mtk_get_strings, > .get_sset_count = mtk_get_sset_count, > .get_ethtool_stats = mtk_get_ethtool_stats, > + .get_pauseparam = mtk_get_pauseparam, > + .set_pauseparam = mtk_set_pauseparam, > .get_rxnfc = mtk_get_rxnfc, > - .set_rxnfc = mtk_set_rxnfc, > + .set_rxnfc = mtk_set_rxnfc, > }; > > static const struct net_device_ops mtk_netdev_ops = { > -- > 2.45.2 > The patch looks correct. Thanks, Reviewed-by: Michal Kubiak