From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6EFBC30653 for ; Thu, 4 Jul 2024 14:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8BvmNktHHHNKPOgXOL98EubN28/wzc27+oGWQqt2WoI=; b=GKqFB7N2/IIU73tQ5v9xPLkTrJ rgsNSvx/ZA50ehx3ecfRafuSsiLBlIjVB68jAnfA/uXdme3H2SS2OF7IcAslInHXVWRGRLxDFjUmn v874BAwc0LeAyYz7up2pPxRcTdt/XgDiAZ+edcsOVtMqtgbhXaqk4gh7VXcoyaTg9XR9qdDVykBXM +J83S+kRdgERjrm1tqBb8uCVzniHnm7QIc/f3Bq1bSEn9d4gsKQllwbrRLxGQNJ2B9nlhwmCw46Xr v0q/sbDanlK+bicAZrkosyR3egFdr9TcdmpEwXEwD9vbqKwtpwsu2wWGhN824Qy1+EAGTFFPXFny2 IKm0TlPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPN9J-0000000DOOq-2wSA; Thu, 04 Jul 2024 14:09:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPN95-0000000DOIl-1mXf for linux-arm-kernel@lists.infradead.org; Thu, 04 Jul 2024 14:09:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F369367; Thu, 4 Jul 2024 07:09:33 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C1D933F766; Thu, 4 Jul 2024 07:09:06 -0700 (PDT) Date: Thu, 4 Jul 2024 15:09:04 +0100 From: Cristian Marussi To: Peng Fan Cc: Sudeep Holla , "Peng Fan (OSS)" , "cristian.marussi@arm.com" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm-scmi@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH V2 1/2] dt-bindings: firmware: arm,scmi: introduce property mbox-rx-timeout-ms Message-ID: References: <20240703031715.379815-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_070911_980646_DA592D25 X-CRM114-Status: GOOD ( 33.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 04, 2024 at 12:33:09PM +0000, Peng Fan wrote: > > Subject: Re: [PATCH V2 1/2] dt-bindings: firmware: arm,scmi: introduce > > property mbox-rx-timeout-ms > > > > On Thu, Jul 04, 2024 at 10:39:53AM +0000, Peng Fan wrote: > > > > Subject: Re: [PATCH V2 1/2] dt-bindings: firmware: arm,scmi: > > > > introduce property mbox-rx-timeout-ms > > > > > > > > On Wed, Jul 03, 2024 at 11:17:14AM +0800, Peng Fan (OSS) wrote: > > > > > From: Peng Fan > > > > > > > > > > System Controller Management Interface(SCMI) firmwares might > > > > have > > > > > different designs by SCMI firmware developers. So the maximum > > > > receive > > > > > channel timeout value might also varies in the various designs. > > > > > > > > > > So introduce property mbox-rx-timeout-ms to let each platform > > > > > could set its own timeout value in device tree. > > > > > > > > > > Signed-off-by: Peng Fan > > > > > --- > > > > > > > > > > V2: > > > > > Drop defaults, update description. > > > > > > > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 6 > > > > ++++++ > > > > > 1 file changed, 6 insertions(+) > > > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > > > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > > > index ebf384e76df1..dcac0b36c76f 100644 > > > > > --- > > a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > > > +++ > > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > > > @@ -121,6 +121,12 @@ properties: > > > > > atomic mode of operation, even if requested. > > > > > default: 0 > > > > > > > > > > + max-rx-timeout-ms: > > > > > + description: > > > > > + An optional time value, expressed in milliseconds, > > > > > + representing > > > > the > > > > > + mailbox maximum timeout value for receive channel. The > > > > > + value > > > > should > > > > > + be a non-zero value if set. > > > > > + > > > > > > > > IIRC, you had the min and max constraint in the earlier response. > > > > You need to have rushed and posted another version before I could > > > > respond with my preference. > > > > > > > > So there is no rush, these are v6.12 material. Take time for > > > > respining and give some time for the review. > > > > > > Sure. I just not sure what the maximum should be set, so I drop the > > > minimum and maximum from my previous email. > > > > > > > Worst case we can just have min constraint to indicate it must be non- > > zero value as you have mentioned above and drop that statement as it > > becomes explicit with the constraint. > > I'll use below in v3: > max-rx-timeout-ms: > description: > An optional time value, expressed in milliseconds, representing the > mailbox maximum timeout value for receive channel. The value should > be a non-zero value if set. > minimum: 1 > > Put the binding away, when you have time, please check > whether the driver changes are good or not. > BTW, since our Android team is waiting for this patchset > got R-b or A-b, then the patches could be accepted by Google common > kernel, we could support GKI in our release which is soon in near > days. So I am being pushed :) Hi Peng, once the bindings are accepted I wanted to fold also this series of yours in my transport rework series. Thanks, Cristian