From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 867AEC30658 for ; Fri, 5 Jul 2024 10:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C0jbnV0W2mx7Vi5EwRNJVaHLABpWM8AEwOaP2sOv3DA=; b=aQwrM9jsFJWWihrx46ZiX8Luor GUUk4LsO3en/8ama+2cjMrjAZ+5ishqk1MsN+DJ7YTzyeh9HiOd6nnG4JdC27ZQadmVaPkFu8gF1F /BPpI9WIppQE/kUQ67bjmulxIAKIFcUP+mhGUKWi6l6Wqp5vVg07IXjdPkdPTxDu+P+kQDC3jniVm SiIxY57QwpXBndGcsXCpzDRW/LZD+H6xrnDsX82dtEwWV9AvDMeVAsBsH1MuapGiTudqpVT97Xi7s /gI/NHIMRfG7R7KqWN7zdJPiwHX+RMAOEH4GqEDoOmIiYbv1LbpDBGwvWHMS71RERH5tclt/k+urq qcqDgQGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPgEN-0000000FeaZ-3ZS8; Fri, 05 Jul 2024 10:31:56 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPgE9-0000000FeBW-3fuS for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2024 10:31:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=C0jbnV0W2mx7Vi5EwRNJVaHLABpWM8AEwOaP2sOv3DA=; b=Lr0DE2Jq67LPKkM8mklvhlvB6T l8PlbaAmV2wBg5o9+ce267a50sAjy0aYUo8xeQCDviOvTng7uubSI+kdM82sizgNDk8mVtQamtEAj 79OLBrT2uXlqILCQvtq+U0wyzvCw61t9v/9dWANtuBDpxkUTszNJt2HpK/6WzmQhzGOOMwpOMVIiW pZOilgBY47UWGPmAEFzo1qJka/AnJwBfpLipDIAc3zgGTgHjSgJhtnKTb7T0x9Ngx/aIOjgIzdDSy RegPMYtFHKgPwu2s2QzpWkishLtVDYezT2b4X178BQKwhgZyPcYLKNGGgjkCht5XG6i5yVP6tDNcA z7kTiWLQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:50258) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sPgBn-0008Bb-39; Fri, 05 Jul 2024 11:29:16 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sPgBn-0004oz-As; Fri, 05 Jul 2024 11:29:15 +0100 Date: Fri, 5 Jul 2024 11:29:15 +0100 From: "Russell King (Oracle)" To: Tiezhu Yang Cc: Will Deacon , Mark Rutland , Catalin Marinas , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] hw_breakpoint: Save privilege of access control via ptrace Message-ID: References: <20240621073910.8465-1-yangtiezhu@loongson.cn> <5ab53836-5a11-a47b-042e-96c5c9e70974@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ab53836-5a11-a47b-042e-96c5c9e70974@loongson.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240705_033141_925503_4231F7E4 X-CRM114-Status: GOOD ( 24.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 04, 2024 at 10:47:59PM +0800, Tiezhu Yang wrote: > On 6/21/24 15:39, Tiezhu Yang wrote: > > Hi all, > > > > Thank you very much for your feedbacks in the v1 patch. > > This series is based on 6.10-rc4, cross compile tested only. > > > > As far as I can tell, these changes are not relevant with tools/perf, > > on some archs such as ARM, ARM64 and LoongArch which have privilege > > level of breakpoint, the initial aim is to make use of the value of > > ctrl->privilege saved in decode_ctrl_reg() and then remove the check > > whether bp virtual address is in kernel space to assign value for > > hw->ctrl.privilege in arch_build_bp_info(). > > > > v2: > > -- Put the new member "bp_priv" at the end of the uapi > > struct perf_event_attr and add PERF_ATTR_SIZE_VER9. > > -- Update the commit message to make the goal clear. > > > > Tiezhu Yang (3): > > perf: Add perf_event_attr::bp_priv > > arm: hw_breakpoint: Save privilege of access control via ptrace > > arm64: hw_breakpoint: Save privilege of access control via ptrace > > > > arch/arm/kernel/hw_breakpoint.c | 4 +--- > > arch/arm/kernel/ptrace.c | 2 ++ > > arch/arm64/kernel/hw_breakpoint.c | 11 ++--------- > > arch/arm64/kernel/ptrace.c | 2 ++ > > include/uapi/linux/perf_event.h | 3 +++ > > kernel/events/hw_breakpoint.c | 1 + > > 6 files changed, 11 insertions(+), 12 deletions(-) > > Ping, any more comments? Is it possible to merge this series > for the coming merge window? Maybe someone who knows the perf stuff can review it and give an opinion? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!