From: Kousik Sanagavarapu <five231003@gmail.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Julia Lawall <julia.lawall@inria.fr>, Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] soc: ti: pm33xx: do device_node auto cleanup
Date: Fri, 5 Jul 2024 16:41:20 +0530 [thread overview]
Message-ID: <ZofU2ABYrB9Q0ZyR@five231003> (raw)
In-Reply-To: <20240705115413.0000307d@Huawei.com>
Hi Jonathan,
On Fri, Jul 05, 2024 at 11:54:13AM +0100, Jonathan Cameron wrote:
> On Wed, 3 Jul 2024 12:25:28 +0530
> Kousik Sanagavarapu <five231003@gmail.com> wrote:
>
> > Use scope based cleanup instead of manual of_node_put() calls, hence
> > simplifying the handling of error paths.
> >
> > Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> > Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
> I think you can make use of dev_err_probe() in here to
> further simplify things (a bit anyway!)
The changes proposed on all the patches make sense. I'll send out v3
soon.
I hadn't caught the dev_err_probe() change in this patch ;) while
preparing this series. I'll make the changes.
Thanks for the review
prev parent reply other threads:[~2024-07-05 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 6:55 [PATCH v2 0/3] Do device node auto cleanup in drivers/soc/ti/ Kousik Sanagavarapu
2024-07-03 6:55 ` [PATCH v2 1/3] soc: ti: pruss: do device_node auto cleanup Kousik Sanagavarapu
2024-07-05 10:49 ` Jonathan Cameron
2024-07-03 6:55 ` [PATCH v2 2/3] soc: ti: knav_qmss_queue: " Kousik Sanagavarapu
2024-07-05 10:52 ` Jonathan Cameron
2024-07-03 6:55 ` [PATCH v2 3/3] soc: ti: pm33xx: " Kousik Sanagavarapu
2024-07-05 10:54 ` Jonathan Cameron
2024-07-05 11:11 ` Kousik Sanagavarapu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZofU2ABYrB9Q0ZyR@five231003 \
--to=five231003@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=nm@ti.com \
--cc=skhan@linuxfoundation.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).