From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06A0FC30658 for ; Fri, 5 Jul 2024 11:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kedp5pEchF6jn5ZJLNyxEV3NfW0tGv6Nmb7MddPZUNo=; b=IgEiGMeOxiYeIZE/COSZaVtgwt pUm4fkiG/nkLcxrIdHka4gJW7yaT2tq5UjACPEOwIsRlKfYTHsoZ+4VuRjDXaUHr1R+Nu2NxbUyGU cyqcGRDdwqGab3V7pufmgHcdeYmMG6/kkcxJq7ZzWSxAX2CCeIKMomDPAERhKBXrfWq0lETMWSQax 1nr5KdqSNtH1qJhl4VxEbCFr3p26QxTpQSYPo5qf2cnhGzSXojko2rj7i1YiOD+7gvoZoisEbLAe8 GI3HZRn7sTq5DCPucQZwhlGrtRMotaqEIvbhG0Mr5cQltfFU6mIJAWsoNTxS2fFvnyP9lmsdIda3o jbL56lbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPgrY-0000000FkVw-3Ot2; Fri, 05 Jul 2024 11:12:24 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPgrJ-0000000FkSu-3a0t for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2024 11:12:11 +0000 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-70b2421471aso860643a12.0 for ; Fri, 05 Jul 2024 04:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720177928; x=1720782728; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kedp5pEchF6jn5ZJLNyxEV3NfW0tGv6Nmb7MddPZUNo=; b=hpHbu6CTv1xADwe5QzBDUju9c4EzwUI72yp/OagTKGVbv9En836LlTyRa4PeKZ0kom nh1O7vOqFqtJQ/4xbdOKOF7zEip7paOGgo3+PccrQDmLRVxcKGP+pqyGG+A5hdvEIJ9D muYQXxKKY8El9MqXm0DQ2Y4vEMfs8CjdF3i538Ml7OZlC6ljqCgsV5xcHNo4f3ly17+r qID/ltyow6h1kLY5EFGU53MfLbrT0HkcyIiCcFnud4ASbyNbWvP1/3Y4LWf+KiSKQzV+ Hihxs6odBHhAuatfG8rG1cD7R/YkzB+Wj0qg5jwOiJ5hZ63sftXUj0U4dTfic9dgcmVG M/UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720177928; x=1720782728; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kedp5pEchF6jn5ZJLNyxEV3NfW0tGv6Nmb7MddPZUNo=; b=erp89z0Y87+RIljiaCj3l6Es0UZVDhgCWlQ6n517EM5BvnoRaG5L6k6NrN3YyldxdX 1fLbQwxEHSSIXw6GbbRFtDnJqhqU400Rh7R/WTEs/Nl/CxI0IuCYtSed5Oc26LeKPd8V ofnwajLZd49xi2rKmjDmJIQeF7EHHIfclLSWVyKbFUtZrsa1hbXaY9MHMhTbjiBW01Qy aT9BDOGZMRP8T3uv/s+s+vq18kfApaj3UyePA8yOk4+ta7dqxtrfqNem7O4RyDG3ta0w xTKZ4IwxbMqGoXuBvrMrlVccDr8xffui8S6EGM6SiRzVQthzjUz1zRuo/GGTpTMPmLdU 0sKw== X-Forwarded-Encrypted: i=1; AJvYcCWBwWrCL1Z4nrlWgOeanrvh1ET0Nk2Jkr3x55RrEEZJOpYXYTkYVnzZzQTfcac9pg/WH0rSc025mPnBHdsos5OTWC6jmlekgU2n47C/PviL3cd8O/g= X-Gm-Message-State: AOJu0YxkLdMoJw37TerYNd0NYRk1yMq7HXf8ZzqYxGopfmqT6JzQrQTE Qxnl+38Hxr4IeT81k9ffY6lvW+W8vpf5qTe9K5bQ9wDFKDlGNbk4 X-Google-Smtp-Source: AGHT+IH8Rr51cNn4PUmIUuEywbXk4qRu7nqR1De6CpR9xz7j9diozlUfO0bdN6i6ZKNQSjXIAKALKg== X-Received: by 2002:a05:6a21:6d98:b0:1be:cc74:5818 with SMTP id adf61e73a8af0-1c0cc73adcamr4221809637.12.1720177928014; Fri, 05 Jul 2024 04:12:08 -0700 (PDT) Received: from five231003 ([2405:201:c006:312d:e14f:e5d:8437:cf1b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c99a989405sm3132132a91.27.2024.07.05.04.12.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 04:12:07 -0700 (PDT) Date: Fri, 5 Jul 2024 16:41:20 +0530 From: Kousik Sanagavarapu To: Jonathan Cameron Cc: Julia Lawall , Nishanth Menon , Santosh Shilimkar , Nathan Chancellor , Shuah Khan , Javier Carrasco , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] soc: ti: pm33xx: do device_node auto cleanup Message-ID: References: <20240703065710.13786-1-five231003@gmail.com> <20240703065710.13786-4-five231003@gmail.com> <20240705115413.0000307d@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240705115413.0000307d@Huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240705_041209_918469_0AF75068 X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonathan, On Fri, Jul 05, 2024 at 11:54:13AM +0100, Jonathan Cameron wrote: > On Wed, 3 Jul 2024 12:25:28 +0530 > Kousik Sanagavarapu wrote: > > > Use scope based cleanup instead of manual of_node_put() calls, hence > > simplifying the handling of error paths. > > > > Suggested-by: Julia Lawall > > Signed-off-by: Kousik Sanagavarapu > I think you can make use of dev_err_probe() in here to > further simplify things (a bit anyway!) The changes proposed on all the patches make sense. I'll send out v3 soon. I hadn't caught the dev_err_probe() change in this patch ;) while preparing this series. I'll make the changes. Thanks for the review