From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14AC8C2BD09 for ; Sat, 6 Jul 2024 08:27:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0Bl4Yy6lI/tXlJqZpnDeRNQLPG26OK3yn+0UQItec8c=; b=bQ6A/J516ZXLYIZYAXdO5mLfeF 8up2rCxSRSD62nH940limNjFF3Wh1ldnTHomeRPYHo3onx1FfO5RQP0AsouKkEOws4HKLB2szRJIf kkRp0vJEoWsPsn0FQSQpVpfcmhLH+UVJsKALPsEQeMF9//A940Acy1sE/TrpJYvk9kD+b3bUN91MX u81RoznMyQ3fFUuSx6E6xKI9j8SOT+btSi5OscD6UyobIwqd8MvIUz5LuLv5wMKyTL9czLASkGzcK bKh19uzELgCKENhigYPxPpRQFmr+Nsz4+SogGM5zM8LF3cUa3sPSOHdJaxsPiN6U6gS0PFjOFJIS3 OdDdFNVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQ0lN-0000000HXYt-1T1Z; Sat, 06 Jul 2024 08:27:21 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQ0l7-0000000HXWb-3Ppc for linux-arm-kernel@lists.infradead.org; Sat, 06 Jul 2024 08:27:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id ABC0C617DA; Sat, 6 Jul 2024 08:27:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCA44C2BD10; Sat, 6 Jul 2024 08:27:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720254424; bh=M6+fHN1AEi9CB+3l+2Srv46yNUZTmn7y+xxi7u1G4fo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NtSa2tiwPeLWfiiIsg5HO6kEApmqDf3Q5LNMTeQIzzUV6rWjD70ZZ6e1rvgb+RY5Q niHiq85LuDrpq4A3z0qPMMIjrtYivhNz61ofRNPu8WlOiKjkJfs3oihkeJ8V/hFPar hQpX+KKBkHzy0Xb9g7UZBPcATlaNAu5Q8do54op5KLSfsBjTbVt0iIWGocBOGuMxk1 hNyYNgqGx4C3Cw2MP0KSzpbl/IulpkaYUN+ra1hY43X3Att0xp/wuQ4kLJ6mUfrcx0 BbMMHX9KzTjUj83nnj5ZeJvtvQ3jb0nMm/jHWFlJk4SDnlUMEyiKmpxPJQWQeaz41N 9rqqetqYjDmxg== Date: Sat, 6 Jul 2024 10:27:00 +0200 From: Lorenzo Bianconi To: Simon Horman Cc: netdev@vger.kernel.org, nbd@nbd.name, lorenzo.bianconi83@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, angelogioacchino.delregno@collabora.com, benjamin.larsson@genexis.eu, rkannoth@marvell.com, sgoutham@marvell.com, andrew@lunn.ch, arnd@arndb.de Subject: Re: [PATCH v5 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC Message-ID: References: <18e837f0f9377b68302d42ec9174473046a4a30a.1720079772.git.lorenzo@kernel.org> <20240705190644.GB1480790@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="e9Qd3RQOvsLYnCSp" Content-Disposition: inline In-Reply-To: <20240705190644.GB1480790@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240706_012705_980344_28CC0625 X-CRM114-Status: GOOD ( 22.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --e9Qd3RQOvsLYnCSp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Thu, Jul 04, 2024 at 10:08:11AM +0200, Lorenzo Bianconi wrote: > > Add airoha_eth driver in order to introduce ethernet support for > > Airoha EN7581 SoC available on EN7581 development board (en7581-evb). > > en7581-evb networking architecture is composed by airoha_eth as mac > > controller (cpu port) and a mt7530 dsa based switch. > > EN7581 mac controller is mainly composed by Frame Engine (FE) and > > QoS-DMA (QDMA) modules. FE is used for traffic offloading (just basic > > functionalities are supported now) while QDMA is used for DMA operation > > and QOS functionalities between mac layer and the dsa switch (hw QoS is > > not available yet and it will be added in the future). > > Currently only hw lan features are available, hw wan will be added with > > subsequent patches. > >=20 > > Tested-by: Benjamin Larsson > > Signed-off-by: Lorenzo Bianconi >=20 > ... >=20 > > +static const char * const airoha_ethtool_stats_name[] =3D { > > + "tx_eth_pkt_cnt", > > + "tx_eth_byte_cnt", > > + "tx_ok_pkt_cnt", > > + "tx_ok_byte_cnt", > > + "tx_eth_drop_cnt", > > + "tx_eth_bc_cnt", > > + "tx_eth_mc_cnt", > > + "tx_eth_lt64_cnt", > > + "tx_eth_eq64_cnt", > > + "tx_eth_65_127_cnt", > > + "tx_eth_128_255_cnt", > > + "tx_eth_256_511_cnt", > > + "tx_eth_512_1023_cnt", > > + "tx_eth_1024_1518_cnt", > > + "tx_eth_gt1518_cnt", > > + "rx_eth_pkt_cnt", > > + "rx_eth_byte_cnt", > > + "rx_ok_pkt_cnt", > > + "rx_ok_byte_cnt", > > + "rx_eth_drop_cnt", > > + "rx_eth_bc_cnt", > > + "rx_eth_mc_cnt", > > + "rx_eth_crc_drop_cnt", > > + "rx_eth_frag_cnt", > > + "rx_eth_jabber_cnt", > > + "rx_eth_lt64_cnt", > > + "rx_eth_eq64_cnt", > > + "rx_eth_65_127_cnt", > > + "rx_eth_128_255_cnt", > > + "rx_eth_256_511_cnt", > > + "rx_eth_512_1023_cnt", > > + "rx_eth_1024_1518_cnt", > > + "rx_eth_gt1518_cnt", > > +}; >=20 > Hi Lorenzo, >=20 > Sorry for not noticing this earlier. Hi Simon, no worries :) > It seems to me that some of the stats above could > use standard stats, which is preferred. Please correct me if I am wrong but it seems quite a common approach to have same stats in both .ndo_get_stats64() and .get_ethtool_stats(): - https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/mediat= ek/mtk_eth_soc.c#L212 - https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/marvel= l/mvneta.c#L435 - https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/intel/= i40e/i40e_ethtool.c#L243 - https://github.com/torvalds/linux/blob/master/net/mac80211/ethtool.c#L52 - ... Do you mean I should just report common stats (e.g. tx_packets or tx_bytes)= in =2Endo_get_stats64()? Or it is fine to just add .ndo_get_stats64() callback= (not supported at the moment)? >=20 > Basically, my understanding is that one should: > 1. Implement .ndo_get_stats64 > (that seems relevant here) > 2. As appropriate implement ethtool_stats non-extended stats operations > (perhaps not relevant here) Can you please provide me a pointer for it? Regards, Lorenzo > 3. Then implement get_ethtool_stats for what is left over >=20 > ... --e9Qd3RQOvsLYnCSp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZoj/1AAKCRA6cBh0uS2t rMz9AP9MzbgdWOnzGFjTORujUuSSV71mqFBBnS1lDWiHLuAtMwD/SH5Wf6ceA5AJ N9DYzOkkdoLeTRnlQD1UoFKyLsYeiA4= =F08X -----END PGP SIGNATURE----- --e9Qd3RQOvsLYnCSp--