From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B16CC3271E for ; Mon, 8 Jul 2024 10:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6rUTywwaukb7isS5o6FNw2xsqn0CHrrYOywNy9T/mHA=; b=DfZ+W7dKwcD8fNtlYLasdjR+Db CHJrOJjhTYcSOIHm0WUhEY/x83n7GGEWls3cfV0JUCUgj+jWXzLIi9Ykz80QSb1J6rkoMujNWRFA2 P8chmZsyTDhlWpuUHxj7qsu3Okl7wjBpcYioHjqesX2SdpR3qPQWjFpq2UnYVsBtu6/9iGjwlF+U7 uu+akMYDSLxyWaFKzODZYtZGOsr275n6i8Y4E4Oi8/cqrmGhYVrjpjz0TRvopg0FRwWiGVSx3pwrv 3o+piREtiaSBq7Kl4xXM4xPJCF3tzuQigE+VRBsa5RD2SUlpv1d8oTsQQ1c4pyivTB4gVJzyF1o8E JBOVhDAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQlYy-00000003RTW-0RAV; Mon, 08 Jul 2024 10:25:40 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQlYj-00000003RRT-02RY for linux-arm-kernel@lists.infradead.org; Mon, 08 Jul 2024 10:25:26 +0000 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4680BsBZ009429; Mon, 8 Jul 2024 10:25:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6rUTywwaukb7isS5o6FNw2xsqn0CHrrYOywNy9T/mHA=; b=OsV8IwhODkrNKVgL qGgobYv7+Wf0En03iU8FesCVz2wPF7iM7LWXo75fVO2xLVf+hvCoWDBkzC88wxy0 OqRNJQ+PNka4s7iCRxlyzC1P4UG/nhEWW8q9Euzi0oVO/wyhI2POYqTDNE+Lfm6E lI2YFlp/yqYcl3SDKd5uvKkZCxbgdq5NXCtb84NhGKK6jhXr9UXLHUouEtwD8ZTT W6wq2veL4AnsmG/5ujalKUNpbkoe/tidudIysCAFAqd53cIwaYqY5AAoCFm3rxn5 KywuwIKvBtid0TbDvCdKX72+epcchz2zcRXACgc+KSm+sBHHESaUvAUwuve60OBW xI2gMQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 406wmmkafn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Jul 2024 10:25:18 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 468APHm4006976 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 8 Jul 2024 10:25:17 GMT Received: from jiegan-gv.ap.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 8 Jul 2024 03:25:06 -0700 Date: Mon, 8 Jul 2024 18:25:02 +0800 From: JieGan To: Suzuki K Poulose CC: Mathieu Poirier , Alexander Shishkin , Mike Leach , "Rob Herring" , Krzysztof Kozlowski , James Clark , Jinlong Mao , Leo Yan , , , , , Tingwei Zhang , Yuanfang Zhang , "Tao Zhang" , Trilok Soni , "Song Chai" , Subject: Re: [PATCH v2 2/4] dt-bindings: arm: Add binding document for Coresight Control Unit device. Message-ID: References: <20240705090049.1656986-1-quic_jiegan@quicinc.com> <20240705090049.1656986-3-quic_jiegan@quicinc.com> <208b3861-6898-4506-9152-c9d770ef1555@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: AS9dMf-4Hfpk0A-KTOTsQRzPu7rDmu1H X-Proofpoint-ORIG-GUID: AS9dMf-4Hfpk0A-KTOTsQRzPu7rDmu1H X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-08_05,2024-07-05_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 spamscore=0 bulkscore=0 adultscore=2 impostorscore=0 suspectscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2407080081 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240708_032525_084601_839D7403 X-CRM114-Status: GOOD ( 27.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 08, 2024 at 06:10:28PM +0800, JieGan wrote: > On Mon, Jul 08, 2024 at 10:41:55AM +0100, Suzuki K Poulose wrote: > > On 05/07/2024 10:00, Jie Gan wrote: > > > Add binding document for Coresight Control Unit device. > > > > nit: This is again too generic ? corsight-tmc-control-unit ? After all > > thats what it is and not a *generic* coresight control unit ? > > > coresight-tmc-control-unit is much better. We will check it. > > > > > > > Signed-off-by: Jie Gan > > > --- > > > .../bindings/arm/qcom,coresight-ccu.yaml | 87 +++++++++++++++++++ > > > 1 file changed, 87 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/arm/qcom,coresight-ccu.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-ccu.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-ccu.yaml > > > new file mode 100644 > > > index 000000000000..9bb8ced393a7 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-ccu.yaml > > > @@ -0,0 +1,87 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/arm/qcom,coresight-ccu.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: CoreSight Control Unit > > > + > > > +maintainers: > > > + - Yuanfang Zhang > > > + - Mao Jinlong > > > + - Jie Gan > > > + > > > +description: > > > + The Coresight Control unit controls various Coresight behaviors. > > > + Used to enable/disable ETR’s data filter function based on trace ID. > > > + > > > +properties: > > > + compatible: > > > + const: qcom,coresight-ccu > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + clocks: > > > + maxItems: 1 > > > + > > > + clock-names: > > > + items: > > > + - const: apb_pclk > > > + > > > + reg-names: > > > + items: > > > + - const: ccu-base > > > + > > > + in-ports: > > > + $ref: /schemas/graph.yaml#/properties/ports > > > + > > > + unevaluatedProperties: > > > + patternProperties: > > > + '^port(@[0-7])?$': > > > + description: Input connections from CoreSight Trace bus > > > + $ref: /schemas/graph.yaml#/properties/port > > > + > > > + properties: > > > + qcom,ccu-atid-offset: > > > > Why do we need this atid offset ? Couldn't this be mapped to the "port" > > number ? > > > > e.g, input-port 0 on CCU => Offset x > > input-port 1 on CCU => (Offset x + Size of 1 region) > If the first ATID offset remains constant, it appears to be feasible. > We will consider the possibility of this solution. We just checked the ATID offset varies across different hardware platforms. It defined as 0xf4 on some platforms, and some others defined as 0xf8. So I think it should be better to define it in device tree node. > > > > > I believe I mentioned this in the previous posting too ? > Yes, you mentioned before. I moved it from TMC filed to CCU filed. > > > > > Suzuki > > >