From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAFB1C3DA41 for ; Mon, 8 Jul 2024 19:47:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F08eTq/6nl01fY8iwc+0cvJBVd8iVm6DBYfEM30lJgk=; b=pkEMV7f76k1RbR9Xo/EaXU4AEx kIryy9L9TNa89AA9o/YlB58QgtUvbHYO+Ouwm3Fs7TyuxPvTUnUnQTzc2YOd2/ApqM1KV0vHT8bxN fGAofDVpQIvylBoON0tpCPG94uhWuzrydOBjjXAzZW9/Ehr0RaKspjIeJ6G/aRYrg4G23QiDOnl7d Wbw/IM+5EfxjPbp7OsKy4vixIHCOjZqiuhth0mVsY6LSrj4G9j0ytSowFb/5oE2hpJmmgHCjakXkX bNpvP7DgRLzAmwy4vniUAMGTTJRtWihCIVAerX5Wfyso0WbHDlcZgIJ1Buagc70XAq7d7VCWj4SZq tIDn9U+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQuKv-00000004sHH-0OF5; Mon, 08 Jul 2024 19:47:45 +0000 Received: from out-176.mta1.migadu.com ([95.215.58.176]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQuKb-00000004sDi-3GJ3 for linux-arm-kernel@lists.infradead.org; Mon, 08 Jul 2024 19:47:28 +0000 X-Envelope-To: sebastianene@google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1720468040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F08eTq/6nl01fY8iwc+0cvJBVd8iVm6DBYfEM30lJgk=; b=ADflN0E0yjOghOgax/9LJATZ6vo0QSa/QR9voOkwD3KwJ/jYzDhMGuA2vSEOMFa4ui11mq w7kebZgojfFpY42MyVdzXYr+mNohvsZJqsF9hujVgmQAtv3nbcphuRRKPYjePZN4eDbRlS SvZCp6hs5yRxVxUEjDsXQXze2O7Bv9A= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: alexghiti@rivosinc.com X-Envelope-To: ankita@nvidia.com X-Envelope-To: ardb@kernel.org X-Envelope-To: catalin.marinas@arm.com X-Envelope-To: christophe.leroy@csgroup.eu X-Envelope-To: james.morse@arm.com X-Envelope-To: vdonnefort@google.com X-Envelope-To: mark.rutland@arm.com X-Envelope-To: maz@kernel.org X-Envelope-To: rananta@google.com X-Envelope-To: ryan.roberts@arm.com X-Envelope-To: shahuang@redhat.com X-Envelope-To: suzuki.poulose@arm.com X-Envelope-To: will@kernel.org X-Envelope-To: yuzenghui@huawei.com X-Envelope-To: kvmarm@lists.linux.dev X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: kernel-team@android.com Date: Mon, 8 Jul 2024 19:47:13 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Sebastian Ene Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, vdonnefort@google.com, mark.rutland@arm.com, maz@kernel.org, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v7 5/6] KVM: arm64: Initialize the ptdump parser with stage-2 attributes Message-ID: References: <20240621123230.1085265-1-sebastianene@google.com> <20240621123230.1085265-6-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240708_124727_038159_1F465BFC X-CRM114-Status: GOOD ( 11.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 01, 2024 at 02:17:53PM +0000, Sebastian Ene wrote: > > > > > > > + }, { > > > + .mask = PTE_NG, > > > + .val = PTE_NG, > > > + .set = "FnXS", > > > + .clear = " ", > > > + }, { > > > + .mask = PTE_CONT | PTE_VALID, > > > + .val = PTE_CONT | PTE_VALID, > > > + .set = "CON", > > > + .clear = " ", > > > + }, { > > > > > > > > Neither of these bits are used at stage-2, why have descriptors for > > them? > > > > Atm, we don't make use of the contiguous bit in stage-2 in upstream (but > we have it in some experimental patches). I can remove this, no hard > feelings for them. Yes, please drop them. I'll nag whoever adds contpte support for stage-2 to add them back :) -- Thanks, Oliver