* [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'
@ 2024-05-28 23:11 linux
2024-05-30 14:59 ` Sean Anderson
2024-08-12 11:59 ` Michael Ellerman
0 siblings, 2 replies; 6+ messages in thread
From: linux @ 2024-05-28 23:11 UTC (permalink / raw)
To: sean.anderson, camelia.groza
Cc: linuxppc-dev, linux-arm-kernel, linux-kernel,
Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'cgr_comp' has been unused since
commit 96f413f47677 ("soc/fsl/qbman: fix issue in
qman_delete_cgr_safe()").
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/soc/fsl/qbman/qman.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
index 7e9074519ad2..4dc8aba33d9b 100644
--- a/drivers/soc/fsl/qbman/qman.c
+++ b/drivers/soc/fsl/qbman/qman.c
@@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
}
EXPORT_SYMBOL(qman_delete_cgr);
-struct cgr_comp {
- struct qman_cgr *cgr;
- struct completion completion;
-};
-
static void qman_delete_cgr_smp_call(void *p)
{
qman_delete_cgr((struct qman_cgr *)p);
--
2.45.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'
2024-05-28 23:11 [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp' linux
@ 2024-05-30 14:59 ` Sean Anderson
2024-07-21 22:50 ` Dr. David Alan Gilbert
2024-08-12 11:59 ` Michael Ellerman
1 sibling, 1 reply; 6+ messages in thread
From: Sean Anderson @ 2024-05-30 14:59 UTC (permalink / raw)
To: linux, camelia.groza; +Cc: linuxppc-dev, linux-arm-kernel, linux-kernel
On 5/28/24 19:11, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'cgr_comp' has been unused since
> commit 96f413f47677 ("soc/fsl/qbman: fix issue in
> qman_delete_cgr_safe()").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> drivers/soc/fsl/qbman/qman.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
> index 7e9074519ad2..4dc8aba33d9b 100644
> --- a/drivers/soc/fsl/qbman/qman.c
> +++ b/drivers/soc/fsl/qbman/qman.c
> @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
> }
> EXPORT_SYMBOL(qman_delete_cgr);
>
> -struct cgr_comp {
> - struct qman_cgr *cgr;
> - struct completion completion;
> -};
> -
> static void qman_delete_cgr_smp_call(void *p)
> {
> qman_delete_cgr((struct qman_cgr *)p);
Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'
2024-05-30 14:59 ` Sean Anderson
@ 2024-07-21 22:50 ` Dr. David Alan Gilbert
2024-07-22 7:24 ` Michael Ellerman
0 siblings, 1 reply; 6+ messages in thread
From: Dr. David Alan Gilbert @ 2024-07-21 22:50 UTC (permalink / raw)
To: Sean Anderson; +Cc: camelia.groza, linuxppc-dev, linux-arm-kernel, linux-kernel
* Sean Anderson (sean.anderson@linux.dev) wrote:
> On 5/28/24 19:11, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > 'cgr_comp' has been unused since
> > commit 96f413f47677 ("soc/fsl/qbman: fix issue in
> > qman_delete_cgr_safe()").
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> > drivers/soc/fsl/qbman/qman.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
> > index 7e9074519ad2..4dc8aba33d9b 100644
> > --- a/drivers/soc/fsl/qbman/qman.c
> > +++ b/drivers/soc/fsl/qbman/qman.c
> > @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
> > }
> > EXPORT_SYMBOL(qman_delete_cgr);
> >
> > -struct cgr_comp {
> > - struct qman_cgr *cgr;
> > - struct completion completion;
> > -};
> > -
> > static void qman_delete_cgr_smp_call(void *p)
> > {
> > qman_delete_cgr((struct qman_cgr *)p);
>
> Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
Hi Sean,
Do you know who will pick this one up?
I got a notification a while ago from a patchwork at
linuxppc-dev marked 'Handled elsewhere' - but I'm not
sure where.
Thanks,
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'
2024-07-21 22:50 ` Dr. David Alan Gilbert
@ 2024-07-22 7:24 ` Michael Ellerman
2024-07-22 17:14 ` Christophe Leroy
0 siblings, 1 reply; 6+ messages in thread
From: Michael Ellerman @ 2024-07-22 7:24 UTC (permalink / raw)
To: Dr. David Alan Gilbert, Sean Anderson, Christophe Leroy
Cc: camelia.groza, linuxppc-dev, linux-arm-kernel, linux-kernel
"Dr. David Alan Gilbert" <linux@treblig.org> writes:
> * Sean Anderson (sean.anderson@linux.dev) wrote:
>> On 5/28/24 19:11, linux@treblig.org wrote:
>> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
>> >
>> > 'cgr_comp' has been unused since
>> > commit 96f413f47677 ("soc/fsl/qbman: fix issue in
>> > qman_delete_cgr_safe()").
>> >
>> > Remove it.
>> >
>> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>> > ---
>> > drivers/soc/fsl/qbman/qman.c | 5 -----
>> > 1 file changed, 5 deletions(-)
>> >
>> > diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
>> > index 7e9074519ad2..4dc8aba33d9b 100644
>> > --- a/drivers/soc/fsl/qbman/qman.c
>> > +++ b/drivers/soc/fsl/qbman/qman.c
>> > @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
>> > }
>> > EXPORT_SYMBOL(qman_delete_cgr);
>> >
>> > -struct cgr_comp {
>> > - struct qman_cgr *cgr;
>> > - struct completion completion;
>> > -};
>> > -
>> > static void qman_delete_cgr_smp_call(void *p)
>> > {
>> > qman_delete_cgr((struct qman_cgr *)p);
>>
>> Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
>
> Hi Sean,
> Do you know who will pick this one up?
> I got a notification a while ago from a patchwork at
> linuxppc-dev marked 'Handled elsewhere' - but I'm not
> sure where.
drivers/soc/fsl was orphaned, but Christophe has recently volunteered to
look after it.
This patch looks trivial so I can just pick it up if you like Christophe?
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'
2024-07-22 7:24 ` Michael Ellerman
@ 2024-07-22 17:14 ` Christophe Leroy
0 siblings, 0 replies; 6+ messages in thread
From: Christophe Leroy @ 2024-07-22 17:14 UTC (permalink / raw)
To: Michael Ellerman, Dr. David Alan Gilbert, Sean Anderson,
Christophe Leroy
Cc: camelia.groza, linuxppc-dev, linux-arm-kernel, linux-kernel
Le 22/07/2024 à 09:24, Michael Ellerman a écrit :
> "Dr. David Alan Gilbert" <linux@treblig.org> writes:
>> * Sean Anderson (sean.anderson@linux.dev) wrote:
>>> On 5/28/24 19:11, linux@treblig.org wrote:
>>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>>
>>>> 'cgr_comp' has been unused since
>>>> commit 96f413f47677 ("soc/fsl/qbman: fix issue in
>>>> qman_delete_cgr_safe()").
>>>>
>>>> Remove it.
>>>>
>>>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>>>> ---
>>>> drivers/soc/fsl/qbman/qman.c | 5 -----
>>>> 1 file changed, 5 deletions(-)
>>>>
>>>> diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
>>>> index 7e9074519ad2..4dc8aba33d9b 100644
>>>> --- a/drivers/soc/fsl/qbman/qman.c
>>>> +++ b/drivers/soc/fsl/qbman/qman.c
>>>> @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
>>>> }
>>>> EXPORT_SYMBOL(qman_delete_cgr);
>>>>
>>>> -struct cgr_comp {
>>>> - struct qman_cgr *cgr;
>>>> - struct completion completion;
>>>> -};
>>>> -
>>>> static void qman_delete_cgr_smp_call(void *p)
>>>> {
>>>> qman_delete_cgr((struct qman_cgr *)p);
>>>
>>> Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
>>
>> Hi Sean,
>> Do you know who will pick this one up?
>> I got a notification a while ago from a patchwork at
>> linuxppc-dev marked 'Handled elsewhere' - but I'm not
>> sure where.
>
> drivers/soc/fsl was orphaned, but Christophe has recently volunteered to
> look after it.
>
> This patch looks trivial so I can just pick it up if you like Christophe?
>
Sure Michael, you can pick it up.
Thanks
Christophe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'
2024-05-28 23:11 [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp' linux
2024-05-30 14:59 ` Sean Anderson
@ 2024-08-12 11:59 ` Michael Ellerman
1 sibling, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2024-08-12 11:59 UTC (permalink / raw)
To: sean.anderson, camelia.groza, linux
Cc: linuxppc-dev, linux-arm-kernel, linux-kernel
On Wed, 29 May 2024 00:11:23 +0100, linux@treblig.org wrote:
> 'cgr_comp' has been unused since
> commit 96f413f47677 ("soc/fsl/qbman: fix issue in
> qman_delete_cgr_safe()").
>
> Remove it.
>
>
> [...]
Applied to powerpc/fixes.
[1/1] soc/fsl/qbman: remove unused struct 'cgr_comp'
https://git.kernel.org/powerpc/c/06ce0af34177a110d6a5cf71f924965b9b230691
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-12 12:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-28 23:11 [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp' linux
2024-05-30 14:59 ` Sean Anderson
2024-07-21 22:50 ` Dr. David Alan Gilbert
2024-07-22 7:24 ` Michael Ellerman
2024-07-22 17:14 ` Christophe Leroy
2024-08-12 11:59 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).