From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45F2FC3DA61 for ; Sun, 21 Jul 2024 22:51:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z6+tcN90xgP1nrdUqmcA2EVQqwgriS18uB284QzrNV8=; b=EguELlGQRKCPzuH7buVhnW9+PT 43VVbG0G471ZDlprf0RUsHI2WnmVI+OFkZOvel0ArCguHks+oZlqSGtO3fMzEPSNDB+jwnfIYDIoU +XrQt2kWpZNMHJUBOh2eLEN43wPZEUVgoj1IQkbklZahq3MFAjqtN9cRCr9Rj48e5ihqrvse4LbHt OtS1tKddCJkg95CWw+NrvNL807yCjJaXWWHum3pTItFKMl5MWNT1pVFt3Mi2/PNaprk/M+UVtoIy/ aQFDpcSmKUeQXQY5/nYirxtxssLuCNwjQg3VaaModRZf8arv2rwudRYX2OV3V8CYc05rGWc78YuDc I05Mrxiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVfOS-00000007jm6-3KcG; Sun, 21 Jul 2024 22:51:04 +0000 Received: from mx.treblig.org ([2a00:1098:5b::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVfO6-00000007jhA-2P17 for linux-arm-kernel@lists.infradead.org; Sun, 21 Jul 2024 22:50:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=Content-Type:MIME-Version:Message-ID:Subject:From:Date:From :Subject; bh=Z6+tcN90xgP1nrdUqmcA2EVQqwgriS18uB284QzrNV8=; b=sZYt+xRXyyak1MyM 64csFKH7xecno+beGEc3djBlikJSVwnhgbgvf+1f0Ta76xnsjo8cTH3QbN0n3yNNZ9PH+qsB1vT+p zoXd5duXuwev5q18Dr8EElP6ISUxu18cV0jc1PdQIxgte5dLFA0TBi//kDkHyJFRXgUjwBm7hoISb HJBYpDqeFY8jtPSRGKIKEJMGyE14QFvdJObCfoRIoSGCsbsoxD90HrnmYoey3QdaQ6a0b0ENuYB7+ M3logoeTMaXttN+dxlZdVUSY7lfQJMv15FoUL2ol8DXA3f78rEmE4HUaKwwI9Tu1u0tMYTY1Sclcq sm0HmC6wFAR1okcupQ==; Received: from dg by mx.treblig.org with local (Exim 4.96) (envelope-from ) id 1sVfNt-00CdQr-04; Sun, 21 Jul 2024 22:50:29 +0000 Date: Sun, 21 Jul 2024 22:50:28 +0000 From: "Dr. David Alan Gilbert" To: Sean Anderson Cc: camelia.groza@nxp.com, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp' Message-ID: References: <20240528231123.136664-1-linux@treblig.org> <336239e6-4369-44ea-a60c-d300cf6e6f81@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <336239e6-4369-44ea-a60c-d300cf6e6f81@linux.dev> X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/6.1.0-21-amd64 (x86_64) X-Uptime: 22:49:30 up 74 days, 10:03, 1 user, load average: 0.00, 0.00, 0.00 User-Agent: Mutt/2.2.12 (2023-09-09) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240721_155042_638120_10F57074 X-CRM114-Status: GOOD ( 15.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Sean Anderson (sean.anderson@linux.dev) wrote: > On 5/28/24 19:11, linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > 'cgr_comp' has been unused since > > commit 96f413f47677 ("soc/fsl/qbman: fix issue in > > qman_delete_cgr_safe()"). > > > > Remove it. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > drivers/soc/fsl/qbman/qman.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c > > index 7e9074519ad2..4dc8aba33d9b 100644 > > --- a/drivers/soc/fsl/qbman/qman.c > > +++ b/drivers/soc/fsl/qbman/qman.c > > @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr) > > } > > EXPORT_SYMBOL(qman_delete_cgr); > > > > -struct cgr_comp { > > - struct qman_cgr *cgr; > > - struct completion completion; > > -}; > > - > > static void qman_delete_cgr_smp_call(void *p) > > { > > qman_delete_cgr((struct qman_cgr *)p); > > Reviewed-by: Sean Anderson Hi Sean, Do you know who will pick this one up? I got a notification a while ago from a patchwork at linuxppc-dev marked 'Handled elsewhere' - but I'm not sure where. Thanks, Dave -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/