From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30AA2C3DA5D for ; Mon, 22 Jul 2024 14:03:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mtHNdbyEsPDzz18RGuCJiRbWlFGvSqg44axaeswU7vE=; b=u+4lOKnRS2qX3ohRrVvBGEBZ1w jQzO7v+9+gBuLxi0pwMVfeMk68THp+Ib9PwRcLXjHIFxJwaxDGBOBITrB5joTR4f0bsfKB4GubSr1 aCVQBjT4WAo6PinCBi3/+ve+1o+VahtBhuc8Ffa5ZWtqF1xfZ+awTxJqie7zctdSZvYW4Njz/PTeI +GC1gxPcStNduGqVGbtzFMqGHfSUZag4o3rnKFRkuIgFzhRMdl8kBkYQ4SfU66nU+4gzagWhD3Sza ts8CQ7OvVaxJykIOltLOdjmkRegHGi1NRlJoVyJNH+cedscVUUgg7HcQvYNPe56McORU0lURuV5bT KBQSWr6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVtdR-00000009iZI-13So; Mon, 22 Jul 2024 14:03:29 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVtd4-00000009iV5-1VVD for linux-arm-kernel@lists.infradead.org; Mon, 22 Jul 2024 14:03:07 +0000 Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-2cb510cd097so2532160a91.1 for ; Mon, 22 Jul 2024 07:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721656985; x=1722261785; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mtHNdbyEsPDzz18RGuCJiRbWlFGvSqg44axaeswU7vE=; b=iCAiXxhQaAffg+kMxn7QTKEtT9ScCdpUpuZlLOQ6IJaJ+ij3WS9z3F3CdnhKpFfM/Y xzdUvl1VQqumESz3FukzttoH6BhDduS2DwoGVr7OEm7lMbQq2BMNS0P82LT/DF8A/fe1 ApBjH1DdS0giddd1I8wV4h0uJKHjh+qlDDVnU05yEt2ux2N/18z9piERGA1e650YZF1m 4x5HKwSnIB6gynnMHaZFlfjEXRVG22H9KnESdN0bHJbWABXGg+AL1mHl4nDnUn6y9Asx q1D3ol2C02DsLVDq3UBPDcwa61XfGepBvnFTO4jVnejR+xKddnWH708DtYAt1pl9NDIt a+hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721656985; x=1722261785; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mtHNdbyEsPDzz18RGuCJiRbWlFGvSqg44axaeswU7vE=; b=iFLLf/T4Czb5irK6LaR1WC8cPBBj7hL84zQi7RpHlDDsyaQlti0IZAHC/j+yy/gnSn mitQHl6M8OtZlyC92fKinlHxwOZVKyEET+BGnjpLqaP3uWHsI1uZolzF8bxuvzyuc74w Bt3cGP31ftATsJnpV+aYx9XYH3A+64qIxIPS51c0DJ4m9NOQPG/zAGOtbXQ5fpBGfmmY yRnC5OpxxTDIBF5Vu7v9jSEN7dRCJso2i39qUfiDGathmxob5sRUMxPhsWsIeWhX0Pqj 7h9G8aHFsgAwD6OJOvYC+D+34D47gSvJykd+xXwFWJ/ijDRKd/quoAq0oeMHoZuiiijY g6mg== X-Forwarded-Encrypted: i=1; AJvYcCWBJjeH3aSTsCXpR17wCTVXAvIzju6EYCA5M7ZjdwFZzOLpSyOlEdpvoaQTLGD1qWiFk1WWwxl3ggPvn2nozscsQHKLoq6MFI3PtkPIgnHWK3OEMTk= X-Gm-Message-State: AOJu0YzvF6Ugg7EdeKoEs4cb0aysVIvLMzcwkJpVGvHk1NL3gvDahDH9 bAk3xae2AmXtkUkpQABXSdq+N8mqlkdAGaljbuJAmWYKqsrP32yx X-Google-Smtp-Source: AGHT+IGFt3jkG6S7Vi8FeT6dkF7VryXqlry4aVmBf5zMYAhOQLHSE0E5fAr5qap1gGLWd1gskjd4EQ== X-Received: by 2002:a17:90b:789:b0:2c9:69d2:67a8 with SMTP id 98e67ed59e1d1-2cd16037674mr6660232a91.9.1721656985062; Mon, 22 Jul 2024 07:03:05 -0700 (PDT) Received: from five231003 ([2405:201:c006:312d:8653:831a:b06f:a502]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cb772c23a8sm8322709a91.1.2024.07.22.07.02.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 07:03:04 -0700 (PDT) Date: Mon, 22 Jul 2024 19:32:57 +0530 From: Kousik Sanagavarapu To: Krzysztof Kozlowski Cc: Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck , Nishanth Menon , Santosh Shilimkar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/3] dt-bindings: watchdog: ti,davinci-wdt: convert to dtschema Message-ID: References: <20240721170840.15569-1-five231003@gmail.com> <20240721170840.15569-3-five231003@gmail.com> <629a925c-24ef-4a44-832f-a06a60c266a7@kernel.org> <2d8ceef8-9d5e-42a9-af2e-f9292728a3bf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2d8ceef8-9d5e-42a9-af2e-f9292728a3bf@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240722_070306_422845_C0B0187F X-CRM114-Status: GOOD ( 23.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 22, 2024 at 03:50:15PM +0200, Krzysztof Kozlowski wrote: > On 22/07/2024 15:12, Kousik Sanagavarapu wrote: > > On Mon, Jul 22, 2024 at 10:15:03AM +0200, Krzysztof Kozlowski wrote: > >> On 21/07/2024 18:28, Kousik Sanagavarapu wrote: > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - ti,davinci-wdt > >>> + - ti,keystone-wdt > >> > >> This does not match the original binding and commit msg did not explain > >> why such change is necessary. > > > > I don't understand. Do you mean both the compatibles are always > > compulsory? Meaning > > > > compatible: > > items: > > - const: ti,davinci-wdt > > - const: ti,keystone-wdt > > Yes, this is what old binding said. That was what I thought initially too, but the example in the old binding says otherwise and also the DTS from ti/davinci/da850.dtsi says wdt: watchdog@21000 { compatible = "ti,davinci-wdt"; reg = <0x21000 0x1000>; clocks = <&pll0_auxclk>; status = "disabled"; }; Or am I seeing it the wrong way? > > > > It is enum because I intended it to align with the subsequent patch > > which changes DTS. > > > >> This also does not match DTS. > > > > Yes. I've asked about changing the DTS in the subsequent patch. > > > > Changing the DTS cannot be the reason to affect users and DTS... It's > tautology. You change DTS because you intent to change DTS? Not exactly. I thought that the DTS was wrong when it said compatible = "ti,keystone-wdt", "ti,davinci-wdt"; while it should have been compatible = "ti,keystone-wdt"; I was not sure about this though and hence marked both the patches as RFC, in case I was interpretting them the wrong way. Thanks