From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50EFBC3DA5D for ; Mon, 22 Jul 2024 16:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ac4TBOhO4Lvkf/O2AokVMuwcwMPMmOE7Ro7pJm1rvQk=; b=U2qFBowpHUM/OZ6IynT6bj/xhO 9a6JhuyLyFZBgIaFCTXAu9r1A9aUhVSJSEdfXjUCjUEYkUOcLABYDawP3/mrMt+qR9Y6q3QQH+zY6 x0WlSaTqlUZKLDohSulu7LAImvEmVN37ovW82u7qdgFJvneqHd34BEL8j7zZpcWw/dxRLiiEZZFi0 xCnsiwBnQ7xTxs2ljJtwNWSgeswiBA8a6mIlkaLaKm3imx5o1N3DJ01dw7Y6778ZS3M5ATjQes8Gu 9Afq2OPlGfvlcwwGDI4ikZ0tF44fjjNM6CPU0p6ys+va1x8x6bN68wVDgdT4k1z14emSU5trs9guJ QNlNOrEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVvjb-0000000A3fM-30kC; Mon, 22 Jul 2024 16:17:59 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVvjE-0000000A3Xw-1vJO for linux-arm-kernel@lists.infradead.org; Mon, 22 Jul 2024 16:17:38 +0000 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1fd69e44596so19282855ad.1 for ; Mon, 22 Jul 2024 09:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1721665055; x=1722269855; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=ac4TBOhO4Lvkf/O2AokVMuwcwMPMmOE7Ro7pJm1rvQk=; b=rh6Vclza4LMKzzamya67wQux9FsAtk9CbTUQabpSc9m924ii8ZWt2uYLMh0RN+2sEM Udp3JOJiincJrjZhaaaa1B2xZuWuoIVIcjpWt6criqFnyIM5ZbOXFc5C10DQ/thOY92J FUECVEofWJ7Ye0KlJb4q8JblE7N/d/E3uYwnE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721665055; x=1722269855; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ac4TBOhO4Lvkf/O2AokVMuwcwMPMmOE7Ro7pJm1rvQk=; b=uAanLpHvHV+4TrMOd+TXtwOzrmi/I0waXh1lwrrWOCxUOwiPnmZUbA9rjyUuhQv5qY heKDpPMqxsDkwDEMy+yhKkn8o3lKeb02/D2VrQ3jcwNO9bSXAcShEHGi86PX5WUZofjT 7LTZoOewYzwQwnqn/4rVdfP6/3pjcG9X0aVIg4w/ZNPCd2bhg+Hbep5eW3j98jIIiSUT 4si1Jqyk1K9ysYgjMgBSojggZfKv+l2Uvukf/No+5mdDWMcSn1P+3ZbdALTkrhQcgHS4 UhsQJwZ3guy0W585oB4qYZV6Ltnh0NTtjSr1ib00MCDifGnKy35ifhefcnlI6IGTDNs3 rhEg== X-Forwarded-Encrypted: i=1; AJvYcCWRkv0oIvTreJtBo1Aqfik0T1BNyB7a4kJesOEZnj/OrYV3kMjVzg/15+QQU9F+LJBq4thizt3pI4oU3fye7Io+QjtZchHmEMMQdYShdFVjFNFtaEA= X-Gm-Message-State: AOJu0YxkMbfxb8H68/8nyamfwryJZ5IpSfFtJvBSkj08gEgeQId4MzwA v4Rpbr4l3vv1ppPIU+dFDkYDti1hQ5XZosLMYtWAbLBXbuulwAlaLpPgJCP0YXs= X-Google-Smtp-Source: AGHT+IFB2y7zOFl4+Y01VeT43wEsBkhPo0FQ49eT3GIcwc/I7mB7L8n/Y/dKG9HTsZ7eJjeY9OWniQ== X-Received: by 2002:a17:902:cec4:b0:1fd:b5fe:ee91 with SMTP id d9443c01a7336-1fdb5fef138mr3886125ad.25.1721665054849; Mon, 22 Jul 2024 09:17:34 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70d1dbfe395sm2640504b3a.218.2024.07.22.09.17.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 09:17:34 -0700 (PDT) Date: Mon, 22 Jul 2024 09:17:31 -0700 From: Joe Damato To: Elad Yifee Cc: daniel@makrotopia.org, Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bpf@vger.kernel.org Subject: Re: [PATCH net-next RFC] net: ethernet: mtk_eth_soc: use prefetch methods Message-ID: Mail-Followup-To: Joe Damato , Elad Yifee , daniel@makrotopia.org, Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bpf@vger.kernel.org References: <20240720164621.1983-1-eladwf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240720164621.1983-1-eladwf@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240722_091736_507088_BC8686D8 X-CRM114-Status: GOOD ( 21.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 20, 2024 at 07:46:18PM +0300, Elad Yifee wrote: > Utilize kernel prefetch methods for faster cache line access. > This change boosts driver performance, > allowing the CPU to handle about 5% more packets/sec. Nit: It'd be great to see before/after numbers and/or an explanation of how you measured this in the commit message. > Signed-off-by: Elad Yifee > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index 0cc2dd85652f..1a0704166103 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -1963,6 +1963,7 @@ static u32 mtk_xdp_run(struct mtk_eth *eth, struct mtk_rx_ring *ring, > if (!prog) > goto out; > > + prefetchw(xdp->data_hard_start); Is there any reason to mix net_prefetch (as you have below) with prefetch and prefetchw ? IMHO: you should consider using net_prefetch and net_prefetchw everywhere instead of using both in your code. > act = bpf_prog_run_xdp(prog, xdp); > switch (act) { > case XDP_PASS: > @@ -2039,7 +2040,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget, > idx = NEXT_DESP_IDX(ring->calc_idx, ring->dma_size); > rxd = ring->dma + idx * eth->soc->rx.desc_size; > data = ring->data[idx]; > - > + prefetch(rxd); Maybe net_prefetch instead, as mentioned above? > if (!mtk_rx_get_desc(eth, &trxd, rxd)) > break; > > @@ -2105,6 +2106,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget, > if (ret != XDP_PASS) > goto skip_rx; > > + net_prefetch(xdp.data_meta); > skb = build_skb(data, PAGE_SIZE); > if (unlikely(!skb)) { > page_pool_put_full_page(ring->page_pool, > @@ -2113,6 +2115,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget, > goto skip_rx; > } > > + prefetchw(skb->data); Maybe net_prefetchw instead, as mentioned above? > skb_reserve(skb, xdp.data - xdp.data_hard_start); > skb_put(skb, xdp.data_end - xdp.data); > skb_mark_for_recycle(skb); > @@ -2143,6 +2146,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget, > dma_unmap_single(eth->dma_dev, ((u64)trxd.rxd1 | addr64), > ring->buf_size, DMA_FROM_DEVICE); > > + net_prefetch(data); > skb = build_skb(data, ring->frag_size); > if (unlikely(!skb)) { > netdev->stats.rx_dropped++; > @@ -2150,6 +2154,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget, > goto skip_rx; > } > > + prefetchw(skb->data); Maybe net_prefetchw instead, as mentioned above?