From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C623C3DA5D for ; Mon, 15 Jul 2024 09:35:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TAhNtcwgtbOV1gQo5Egd/9zBCDDt4ll6D2u0nWP7pyk=; b=tUhbgsAvRew5bfHaeZccn+Bq+j ViUTCMKg3QAeyKTlZ++ZL0bgMLyFTDCAAZ+pRTbMPV3cAMNPv3Zx67xJoMxFG53MhtGNmq35qfkjK 7ULubCJqyEWxRscM0QSejWS93ev0ZtBdjcSF0YRxC/evk2No/vUv3qH3ISto05ju53ntYaRvH1agJ mX0PDJW+sUTrF+uuIBYXtvxujiG9jRcnlTZ5jef8QUMANSSY2jx7LiJ4VP7GJ8c69m7G6Gym39hcG aME23fMJkZOdxODLZ/kjBfcfJ/D75xY96h72cpeJ3h51w4utLUpsCHjsmPjamn7dETTlDTHruhnot oh8wYJ6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTI7Q-00000006Y43-0VyJ; Mon, 15 Jul 2024 09:35:40 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTI76-00000006XyG-2HKD for linux-arm-kernel@lists.infradead.org; Mon, 15 Jul 2024 09:35:22 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0747CDA7; Mon, 15 Jul 2024 02:35:42 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C08CB3F73F; Mon, 15 Jul 2024 02:35:14 -0700 (PDT) Date: Mon, 15 Jul 2024 10:35:09 +0100 From: Mark Rutland To: Marc Zyngier Cc: Sebastian Ott , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Zenghui Yu Subject: Re: [PATCH 1/3] KVM: arm64: fix override-init warnings in W=1 builds Message-ID: References: <20240712110332.10970-1-sebott@redhat.com> <20240712110332.10970-2-sebott@redhat.com> <8734oep96j.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8734oep96j.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_023520_645506_303F3C6F X-CRM114-Status: GOOD ( 22.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 12, 2024 at 10:55:16PM +0100, Marc Zyngier wrote: > On Fri, 12 Jul 2024 12:03:30 +0100, > Sebastian Ott wrote: > > > > Remove double initializations in cases where that's easily possible > > - like extra NULL initialization in static global structures. In the > > other cases just silence -Woverride-init. > > > > To fix warnings like the following: > > arch/arm64/kvm/hyp/vhe/switch.c:271:43: warning: initialized field overwritten [-Woverride-init] > > 271 | [ESR_ELx_EC_CP15_32] = kvm_hyp_handle_cp15_32, > > | ^~~~~~~~~~~~~~~~~~~~~~ > > > > Signed-off-by: Sebastian Ott > > --- > > arch/arm64/kvm/handle_exit.c | 5 +++++ > > arch/arm64/kvm/hyp/nvhe/switch.c | 6 ++---- > > arch/arm64/kvm/hyp/vhe/switch.c | 3 +-- > > arch/arm64/kvm/sys_regs.c | 5 +++++ > > 4 files changed, 13 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c > > index d7c2990e7c9e..2c049746657c 100644 > > --- a/arch/arm64/kvm/handle_exit.c > > +++ b/arch/arm64/kvm/handle_exit.c > > @@ -291,6 +291,9 @@ static int handle_svc(struct kvm_vcpu *vcpu) > > return 1; > > } > > > > +__diag_push(); > > +__diag_ignore_all("-Woverride-init", "Allow field overrides in exit_handlers"); > > The wording you are looking for is "Silence stupid warning". I really > mean it. There is really nothing wrong with this code, and if the > compiler doesn't understand the purpose of a default initialiser, then > *maybe* it should be fixed rather than polluting the kernel with this > stuff. IMO this would be a lot more palatable if this were an attribute on the struct or assignment, like we asked for in the past: https://lore.kernel.org/lkml/20190809083251.GA48423@lakrids.cambridge.arm.com/ Having something that we could put specifically on the default assignment would make this a lot more legible and better capture the intent. Mark.