From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0500DC3DA59 for ; Mon, 15 Jul 2024 11:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7ili+AEAUIUPX41JubJn5zZkOS6EtWjhalWEc5BQmdw=; b=GDYmJI/Q3uFSwI+V2OuBw7fYPh mZJ4QGMj8hQXuNWnpUxk4JEixyLdo1v956ZhSkUG0fq2d4hyLZa3gNTX+Pht6yAMyVkB2XlxYHBeY 7dDG/NIduPheu4enjijnxsR4PleCLb5PNqb1VDBxKG5oWucAXXV3aehaiplZ4FSOmv6NtERgtPj9c aW9ShbUzzm8RyGiBQJ7KC4sze6H3MBJjP1EPbduycfCJ6Ki2OpHBvnVimUGCWvV7pr45K/yuEhC5N OGgujzHrpCjbhUI+fWgH9dlDdCHVEqLtcYblEC7Nr8FSusUpgpMWP5pjKifg4MEE4ecyomBkGiXBV aizA3GFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTJY3-00000006p1r-1aSU; Mon, 15 Jul 2024 11:07:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTJXk-00000006owp-1TyR for linux-arm-kernel@lists.infradead.org; Mon, 15 Jul 2024 11:06:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F35AADA7; Mon, 15 Jul 2024 04:07:20 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B41A3F766; Mon, 15 Jul 2024 04:06:54 -0700 (PDT) Date: Mon, 15 Jul 2024 12:06:52 +0100 From: Mark Rutland To: Mark Brown Cc: Daniel Lezcano , Thomas Gleixner , David Abdurachmanov , Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ross Burton Subject: Re: [PATCH v2] clocksource: sp804: Make user selectable Message-ID: References: <20240529-arm64-vexpress-sp804-v2-1-c542a80af33a@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240529-arm64-vexpress-sp804-v2-1-c542a80af33a@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_040656_455648_87E4F7EF X-CRM114-Status: GOOD ( 23.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 29, 2024 at 08:48:14PM +0100, Mark Brown wrote: > The sp804 is currently only user selectable if COMPILE_TEST, this was > done by commit dfc82faad725 ("clocksource/drivers/sp804: Add > COMPILE_TEST to CONFIG_ARM_TIMER_SP804") in order to avoid it being > spuriously offered on platforms that won't have the hardware since it's > generally only seen on Arm based platforms. This config is overly > restrictive, while platforms that rely on the SP804 do select it in > their Kconfig there are others such as the Arm fast models which have a > SP804 available but currently unused by Linux. Relax the dependency to > allow it to be user selectable on arm and arm64 to avoid surprises and > in case someone comes up with a use for extra timer hardware. > > Fixes: dfc82faad725 ("clocksource/drivers/sp804: Add COMPILE_TEST to CONFIG_ARM_TIMER_SP804") > Reported-by: Ross Burton > Reviewed-by: Sudeep Holla > Signed-off-by: Mark Brown Acked-by: Mark Rutland Mark. > --- > Changes in v2: > - Rebase onto v6.10-rc1. > - Link to v1: https://lore.kernel.org/r/20240522-arm64-vexpress-sp804-v1-1-0344cd42eb77@kernel.org > --- > drivers/clocksource/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index 34faa0320ece..ca6045f90000 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -390,7 +390,8 @@ config ARM_GT_INITIAL_PRESCALER_VAL > This affects CPU_FREQ max delta from the initial frequency. > > config ARM_TIMER_SP804 > - bool "Support for Dual Timer SP804 module" if COMPILE_TEST > + bool "Support for Dual Timer SP804 module" > + depends on ARM || ARM64 || COMPILE_TEST > depends on GENERIC_SCHED_CLOCK && HAVE_CLK > select CLKSRC_MMIO > select TIMER_OF if OF > > --- > base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0 > change-id: 20240522-arm64-vexpress-sp804-365d6938b07c > > Best regards, > -- > Mark Brown > >