From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE3A5C3DA4B for ; Mon, 15 Jul 2024 13:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xKgw3TtzJ7iCnG35wIjWov2HntYWtwcljkR4+p0N064=; b=ilH37IWCutDyP/0IHOxO6UjT+Q BfR08hQKM04j3+mZHv+6kXK6lS6mxXna2h1dbj8UDnVJeO+vqQk7ySTlZJkHPfVHoIhfgTmwC85y2 y786/wIkxYnf8+GtdD2tzP9u/QyJRWSx141lKQvprmkJ/N5o5KtdXCruBJMQU8KrdmdhMf4pNDioo Nw2GbrbyGtWxrpb4K3W+FgBqx9jibDH9WsTUEvjHMq5zwhh4PZOgBa3mYn/YmFlyc/Lky51P3LOBe VZ0pTtqxoh3whZsNt3H6MP8Ovyh2a6rIQwSBE2LSOMw7ZUHOnxfp3kTY4+mBjAf6h/f8AzueHLfSf Ur+LPh/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTLoO-00000007DMn-3dVm; Mon, 15 Jul 2024 13:32:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTLm9-00000007D7e-328H for linux-arm-kernel@lists.infradead.org; Mon, 15 Jul 2024 13:31:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EB8D9DA7; Mon, 15 Jul 2024 06:30:21 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6EAF03F73F; Mon, 15 Jul 2024 06:29:55 -0700 (PDT) Date: Mon, 15 Jul 2024 14:29:49 +0100 From: Mark Rutland To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: remove redundant 'if HAVE_ARCH_KASAN' in Kconfig Message-ID: References: <20240714105848.1844400-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240714105848.1844400-1-masahiroy@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_062957_831224_EBFFE902 X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jul 14, 2024 at 07:58:46PM +0900, Masahiro Yamada wrote: > The condition 'select HAVE_ARCH_KASAN' is always true because > there is 'select HAVE_ARCH_KASAN' statement above. > > Signed-off-by: Masahiro Yamada Looks like we forgot to simplify this in commit: 0383808e4d99ac31 ("arm64: kasan: Reduce minimum shadow alignment and enable 5 level paging") ... where we began selecting HAVE_ARCH_KASAN unconditionally. FWIW: Acked-by: Mark Rutland Mark. > --- > > arch/arm64/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index c87d16b12e9b..d37cbfc3031e 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -167,9 +167,9 @@ config ARM64 > select HAVE_ARCH_JUMP_LABEL > select HAVE_ARCH_JUMP_LABEL_RELATIVE > select HAVE_ARCH_KASAN > - select HAVE_ARCH_KASAN_VMALLOC if HAVE_ARCH_KASAN > - select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN > - select HAVE_ARCH_KASAN_HW_TAGS if (HAVE_ARCH_KASAN && ARM64_MTE) > + select HAVE_ARCH_KASAN_VMALLOC > + select HAVE_ARCH_KASAN_SW_TAGS > + select HAVE_ARCH_KASAN_HW_TAGS if ARM64_MTE > # Some instrumentation may be unsound, hence EXPERT > select HAVE_ARCH_KCSAN if EXPERT > select HAVE_ARCH_KFENCE > -- > 2.43.0 > >