From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F854C3DA4B for ; Mon, 15 Jul 2024 13:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o84MsP+fMPBmSc5jbUvl3mgSmUa3T/pl+IhhNEMUP54=; b=N9uCnybb5xFyOKS32BI7lQM7KE UG3P/jvouI9Hg5Z/6W9MLrdJYNQnWGod2A6KJKqg04IVzdjRB1xlRc8D8ulEWjzXlAT6MDXc6z7e5 /XCayCFxlqXlf5HLiGQFHxgZ0ZBMvT9bdQ1PN+5TsRmnPadXUBwCHriVYGSPqRJZrGv6J0Rms6b5a Fr4inrZ+jkFZIZib59R6uaPzn6FGlfvaE85Fw/puaG3KDs7lBMYR9fD1XtI5+oGbCS44hOYgURgvU dT/K1MFTmplRWdtaeH5bPnt+63XJrhME5lg3v39YRifaoeh8jbV9VJnPwGus+U/4/nXMBsfMlXKdd 7YmOXGnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTM05-00000007Ftk-0dUg; Mon, 15 Jul 2024 13:44:21 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTLzl-00000007Foq-3U6t for linux-arm-kernel@lists.infradead.org; Mon, 15 Jul 2024 13:44:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E77E6DA7; Mon, 15 Jul 2024 06:44:25 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 77A0A3F73F; Mon, 15 Jul 2024 06:43:59 -0700 (PDT) Date: Mon, 15 Jul 2024 14:43:57 +0100 From: Mark Rutland To: Anshuman Khandual Cc: Masahiro Yamada , linux-kbuild@vger.kernel.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: remove redundant 'if HAVE_ARCH_KASAN' in Kconfig Message-ID: References: <20240714105848.1844400-1-masahiroy@kernel.org> <87d70313-9c8c-4cdf-a040-7ea31804cad7@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d70313-9c8c-4cdf-a040-7ea31804cad7@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_064401_940618_94B2D200 X-CRM114-Status: GOOD ( 20.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 15, 2024 at 08:11:08AM +0530, Anshuman Khandual wrote: > On 7/14/24 16:28, Masahiro Yamada wrote: > > The condition 'select HAVE_ARCH_KASAN' is always true because > > there is 'select HAVE_ARCH_KASAN' statement above. > > > > Signed-off-by: Masahiro Yamada > > --- > > > > arch/arm64/Kconfig | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index c87d16b12e9b..d37cbfc3031e 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -167,9 +167,9 @@ config ARM64 > > select HAVE_ARCH_JUMP_LABEL > > select HAVE_ARCH_JUMP_LABEL_RELATIVE > > select HAVE_ARCH_KASAN > > - select HAVE_ARCH_KASAN_VMALLOC if HAVE_ARCH_KASAN > > - select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN > > - select HAVE_ARCH_KASAN_HW_TAGS if (HAVE_ARCH_KASAN && ARM64_MTE) > > + select HAVE_ARCH_KASAN_VMALLOC > > + select HAVE_ARCH_KASAN_SW_TAGS > > + select HAVE_ARCH_KASAN_HW_TAGS if ARM64_MTE > > # Some instrumentation may be unsound, hence EXPERT > > select HAVE_ARCH_KCSAN if EXPERT > > select HAVE_ARCH_KFENCE > > There is another similar instance with HAVE_FUNCTION_GRAPH_TRACER as well. > Just wondering if the following change should be folded in here ? > > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -210,8 +210,8 @@ config ARM64 > select HAVE_FTRACE_MCOUNT_RECORD > select HAVE_FUNCTION_TRACER > select HAVE_FUNCTION_ERROR_INJECTION > - select HAVE_FUNCTION_GRAPH_RETVAL if HAVE_FUNCTION_GRAPH_TRACER > select HAVE_FUNCTION_GRAPH_TRACER > + select HAVE_FUNCTION_GRAPH_RETVAL > select HAVE_GCC_PLUGINS > select HAVE_HARDLOCKUP_DETECTOR_PERF if PERF_EVENTS && \ > HW_PERF_EVENTS && HAVE_PERF_EVENTS_NMI That looks like a sensible cleanup, but I think it'd be better as a separate patch. It looks like that has always been redundant since it was introduced in commit 3646970322464c21 ("arm64: ftrace: Enable HAVE_FUNCTION_GRAPH_RETVAL") ... would you mind spinning a patch? Mark.