From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 187AFC3DA49 for ; Tue, 16 Jul 2024 10:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UB06lOjeb/uE3iisxwCP6Tm1CK/MivC/LclbamO9xAM=; b=VkPcAmvp8R9uslRTaP8qHA13o5 uSLpftWSv7q/Y7wPXtxb4rT0PpsCZcLTp+fPRcXLIH6DRnpZoppXyny5c33tAGJHJ8F0LiwTUP12R 3vtugCQlNOuSBFwj3jmkSmBNxnawQg3RCW7A79AXubcenx2yBmOqtdM5EiNTRm2b0ZlJEJ/a4LTkS KC8tHZNw2sa8KDfJhi9WGAYvqDcr04aT/gb9ScjiKZ0egfAPm7sOdHIWdB+/ROHP1VqmErPrOpBv4 gpd6uz2jxS58/PYTw5Qvc/JQL9NT5Fmf3m4PGcujLXRevppv5g5wt7dT1jwIAEl3oXCBw9O9GcwCA iGM92XQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTeyi-00000009yDn-0oxZ; Tue, 16 Jul 2024 10:00:12 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTeyO-00000009yAB-01LH for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2024 09:59:53 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3679f806223so3697966f8f.0 for ; Tue, 16 Jul 2024 02:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721123986; x=1721728786; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UB06lOjeb/uE3iisxwCP6Tm1CK/MivC/LclbamO9xAM=; b=k/VTJ/rY6Vti6K4Efhhuz805zvA8QHbSC75RpsctbxjiFElWCBxnLJNGDPYlUENyLz L1JkWmap1z9KZT2/0x/sNuerlY3qAYHIihgdqjaf6udzDkf3AxJhqAfjWI+2b/l0wTnh c28sqJnS1b49aJZ5sb90nA8VZXcF+fVHc7docmVEc5LqR+KF4UpcWJhRQrqDiW/tpOE/ NxOWONK4/pKLfKfxEaFgiallZsUYdKwkolYynpW0l2Rf2RCiOQugErMskOQPRdH3saMr K0zqWQx9DBVg2RdE5DqL4ugmcXDtilqKN1VEUjVasu/C5+vClLzxbxHGhSEwjUqMK2nY TMBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721123986; x=1721728786; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UB06lOjeb/uE3iisxwCP6Tm1CK/MivC/LclbamO9xAM=; b=hcNdUniEfpcXrkZ372yWXQa09vmzvZlJuQFY7iChwtuHJaZUx0qFJY7AgSfAh8aaZ6 gxXC7nEXr8K9Oyfs0iYqGVmo96/7m9zDCFxOW55TWMxnTscbcVlPHSrgqz9UbcKwrOsm HbMvTpKp2z0Plp1251RL3lgoD0CiNXEjPuqLyvz/XPodj/+d+cE2A0im7GtqJDpCIX3a rPGhjQa0/y0g6icC3e2eroUXDdfBfjowLcF5AgNDT8qEe58Pssk8DeOUlAbN/2eYirM+ x00KrsngE7klT2BirTb1r0GCRS6eHvYQpv+1yVZs/I+hkI75VD1+2WmnLHpW6LDvxPl2 ixxg== X-Forwarded-Encrypted: i=1; AJvYcCUmXa94FOc5UQzsvEIcQT97lJ/AoU1R0CZzboIuhvQwy5CIUTpJ3wYlKwDgvdb+WFEzmsd6RT59BCjZLK4aBa0OnaoU+0u3XrGtiPNYmIpMGHBsAFY= X-Gm-Message-State: AOJu0YzqEIplOwp+E+MB57jXz8yOdA8okzHoAz7lcdS4l7XpOZxCDwbX wifM/rTQN/5BNcdZ4DrxKTPJIoN3MHuqbLFTDa+PSUPcHLXzlqsOmwmDJCJJzA== X-Google-Smtp-Source: AGHT+IF69v24Yzf9m7VOZnyEAWiFMAW/hbg7ZrSdOQ+vI1WyHZxOGGlPFzoPDdIVKnZQD4NsWWgIYA== X-Received: by 2002:a05:6000:1e4e:b0:362:69b3:8e4d with SMTP id ffacd0b85a97d-36827498d65mr1116597f8f.25.1721123985921; Tue, 16 Jul 2024 02:59:45 -0700 (PDT) Received: from google.com (203.75.199.104.bc.googleusercontent.com. [104.199.75.203]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680dafbe9esm8515847f8f.78.2024.07.16.02.59.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 02:59:45 -0700 (PDT) Date: Tue, 16 Jul 2024 10:59:41 +0100 From: Vincent Donnefort To: Sebastian Ene Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, mark.rutland@arm.com, maz@kernel.org, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v7 5/6] KVM: arm64: Initialize the ptdump parser with stage-2 attributes Message-ID: References: <20240621123230.1085265-1-sebastianene@google.com> <20240621123230.1085265-6-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_025952_102340_2E67FF07 X-CRM114-Status: GOOD ( 20.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 01, 2024 at 02:18:39PM +0000, Sebastian Ene wrote: > On Mon, Jul 01, 2024 at 09:42:43AM +0100, Vincent Donnefort wrote: > > O Fri, Jun 21, 2024 at 12:32:29PM +0000, 'Sebastian Ene' via kernel-team wrote: > > > Define a set of attributes used by the ptdump parser to display the > > > properties of a guest memory region covered by a pagetable descriptor. > > > Build a description of the pagetable levels and initialize the parser > > > with this configuration. > > > > > > Signed-off-by: Sebastian Ene > > > --- > > > arch/arm64/kvm/ptdump.c | 143 ++++++++++++++++++++++++++++++++++++++-- > > > 1 file changed, 137 insertions(+), 6 deletions(-) > > > > > > diff --git a/arch/arm64/kvm/ptdump.c b/arch/arm64/kvm/ptdump.c > > > index 36dc7662729f..cc1d4fdddc6e 100644 > > > --- a/arch/arm64/kvm/ptdump.c > > > +++ b/arch/arm64/kvm/ptdump.c > > > @@ -14,6 +14,61 @@ > > > #include > > > > > > > > > +#define MARKERS_LEN (2) > > > +#define KVM_PGTABLE_MAX_LEVELS (KVM_PGTABLE_LAST_LEVEL + 1) > > > + > > > +struct kvm_ptdump_guest_state { > > > + struct kvm *kvm; > > > + struct pg_state parser_state; > > > + struct addr_marker ipa_marker[MARKERS_LEN]; > > > + struct pg_level level[KVM_PGTABLE_MAX_LEVELS]; > > > + struct ptdump_range range[MARKERS_LEN]; > > > +}; > > > + > > > +static const struct prot_bits stage2_pte_bits[] = { > > > + { > > > + .mask = PTE_VALID, > > > + .val = PTE_VALID, > > > + .set = " ", > > > + .clear = "F", > > > + }, { > > > + .mask = KVM_PTE_LEAF_ATTR_HI_S2_XN | PTE_VALID, > > > + .val = KVM_PTE_LEAF_ATTR_HI_S2_XN | PTE_VALID, KVM_PTE_LEAF_ATTR_HI_S2_XN is actually a mask covering KVM_PTE_LEAF_ATTR_HI_S2_XN_XN, KVM_PTE_LEAF_ATTR_HI_S2_XN_PXN and KVM_PTE_LEAF_ATTR_HI_S2_XN_UXN. I believe here what we should do is something like? .val = FIELD_PREP_CONST(KVM_PTE_LEAF_ATTR_HI_S2_XN, KVM_PTE_LEAF_ATTR_HI_S2_XN_XN) | PTE_VALID > > > + .set = "XN", > > > + .clear = " ", > > > + }, { > > > + .mask = KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R | PTE_VALID, > > > + .val = KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R | PTE_VALID, > > > + .set = "R", > > > + .clear = " ", > > > + }, { [...]