From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0E9AC3DA49 for ; Tue, 16 Jul 2024 15:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q+oBquCC6Yqm7bL0Kr3aJX57Dgk/RB3bFu+I79pPnBY=; b=oHdDBKE+Z+B51A3fab1PfUVBgx Owg6J/7kuVpeBqjooQ550KMrEaAPLwxbvzGyg2kYMIGp3niVaghmuB5gwxAmEnQMLqKEk6Cr3/jOD sT662SRHkuU9etJdTPFeM6pKdzp0466LZZUjHVp37U2N7C1NVXhOW8lWv0PhoipS/pkODYmuFBumo auKn8ZVUzcT/do4zpqlRBYIulQoSLZJ+wUNZ7LoEfMqvNjhD9ctcap8YjbW/ahjfYK8f6WgKLA6mG I3lKOAIo2EWjUB3SB7uHKtoBBeNxz6qdpUVcJLnk1BwrSMm2zRJy90LgXkWEsiII4A/PP2gWaGBm/ 1RSRlrcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTjvV-0000000Asws-42QS; Tue, 16 Jul 2024 15:17:14 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTjvB-0000000AssI-3WXA for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2024 15:16:55 +0000 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-70b1808dee9so3818192b3a.2 for ; Tue, 16 Jul 2024 08:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721143012; x=1721747812; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=q+oBquCC6Yqm7bL0Kr3aJX57Dgk/RB3bFu+I79pPnBY=; b=u/UIL/G3MHgxK89g8eCQwFnY9sfmWtrhf3SyhLeM2TspFimzjTXXidhHoDlzy8ukoF rYOlGYEYprCTJ/pVO/FnNFmvp6QCll/RndwsAKAlZGn2xUaOU8vRgAIkH6f06N2A1CS/ 9Z5P9BmHpmVgoL3lBxOQ/680nHxnj7+rdWWEDjZhB3lgl7GzOdhQqm44rohOReHXeISB bqJp+f1R4ycdCqrIBPrY1qphFkUpe6X69EIiCrvdi0SDgkLU1teNt2v7zA0D2/QdCzbZ YmxHIYaJ4qhL76xCCM7uORpLQXeRtfj9PhIeUq3NAL0dnPXoKhX/s8w7+qkrrEa1Suq2 QiLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721143012; x=1721747812; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q+oBquCC6Yqm7bL0Kr3aJX57Dgk/RB3bFu+I79pPnBY=; b=vy3wa/C0k+pLOs/wl/klXM6p5rCYfsiEmeV2YdlQfzVxFrSOcJFw2FwOqRInTsl34n Z6gY1aojFWB2CFJN5Us/9Dte+zyc9V1aNKyhNtWpcQSHB+7BWXNWRXFoJLWatqT0KXK/ QkM9d34zc8nKHpm3BEq+Unj5pQfFqsi49rV0aslyh4OC8NBrG/HuSQETR1Qhbsd3XHBA uVhCrTHujQCVQObNRzJo5saG/GfafUJ+z+RllyHjJSc6E/QMbM+8DOq4egrE3W+WftQn AfSBDvB2WA93YyPYyh+gkWbClCYZFJ3wHSLGkezSiXtD/BB/mPOsjaGsUk+YKaLm1ndr u0mA== X-Forwarded-Encrypted: i=1; AJvYcCX+g5w86okIiGp5I7UIWV/bkqPwhkCxz6HVua4mI0EkPRYx0d3NM5v73CSiZ6ka8q1dYdnl/XVAmdkzlJ1tIR0f31eqDamCSRRGBNRPhjeYu4II1tg= X-Gm-Message-State: AOJu0YwuG+ls9kTONFil/2k1R/gNydhK10q96rHVr4FapERv+RY5F+xJ 9owMj/92coMMg92k+WD/Tw5GY0s7ouBJ8PbqkCZhLPK0K6n1JdHdrB9Vyx5NW90= X-Google-Smtp-Source: AGHT+IHK38fZflwQZj+0YBMxhcUoqsY5qUO9G0uXW0RmTRimetE4YldMaHWfupwsPvdp5aX1P8Rc/w== X-Received: by 2002:a05:6a00:238c:b0:6ec:f2e7:21a8 with SMTP id d2e1a72fcca58-70c2e9942e1mr3475412b3a.21.1721143011828; Tue, 16 Jul 2024 08:16:51 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:5d01:167d:9cf4:148e]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b7ec7da19sm6413009b3a.133.2024.07.16.08.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 08:16:51 -0700 (PDT) Date: Tue, 16 Jul 2024 09:16:48 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" , marex@denx.de, iuliana.prodan@nxp.com, daniel.baluta@nxp.com Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Zhu , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Terry Lv Subject: Re: [PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for i.MX8M Message-ID: References: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com> <20240712-imx_rproc-v1-1-7bcf6732d328@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240712-imx_rproc-v1-1-7bcf6732d328@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_081653_907959_6EAD29C6 X-CRM114-Status: GOOD ( 17.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Good morning, On Fri, Jul 12, 2024 at 04:34:54PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The DDR Alias address should be 0x40000000 according to RM, so correct > it. > > Fixes: 4ab8f9607aad ("remoteproc: imx_rproc: support i.MX8MQ/M") This commit was merged more than 3 years ago... I don't see how such a blatant mistake could have survived this long without causing problems or being noticed. On top of things checkpatch gives me a warning. > Reported-by: Terry Lv > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 144c8e9a642e..3c8b64db8823 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -210,7 +210,7 @@ static const struct imx_rproc_att imx_rproc_att_imx8mq[] = { > /* QSPI Code - alias */ > { 0x08000000, 0x08000000, 0x08000000, 0 }, > /* DDR (Code) - alias */ > - { 0x10000000, 0x80000000, 0x0FFE0000, 0 }, > + { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, Without access to HW or the documentation there is no way for me to assess the validity of this patch. Marek, Iuliana and Daniel - please review and test this patch. Thanks, Mathieu > /* TCML */ > { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM}, > /* TCMU */ > > -- > 2.37.1 >