From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3EAEC3DA59 for ; Tue, 16 Jul 2024 15:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IRJWJNrzc2jygwsryIDGVRubrMYo6CPq74PglfU61vc=; b=uTDV2H0HJ+gFosKuHT38XBfabw QXETVFtYIyZUCMuKCsZTjFm2N6cO6aALC7rZWj62Huc0o1zSyfsoqPuIc29dX2dG7gJRptggdpJzK tQXb1AHaVA+SSpDpP1yN4UCZjSXh1NJhFtNr7zK0SueQ0mYVAt37ZDnPDA16/fyMR02Bm7fYE4wAv 3nKpa2W7RRbJO6Fb5BfEn/Q2jIRuv2aGJGv4wedlnowK10GC3hp3PB9PG4m9SDtHjMlunq7JnPkJh ZmUDw4QtYxLr/yutyEw1lAW1E1IPrwmyl3rf/UC82dWaB0Inj0ORM0LyYlsLG0gA0mStZsld5muzS 7m6ZGlZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTkGb-0000000AvPb-1YmZ; Tue, 16 Jul 2024 15:39:01 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTkGH-0000000AvLv-09TU for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2024 15:38:42 +0000 Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-781f5007950so4725774a12.0 for ; Tue, 16 Jul 2024 08:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721144320; x=1721749120; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IRJWJNrzc2jygwsryIDGVRubrMYo6CPq74PglfU61vc=; b=K2nitIxzp3BHkFYCEjsbTWAr/mrIqnzz+xmwwscE0Vu7fylMcy2yYTcF90JUxk+PMc saPXCfURY+rzOmxBQeilv1UHUN5MQrsdJfR/9mIyGP1N3mLt4UfxB4eHLg6bkJZEo/9p pMYfKCfoxgWdlpXm4+JMIB4eQE0IEC13FZFYwUjRB5ErG+lXg7FzqU1sUfzPyZtzBB6h PeBtf6Nqf23UXijk8nBme5593Ug7duSdYZNdgwyN3NYPf6/TfY3NGZzxJBzMr9dPuxGz Zo0Ld/b8MyXBzjN473n5wisOQFY1NaPXW8ow0E2DLWtDfl3KRHcRE4Poi3Tk6p+dDiep 5weQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721144320; x=1721749120; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IRJWJNrzc2jygwsryIDGVRubrMYo6CPq74PglfU61vc=; b=ugZ801pxm+NvDDmVgHVZAb2fDxrNH/M3doHh98IzQNk4PZZkUzMM8VGhFsWa8MJAM6 vCpMTtS/kpodSpZMtHorWOIFP+A/n0R3bdJX87K50MVaydN1Fe0Or2ABeMamG8M5h6hF qyeUY7q9qhfO/RVgCSb/3XoWm7Fk3i2EbzKfbafT4y6NWShQp//Vwbbk7fEi2NQe+OhO hGcTBZa2VC0cay/RrgrSH9N07FOHmJsY8DfdHNv6DBtdfnludPZCY1Oc4lEGufst3h8X LM/01XhAksCHfTO/Y6P7Dh2I6yMg6A5wPlJIqMplhb3lll7lSwvr/B1o2eNP39hmYp81 YGdQ== X-Forwarded-Encrypted: i=1; AJvYcCVM2kviCsm2tmV+2XzFwMZ3tpLQ8diS3xFx2KmsHEc1CA0ahuyFjJkEXI4vrkY4Hxr6e6R/QZX1yiH9F+bv7dKhMHiOSrhXjB7BR43qh+W5kpcYoKM= X-Gm-Message-State: AOJu0YwMA5ARRaTXkf0DQPjq3jaDyex2UrQ+Ig9cSB7efd+ubbZvQgP8 6ZJP/kZdKwBvxeDfnN3P4AylOrgg/V/teZzmAIptXNEMVG/JB4kd/+Kh0Xjk1AE= X-Google-Smtp-Source: AGHT+IEDSWIUtRywATQg3qAhHcdwjWZgT7tZwoG/YQpCa+cTCsrStW9SpatZa0yN+LXWMK82f6rs3Q== X-Received: by 2002:a05:6a20:3d8c:b0:1c0:f097:4eb8 with SMTP id adf61e73a8af0-1c3f1273b1emr3243135637.35.1721144319905; Tue, 16 Jul 2024 08:38:39 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:5d01:167d:9cf4:148e]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cacd3f10dfsm8466569a91.17.2024.07.16.08.38.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 08:38:39 -0700 (PDT) Date: Tue, 16 Jul 2024 09:38:36 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Zhu , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 3/6] remoteproc: imx_rproc: initialize workqueue earlier Message-ID: References: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com> <20240712-imx_rproc-v1-3-7bcf6732d328@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240712-imx_rproc-v1-3-7bcf6732d328@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_083841_098926_82EEB68E X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 12, 2024 at 04:34:56PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Initialize workqueue before requesting mailbox channel, otherwise if > mailbox interrupt comes before workqueue ready, the imx_rproc_rx_callback > will trigger issue. > > Reviewed-by: Richard Zhu All reviews should be done publicly - please remove here and for all the other patches. > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 48c48b53a3aa..9e99bb27c033 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -1087,6 +1087,8 @@ static int imx_rproc_probe(struct platform_device *pdev) > return -ENOMEM; > } > > + INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); > + There should be a "Fixes:" tag on this patch. > ret = imx_rproc_xtr_mbox_init(rproc); > if (ret) > goto err_put_wkq; > @@ -1105,8 +1107,6 @@ static int imx_rproc_probe(struct platform_device *pdev) > if (ret) > goto err_put_scu; > > - INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); > - > if (rproc->state != RPROC_DETACHED) > rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot"); > > > -- > 2.37.1 >