From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F19DCC3DA49 for ; Tue, 16 Jul 2024 15:47:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GOZ0mHcem+Vs3dr0bori38FCvWKVYDMdvIY4Rdc3Vvo=; b=s4Dp7AmdeuPjFTezsMoAr4dXym dIZ53EhnAuwnFfdlaUx/fTPMxxiJKv9+pkZoBfLC4baSVrDkeeaqe5Ew5IRRJS8iZJ+kZodA1ykNu 5HLLmTVtPjsWWvH0e8uBvtXINzvixcK/3jqAKIMKyWwEqSHlLEtoSj3I7AxgLwLxFgYTf4SomakZD vGtm/xL693mT1AT0jqAFP4CfOu4bcFtP4yPHyRckri8jpBK5cjuvTVzjc6JiL0njxWK/UxkYpH1i2 LOxZuKHUUUBzQhRJAef4auMxod7SQa3ntQH1yT4PfgKJE9nTrmVhqCEmfCi6MOEazUtVpYo8ZfiT0 Xnbze1jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTkOW-0000000AwVl-1gFW; Tue, 16 Jul 2024 15:47:12 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTkOB-0000000AwPe-1Mm5 for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2024 15:46:52 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1fb0d88fd25so39872895ad.0 for ; Tue, 16 Jul 2024 08:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721144810; x=1721749610; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GOZ0mHcem+Vs3dr0bori38FCvWKVYDMdvIY4Rdc3Vvo=; b=FDQz1C3bj12cWtxpnTN+lmM8huCWwf0Ox6Vp5zfUbCIJ6qMNWZZG3alPWN4+UK6TUj 4vCCDJcHil7yCTgv/SCxAenZdg7QSGhgbc+bKtl6HFSPhHmV9Ykm7NNoPZzElCKuw7pP r8knzUapudgZFnHM1lmfPIuZixEccV/C12JEedUlHKRcCM1BPOf9d9a4/x/kW1EgZABW dj7r9V5YRrwxheOJhEr4WWqbXAWDSiFWcmHj/1Za/MhZxrR3xLktUvAESV4b3XjhLGNq 5onoJyKShJRgnMGp78cL6UG48t+UNaopvsHfVBcIm0MgtMaXejEaw4m1zt9A4ayiqlO9 R78g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721144810; x=1721749610; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GOZ0mHcem+Vs3dr0bori38FCvWKVYDMdvIY4Rdc3Vvo=; b=vY2f9wG66jVkBlvoQPUv2Yk0TjzFi6zgrTuaoqZReeaK7q3fECcnWpUFan4EXUEipW pIJxzlLviSkuSmft3Jj9jN+MrKF4gcEFD3vuLkhzVd+IZseklZNvMCv8UcuoOESVsczM bNxwwrN53SPIsX8EE8vHeHl6pmBLenY42jKsHK6lL2bFUbtE0AFfNT707o0iiwHESuO3 tTuCIevrTj3LkefqdGf78wTDDaabGTPVZ0aDjeNi4Jwd8nfDv6S4VwdpGdVNU2zsHOz1 hl8pxLVbO5xncXhgU8eSDddpPgu2MT6LPNUTKDfgbACC7aC0oy1jJOcjR7MbztQk+bQk osuA== X-Forwarded-Encrypted: i=1; AJvYcCUDmt88Y7zhcaP9I8d6W8sEU+5v26jCMuwjbBi/iB0lIdVekPNiEkQVhYmwaBbTE/QFunZrMuI4oWLBgbQw+x3oroQICubJnx2EeC+v6E22eqFq4u4= X-Gm-Message-State: AOJu0YxGM/o2tGSGKDAc6rky/nUJ1qqF+bSB2bWm36YPn/3gDNZAwdPg 7sTaPJpjzmNnoojn5px0YfpJq8EZQCpWmbtiOC8vMxWmaiViS8vyxJlyfg7TMm0= X-Google-Smtp-Source: AGHT+IGuZHVU0ziAtoeqsGV04P2Tf0nyODoXzZ44+orFCy6lC6ncLmkiz+ZhBmIDQL7JpJUFd4iWGQ== X-Received: by 2002:a17:903:11cc:b0:1fb:6121:dfc0 with SMTP id d9443c01a7336-1fc3e6cae84mr37740675ad.19.1721144809911; Tue, 16 Jul 2024 08:46:49 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:5d01:167d:9cf4:148e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fc0bbc2782sm59434125ad.102.2024.07.16.08.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 08:46:49 -0700 (PDT) Date: Tue, 16 Jul 2024 09:46:45 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Zhu , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Jacky Bai Subject: Re: [PATCH 5/6] remoteproc: imx_rproc: allow tx_block to be set Message-ID: References: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com> <20240712-imx_rproc-v1-5-7bcf6732d328@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240712-imx_rproc-v1-5-7bcf6732d328@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_084651_387986_8F23532E X-CRM114-Status: GOOD ( 21.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 12, 2024 at 04:34:58PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Current tx_block is set to true, but there is case that no need to wait > response. Linux just needs to send data to remote processor, so let's > allow tx_block could be set to false. Ok, maybe - but this patch doesn't use the new functionality, i.e nothing changes. > > Reviewed-by: Jacky Bai > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 552fccebf7e2..01cf1dfb2e87 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -90,7 +90,7 @@ struct imx_rproc_mem { > #define ATT_CORE_MASK 0xffff > #define ATT_CORE(I) BIT((I)) > > -static int imx_rproc_xtr_mbox_init(struct rproc *rproc); > +static int imx_rproc_xtr_mbox_init(struct rproc *rproc, bool tx_block); > static void imx_rproc_free_mbox(struct rproc *rproc); > > struct imx_rproc { > @@ -369,7 +369,7 @@ static int imx_rproc_start(struct rproc *rproc) > struct arm_smccc_res res; > int ret; > > - ret = imx_rproc_xtr_mbox_init(rproc); > + ret = imx_rproc_xtr_mbox_init(rproc, true); > if (ret) > return ret; > > @@ -629,7 +629,7 @@ static void imx_rproc_kick(struct rproc *rproc, int vqid) > > static int imx_rproc_attach(struct rproc *rproc) > { > - return imx_rproc_xtr_mbox_init(rproc); > + return imx_rproc_xtr_mbox_init(rproc, true); > } > > static int imx_rproc_detach(struct rproc *rproc) > @@ -794,7 +794,7 @@ static void imx_rproc_rx_callback(struct mbox_client *cl, void *msg) > queue_work(priv->workqueue, &priv->rproc_work); > } > > -static int imx_rproc_xtr_mbox_init(struct rproc *rproc) > +static int imx_rproc_xtr_mbox_init(struct rproc *rproc, bool tx_block) > { > struct imx_rproc *priv = rproc->priv; > struct device *dev = priv->dev; > @@ -817,7 +817,7 @@ static int imx_rproc_xtr_mbox_init(struct rproc *rproc) > > cl = &priv->cl; > cl->dev = dev; > - cl->tx_block = true; > + cl->tx_block = tx_block; > cl->tx_tout = 100; > cl->knows_txdone = false; > cl->rx_callback = imx_rproc_rx_callback; > @@ -1083,7 +1083,7 @@ static int imx_rproc_probe(struct platform_device *pdev) > > INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); > > - ret = imx_rproc_xtr_mbox_init(rproc); > + ret = imx_rproc_xtr_mbox_init(rproc, true); > if (ret) > goto err_put_wkq; > > > -- > 2.37.1 >