From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AE55C3DA59 for ; Tue, 16 Jul 2024 15:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qmk5Z4IT/WUXoxm4I3cPr8Nj8s2eF45loLGWh3Zjhdk=; b=Rqxo/VrAtjcCnIyo16N7QJWEp9 g11HJs9JnwAuMvDlJ9J4QKS9G6OZyvIzAfBj7v5DUlvhwvD9FLMDHHinig1UpLSgFNzojKBZi+5NW UyXKrKMMX18zMnhZTQ3mmb6gN62dq2k+avKsV82Tkex2+Czi2gcnvf1/Zmxgxi1DkglEKzILEqWVp vmJfT4z8UQeFiHADTensetQH6e9E7e1g1ZzVJTZI1ODBEXNHF57rt70A9CAeAV1vgrYtM0lPV/c1y Dcpgw7QQ+X/9O5isj879aeBkPJ75d5ng5owP/niF5yHLcSvhlO8K9W7mgO2ck6I3HgIDJK5/PGi0k 8Pptk/qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTkRW-0000000Ax6a-0OlS; Tue, 16 Jul 2024 15:50:18 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTkRB-0000000Ax0x-3UNk for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2024 15:49:59 +0000 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-70b702be5e4so2949780b3a.0 for ; Tue, 16 Jul 2024 08:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721144996; x=1721749796; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Qmk5Z4IT/WUXoxm4I3cPr8Nj8s2eF45loLGWh3Zjhdk=; b=Ajb8Jiyj2HEA6s46GKLku3p43us2QIQXn0Vh4MPZAel67MjDyWtyQyGdRPkIa6udpd MWPdyBvxyTeybAbwjnZz9qr3VTKT7A7dqdDIhWotXieZ7ZjNS1iTLGvNgMU2MFF2Kpik oYKypXkVqkRUlejvNxrNzNhbL+Nh3qdmWmfPdvnH33NuajqZ1cOb7E838H51D7pmRF7H b54i58xpkRbrASoMrDwkr1OkSpFIk0dxqWl1WKecRN1gdAO6Cb6wwDhuLmqq+EB7iQLl RWnKtTSsBha+zlsdw6gu/XkjfHGq0BtAUC0J5/iDZ9MANQXEaipWC1LbFZSeqHO67COn j8oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721144996; x=1721749796; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qmk5Z4IT/WUXoxm4I3cPr8Nj8s2eF45loLGWh3Zjhdk=; b=Xmyp9IEpt3dKh9kZzblk3zSlxW37em49tvZsBHtTgHqPGhxxfbByg1NfbaEOCum5UC W50/Aja65axq3RmJFPQl7mYuRU5OmPOmVkiXqfDqmB1w9PV7jIoNs5ZtpUBQ4+mUt29t Dq88hBNo3/tlDXYppmAfohHQErBAnz+t4653YYT6DcEU8JT6c70LgTR/4trx/aGgnYB/ mctS57IaVJ5qfiUHv7jIXvwpJHE1Zf/aZ3KDuijlfeLyFfW7dNDL+wp6nl0Q+Jd0aSrh ug6n9fUsi+ziQffjArtx+3p67hYqRCbrhdNenkbQSTAA/ThPbzHF/fmRaJY4WzVt/R+P zhfg== X-Forwarded-Encrypted: i=1; AJvYcCVKxfhZuCHHot3qg47CCAqAOfNkt3jouGeaAAsm90Gq8XaTg76/6agVh2nCuN66QddvGuX53Dmp8xVyw8rpPWT7kRqOk+Hp/x87MBCFYIHrviNmb60= X-Gm-Message-State: AOJu0Yya6zUMBryuGKkr+Zha/aL4x2WDivxvSJvAHrI5DAd5dLDrLaDh xFpAl4rZOKKFFbtxj1EObvoGH5Q4w4YjxmH8MdEbjM6Z9tSiDLSZ7ziO+4JMTY0= X-Google-Smtp-Source: AGHT+IFgsccCrFEj/kSvTt/1puQQ8yew0zZCPSA1ewKljzJ2CdEca2/4yKweZZ7ydQaRy1tTj7ZnnQ== X-Received: by 2002:a05:6a00:2381:b0:705:b6d3:4f15 with SMTP id d2e1a72fcca58-70c2e9b5544mr3169227b3a.25.1721144996374; Tue, 16 Jul 2024 08:49:56 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:5d01:167d:9cf4:148e]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b7ebb8139sm6472526b3a.80.2024.07.16.08.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 08:49:55 -0700 (PDT) Date: Tue, 16 Jul 2024 09:49:52 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Zhu , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Jacky Bai Subject: Re: [PATCH 6/6] remoteproc: imx_rproc: handle system off for i.MX7ULP Message-ID: References: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com> <20240712-imx_rproc-v1-6-7bcf6732d328@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240712-imx_rproc-v1-6-7bcf6732d328@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_084957_900275_21D26F05 X-CRM114-Status: GOOD ( 27.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 12, 2024 at 04:34:59PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The i.MX7ULP Cortex-A7 is under control of Cortex-M4. The i.MX7ULP Linux > poweroff and restart rely on rpmsg driver to send a message to Cortex-M4 > firmware. Then Cortex-A7 could poweroff or restart by Cortex-M4 to > configure the i.MX7ULP power controller properly. > > However the reboot and restart kernel common code use atomic notifier, > so with blocking tx mailbox will trigger kernel dump, because of > blocking mailbox will use wait_for_completion_timeout. In such case, > linux no need to wait for completion. > > Current patch is to use non-blocking tx mailbox channel when system > is going to poweroff or restart. > > Reviewed-by: Jacky Bai > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 01cf1dfb2e87..e1abf110abc9 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -114,6 +115,7 @@ struct imx_rproc { > u32 entry; /* cpu start address */ > u32 core_index; > struct dev_pm_domain_list *pd_list; > + struct sys_off_data data; > }; > > static const struct imx_rproc_att imx_rproc_att_imx93[] = { > @@ -1050,6 +1052,22 @@ static int imx_rproc_clk_enable(struct imx_rproc *priv) > return 0; > } > > +static int imx_rproc_sys_off_handler(struct sys_off_data *data) > +{ > + struct rproc *rproc = data->cb_data; > + int ret; > + > + imx_rproc_free_mbox(rproc); > + > + ret = imx_rproc_xtr_mbox_init(rproc, false); This is new functionality and has nothing to do with the rest of this set. Please introduce patches 5/6 and 6/6 as part of a new patchset. Thanks, Mathieu > + if (ret) { > + dev_err(&rproc->dev, "Failed to request non-blocking mbox\n"); > + return NOTIFY_BAD; > + } > + > + return NOTIFY_DONE; > +} > + > static int imx_rproc_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -1104,6 +1122,24 @@ static int imx_rproc_probe(struct platform_device *pdev) > if (rproc->state != RPROC_DETACHED) > rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot"); > > + if (of_device_is_compatible(dev->of_node, "fsl,imx7ulp-cm4")) { > + ret = devm_register_sys_off_handler(dev, SYS_OFF_MODE_POWER_OFF_PREPARE, > + SYS_OFF_PRIO_DEFAULT, > + imx_rproc_sys_off_handler, rproc); > + if (ret) { > + dev_err(dev, "register power off handler failure\n"); > + goto err_put_clk; > + } > + > + ret = devm_register_sys_off_handler(dev, SYS_OFF_MODE_RESTART_PREPARE, > + SYS_OFF_PRIO_DEFAULT, > + imx_rproc_sys_off_handler, rproc); > + if (ret) { > + dev_err(dev, "register restart handler failure\n"); > + goto err_put_clk; > + } > + } > + > ret = rproc_add(rproc); > if (ret) { > dev_err(dev, "rproc_add failed\n"); > > -- > 2.37.1 >