From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C705C3DA49 for ; Tue, 16 Jul 2024 15:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JKBILTe7q/CPySmaWkq9DzQOt5Q1y7jNxqFaGU3vksE=; b=LZf9ojwGBQ2MsHOG9CQn+K/nHY nxQE35f5gm2vYsZ2GVfiofWq00ktS3k9D0kb0iEwciVjiNpLXsxIe+23B7XTW3/Wze9+/1oR9Hghf lhdU200rwoqCQWLM/14TL1fUq1QIm3bJq+HTcUsjUsFimeLoWhSSXaSLjXxpAmF3qdo8dCikc5mJT gTTwSQPHdp3zu1dtsLOvBDLxCkuNDBPB7hCDiEAFIX6qkHL96yx7BXvn/Y60H5RVK2pMYInTcznte cTTCagZBBsgYNFEmPN6tYGeeFc67jqycBzSxgcqwOZ2ZW44GRRODR+A9s4MmJsLTxmps40Cq0xbhc +aY1LVsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTkUP-0000000Axsa-0NUX; Tue, 16 Jul 2024 15:53:17 +0000 Received: from mail-oa1-x32.google.com ([2001:4860:4864:20::32]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTkU4-0000000Axo9-2LwU for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2024 15:52:58 +0000 Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-25e24900a82so2658471fac.3 for ; Tue, 16 Jul 2024 08:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721145175; x=1721749975; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JKBILTe7q/CPySmaWkq9DzQOt5Q1y7jNxqFaGU3vksE=; b=uwYfOjJzRN6d7XkLkzf5fMiOhzGB+fgNY5dJcmkeKgkF3OfkIyx7i0KyVNClpDkTxQ JXIKJl2T1gkhO7qw8j/cDIXI+v+nUh3M13RBfb5CHQ3Rqaa76V5vOnaZCLD7EvpRTEPr JdZ12aKAhvaBP/iVFqulVTG6LIhqu6THpTUaj5Er/2anwltcyS3dB5rZo4Pk+WSrVugA i5K1wS2IdzRjg7k+uQp4JSJC4ZT05U47k1kXfKsm73BwhJNqVoD1Ac6crxez3f+ndzx2 GPBqaIlVK0M4EhSMyY1JD5TCwe4HNwC8c+E5SjBAQuoouPZ+mBSJYDpdoEpn08P/6NZu AJGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721145175; x=1721749975; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JKBILTe7q/CPySmaWkq9DzQOt5Q1y7jNxqFaGU3vksE=; b=xUkI5bvc80j7v7CvtQodZsq8RuEdGFtX6eLwn12IZR3peI0Dbl2EvDbRsOszKI8ZQy gB46NWU9Su0Bda70B0xSPwqlCW8+D5flxdOnlgJTW7gqP6oG12gF/fhz/SdPU+Djqpge f438EM7QOW+eKjmQNGEskkUIQe0NkeeHUMP4kPDMXqy4Mnld9zeTwvcCohSEVuDw4Ka4 I1A5JFfEBUOZmyKxszG419uiT3B88OW0ZsjAcWo2++oYphZCV/0FonoWYLi//zlwUzYQ JKyLYKwKCQkgvTiY73rpczTmzIRnCJ6QXo1BqYBVmVJ8QztU1+nKdmZJfxFCZdfZ6+XU IgbQ== X-Forwarded-Encrypted: i=1; AJvYcCWTLgBlUfLl+9aNCO62/Uy4IMwLAVM8AN5/6SvmCcdT5ibatPYJAR2s+POd79Etpo8bkHOBNaecMuESoZNurmNh7ax4XOqqW2PRlIlS0J9fyE9tL7I= X-Gm-Message-State: AOJu0Yzh/MQ+x8eKhBZB0oPRWGw46NWhEOqqvvqEV9H1g4h9isBxArkK vQZs8e4UZ8JU9YxkEauRzCnxFVUs6yrtuQ/iK9+PB9WtbQ+S/aTnTcoKOGLZvRg= X-Google-Smtp-Source: AGHT+IGH6ZKwNcpITCBiSLzXtugAEPFVOciGhSh9sNS1/35g9a9+BEGmAmqFmL5Y4P5U+f0AZD+88Q== X-Received: by 2002:a05:6870:ac0f:b0:25e:26b6:d028 with SMTP id 586e51a60fabf-260bd780fc9mr2192578fac.32.1721145175234; Tue, 16 Jul 2024 08:52:55 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:5d01:167d:9cf4:148e]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b7ebb6aacsm6475011b3a.64.2024.07.16.08.52.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 08:52:54 -0700 (PDT) Date: Tue, 16 Jul 2024 09:52:51 -0600 From: Mathieu Poirier To: Iuliana Prodan Cc: "Peng Fan (OSS)" , marex@denx.de, daniel.baluta@nxp.com, Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Zhu , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Terry Lv Subject: Re: [PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for i.MX8M Message-ID: References: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com> <20240712-imx_rproc-v1-1-7bcf6732d328@nxp.com> <4819651d-b9f7-4fa4-81b9-614b6d4d5a80@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4819651d-b9f7-4fa4-81b9-614b6d4d5a80@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_085256_989087_9437106C X-CRM114-Status: GOOD ( 26.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2024 at 06:49:39PM +0300, Iuliana Prodan wrote: > Hi Mathieu, > > On 7/16/2024 6:16 PM, Mathieu Poirier wrote: > > Good morning, > > > > On Fri, Jul 12, 2024 at 04:34:54PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > > > The DDR Alias address should be 0x40000000 according to RM, so correct > > > it. > > > > > > Fixes: 4ab8f9607aad ("remoteproc: imx_rproc: support i.MX8MQ/M") > > This commit was merged more than 3 years ago... I don't see how such a blatant > > mistake could have survived this long without causing problems or being noticed. > > Most probably whoever used imx_rproc and ran into this issue checked NXP > tree where this is fixed - see here https://github.com/nxp-imx/linux-imx/blob/lf-6.6.y/drivers/remoteproc/imx_rproc.c#L232 > > On top of things checkpatch gives me a warning. > > > > > Reported-by: Terry Lv > > > Signed-off-by: Peng Fan > > > --- > > > drivers/remoteproc/imx_rproc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > > > index 144c8e9a642e..3c8b64db8823 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -210,7 +210,7 @@ static const struct imx_rproc_att imx_rproc_att_imx8mq[] = { > > > /* QSPI Code - alias */ > > > { 0x08000000, 0x08000000, 0x08000000, 0 }, > > > /* DDR (Code) - alias */ > > > - { 0x10000000, 0x80000000, 0x0FFE0000, 0 }, > > > + { 0x10000000, 0x40000000, 0x0FFE0000, 0 }, > > Without access to HW or the documentation there is no way for me to assess the > > validity of this patch. Marek, Iuliana and Daniel - please review and test this > > patch. > > HW documentation can be downloaded from > https://www.nxp.com/webapp/Download?colCode=IMX8MDQLQRM (one needs to create > an account) > So, > Reviewed-by: Iuliana Prodan > The very quick reply is much appreciated. I will merge this at the beginning of the 6.11 cycle. > Thanks, > Iulia > > > Thanks, > > Mathieu > > > > > /* TCML */ > > > { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM}, > > > /* TCMU */ > > > > > > -- > > > 2.37.1 > > >