From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E9EEC3DA62 for ; Wed, 17 Jul 2024 18:18:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5oHut87D6z1C8WP4tomrAFIZpN051t+MZkDwU8ZedwM=; b=zFcPUEIU7kkMhK/LJZA72FJFck 5Wk0iLdYxyYvroWrZ1ZWuu2jb4jh4549VZLQID12KuTLfECyoyAlRk9GkqcDkhveTvo6dzrhEoQd9 EyCTZ0rOJttFP6fb/Z3B6SonKntgbeUUeLdU6WPeyGdzeAnKs3WOV3BqexiE/dDnRB6EOgafZ8aAK hRNJjJB8qPCN6hUyjucTx3R56fVDZyGJrGHSAswzcU5mM8IaikPkDXTTa5IkHocTsCBgbQu7PucVU k+BP8D1C2Ts6K3p0acj8bDoNIG6pyCvr768vzTnJ8UpcbtvEhgYwAzvej6aoqRfJrPEJYF988m+A1 893KcSkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sU9EJ-0000000Eb9U-2CpC; Wed, 17 Jul 2024 18:18:19 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sU9Ds-0000000Eb1M-3nZz for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2024 18:17:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 15754CE175D; Wed, 17 Jul 2024 18:17:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6391AC2BD10; Wed, 17 Jul 2024 18:17:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721240269; bh=xG/9M2YavZom5kIlcTESdu1TdLcTU+btfbM14zlJ3cE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BcCHaCAm0qXDRw3bZnE+AcN0w4CbecimO0KOgpmTadpfOKW/+U12xVwtQ79GvM9JA zoBqq/u3x6lIqimguB/eT6Izw1prPdRb6/dQePwdAegtA0TME84ZTz2v/bUAMcBAD4 MzXR94ap8DM4UGs3fVudDQmfzMC0ZJcezPNER+B666vVST6eChXqMnGOgfQIr/6+NH hig88ED1aJP3EJQU4X9EOS/BqSz+S15tOeOQTma99y9UEuMy7PN+SGWlSY2i63nYQl RW+OGJMA4UIgY3XY5I/VG9TeKgFTX1OYv+nh09iyS8B9BgNC+tXXH4zO6XTnFydlbP M6i+aXsX0+dNw== Date: Wed, 17 Jul 2024 20:17:43 +0200 From: Niklas Cassel To: Richard Zhu Cc: tj@kernel.org, dlemoal@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, linux-ide@vger.kernel.org, stable@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH v3 3/4] ata: ahci_imx: Enlarge RX water mark for i.MX8QM SATA Message-ID: References: <1721099895-26098-1-git-send-email-hongxing.zhu@nxp.com> <1721099895-26098-4-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1721099895-26098-4-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240717_111753_342720_8D904D23 X-CRM114-Status: GOOD ( 20.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Richard, On Tue, Jul 16, 2024 at 11:18:14AM +0800, Richard Zhu wrote: > The RXWM(RxWaterMark) sets the minimum number of free location within > the RX FIFO before the watermark is exceeded which in turn will cause > the Transport Layer to instruct the Link Layer to transmit HOLDS to > the transmitting end. > > Based on the default RXWM value 0x20, RX FIFO overflow might be > observed on i.MX8QM MEK board, when some Gen3 SATA disks are used. > > The FIFO overflow will result in CRC error, internal error and protocol > error, then the SATA link is not stable anymore. > > To fix this issue, enlarge RX water mark setting from 0x20 to 0x29. > > Fixes: 027fa4dee935 ("ahci: imx: add the imx8qm ahci sata support") > Cc: stable@vger.kernel.org > Signed-off-by: Richard Zhu > --- Looking at the title of this patch: "ahci_imx: Enlarge RX water mark for i.MX8QM SATA" This suggests that this fix is only needed for i.MX8QM. Support for i.MX8QM was added to the device tree binding in patch 1/4 in this series. Doing a git grep in linux-next gives the following result: $ git grep fsl,imx8qm-ahci linux-next/master linux-next/master:drivers/ata/ahci_imx.c: { .compatible = "fsl,imx8qm-ahci", .data = (void *)AHCI_IMX8QM }, This is interesting for two reasons: 1) drivers/ata/ahci_imx.c already has support for this compatible string, even though this compatible string does not exist in any DT binding (in linux-next). 2) There is not a single in-tree device tree (DTS) that uses this compatible string ....and we do not care about out of tree device trees. Considering 2) I do NOT think that we should have Cc: stable@vger.kernel.org on this... we shouldn't just backport random driver fixes is there are no in-tree users of this compatible string. So I suggest that: -Drop the CC: stable. -I actually think that it is better that you drop the Fixes tag too, because if you keep it, the stable bots will automatically select this for backporting, and then we will need to reply and say that this should not be backported, so better to avoid adding the Fixes tag in the first place. (Since there are no users of this compatible string, there is nothing that is broken, so there is nothing to fix.) Damien, when applying this patch, I suggest that we apply it to for-6.12 together with the rest of the series (instead of applying it to for-6.11-fixes). Kind regards, Niklas