From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 716EFC3DA49 for ; Thu, 18 Jul 2024 14:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L4EicoIga3irNfep9vd/yS9f61b9izPttbB5R3om0HY=; b=TOV8mK/YSLImVS2SrWSJ0zwkyC 3xERp5wtBfsSZV7tX+8uamhTrv7XeGUj1G2aAZAlM1od1npLZai9vUwbLXHX/kX9Rd5rHvqYB4BSW eCfqhgR/0zzCPe1KqlhuqD8ta6Fi2ti4ke/lI6fAtksgfd4BIJbKcexOXbM2xscI2Tn8/vZTR1OOT FM7FCzkrYmg3Z9/mLEm9X2fgJ6bP5ErhJG2DMGQXEbuyMG215hy3IFXvIKXr7EiT0NHXgYITDirSz 5WFz+vnY26PRe7cgtt9rrSg+t7+WrRECVn9J6eMRYh7qWesVp5OTlWvAjsg4SBiFZVcYP7T4oIKIW cAtJ655Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUSOW-0000000HJjv-0kyv; Thu, 18 Jul 2024 14:46:08 +0000 Received: from mail-vi1eur03on2061c.outbound.protection.outlook.com ([2a01:111:f403:260c::61c] helo=EUR03-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUSOA-0000000HJfG-11gT for linux-arm-kernel@lists.infradead.org; Thu, 18 Jul 2024 14:45:48 +0000 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=AhvcOz89YqAuSOOrBustDCunQfRUCVF036QWllsL+vjB2BESZx1rOcLuOcUjMle3Jm9Ip14BqgrSmfKPgRXANOpL61v4xchCVO2mFDn4FsjK3DiwHL8YZLINYtI1uy5TXgGYW/Hx9UxtOJgIVgDzD51zT7lIQjKWSz4nUWD2CvL+/PbxOLC4Yk0udYEsz8kFF/IGuTWS3eyo57TFmevU1KWIy09cuDl/c7tqRP70fwh1UjkosKa4KPJGIk1CUKkogDHQlZ2oEOXAQN9xhsQ16NyP6E7el0mih5jnFmDj07IsOmW42lhGbwZyb2MfvVF4booFVHVFtNHyqD1fs1PjeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L4EicoIga3irNfep9vd/yS9f61b9izPttbB5R3om0HY=; b=IXjtGAaCSV2WKb6YyyKk4RTxoqQnHZp8q65x8wHTmHQ06hGrKQjRd7JkBVJOkQZ2hFUvX2WZWoEbirgx29rS/+jx6QKRC1JE5Q0KI72ISaoo+dbC2hrAn+QEgTowln/83TEqleVI0yqhXM9NmefNAHCWlkwUbSor3DPgdSvPYqJghIvX7543qwdjVZYOdZxpWMj/aLcpfPITvDcDiJ3k31RvpsHvdfBpXjc1Ny+j3O3tApHek/scbDsbx/vn7VX7sc16Qwn8YohqJWZL857LeH+iG+fnzz412m/xTOd95C4VRtyV4h+XwArQ36Vyt0+jGK1c98QN93HJnaxvXwtlsQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L4EicoIga3irNfep9vd/yS9f61b9izPttbB5R3om0HY=; b=sApcrNAB9BE/WAfUq8zR6qnODd3pmMY6n+eJCS5B00scn2hKlHhyZl0IK5YEGndEt4vgfGxCjy+nDg3lHj3Pi3dinXSw8f+pMV5FELgrt+DRIuqzlZBk+fCHD4xbu7WDbjeQRO0HeFyxM2mGxVX5KZS5/gKu/wqZ04XQx2tZ0xI= Received: from AM0PR06CA0074.eurprd06.prod.outlook.com (2603:10a6:208:fa::15) by AS8PR08MB9790.eurprd08.prod.outlook.com (2603:10a6:20b:615::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Thu, 18 Jul 2024 14:45:34 +0000 Received: from AM4PEPF00025F95.EURPRD83.prod.outlook.com (2603:10a6:208:fa:cafe::a1) by AM0PR06CA0074.outlook.office365.com (2603:10a6:208:fa::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.18 via Frontend Transport; Thu, 18 Jul 2024 14:45:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM4PEPF00025F95.mail.protection.outlook.com (10.167.16.4) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7784.5 via Frontend Transport; Thu, 18 Jul 2024 14:45:33 +0000 Received: ("Tessian outbound 0808e8e76ea3:v365"); Thu, 18 Jul 2024 14:45:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 353639cb5c53a94f X-CR-MTA-TID: 64aa7808 Received: from Le5933fce3642.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AF32D5CA-27E6-415C-AAE1-B7587D42A90A.1; Thu, 18 Jul 2024 14:45:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id Le5933fce3642.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 18 Jul 2024 14:45:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pPBVG+5adpoDeOHQonqzv6CMdIcdxgNOyKV5p5nFy/TMTIF066/wY/XtLV7u6blIQ3X2x8q6+MFM/ctetJSxZ5niaKcSOmCkP1egIjcNuoWnhD5cvciL5/Tzr16COvS04ybs8MhnYWWNwZesh+ZbSrqgMBXab7y0WyrN/hDvy3Zfmup23py4TobJRuxd/QwaYj2EHkN1XKwJ7PAo/xqOZ1bUSS2RBga/M1cOCzMxz37/Wr2JY6j1wz52deo9z3g7lnn3Phtg632Vh4pnPeV1jGjL3hg+HEDI9ON3pt9uF1MVGFJJ5D3zjUbyB9DhiOmw5vSbXNrwKgeBtAi915d9QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L4EicoIga3irNfep9vd/yS9f61b9izPttbB5R3om0HY=; b=usjoHcF7H5QRL9+59sMp6xHdkJoRfcg3y/eWQOujhRSntQdH8Z2YOSGkAXvdNaKSXdr9oeiHH3x9TQIio3fCYAcil8uJBAUjeMNBfjAwvAFh8yMqFjfFv1pII1tncBy1JmXOuPw6gvM/DZz/BuKjpAe2Jeuexj3lX6bbQTGiGH8rcsbfjdZccAGKdKsSEfvP36q0GRxtq6r3leqjPKv4xdo16UMlIrUGpEhLHbRA3xtUmUT+0DE87Znz+s2/soDVlUnI33pg1DgPe6YR1OjiBawybU1pfhyU8+kDYDD22vSjC5ApnPd+fpA9M5mgJnzPQL+G3cgLcGs95qpgPpkxhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L4EicoIga3irNfep9vd/yS9f61b9izPttbB5R3om0HY=; b=sApcrNAB9BE/WAfUq8zR6qnODd3pmMY6n+eJCS5B00scn2hKlHhyZl0IK5YEGndEt4vgfGxCjy+nDg3lHj3Pi3dinXSw8f+pMV5FELgrt+DRIuqzlZBk+fCHD4xbu7WDbjeQRO0HeFyxM2mGxVX5KZS5/gKu/wqZ04XQx2tZ0xI= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by GVXPR08MB7822.eurprd08.prod.outlook.com (2603:10a6:150:3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.29; Thu, 18 Jul 2024 14:45:18 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::7d7e:3788:b094:b809]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::7d7e:3788:b094:b809%6]) with mapi id 15.20.7762.020; Thu, 18 Jul 2024 14:45:18 +0000 Date: Thu, 18 Jul 2024 15:45:04 +0100 From: Szabolcs Nagy To: Joey Gouly , Catalin Marinas Cc: Florian Weimer , dave.hansen@linux.intel.com, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, christophe.leroy@csgroup.eu, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev, yury.khrustalev@arm.com Subject: Re: [PATCH v4 17/29] arm64: implement PKEYS support Message-ID: References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-18-joey.gouly@arm.com> <20240531152138.GA1805682@e124191.cambridge.arm.com> <87a5jj4rhw.fsf@oldenburg.str.redhat.com> <20240711095000.GA488602@e124191.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240711095000.GA488602@e124191.cambridge.arm.com> X-ClientProxiedBy: LO4P123CA0317.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::16) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|GVXPR08MB7822:EE_|AM4PEPF00025F95:EE_|AS8PR08MB9790:EE_ X-MS-Office365-Filtering-Correlation-Id: 514ac02d-57c5-434b-41c1-08dca738478a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|7416014|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?bHduTFVjNlR0MHlWeTYxbjN5OWhuSjczLzQ1MHJzMVZQOFg0QXlJVG4vY0h4?= =?utf-8?B?OFZ4dXJ1RFluVGdMVCsyanU2L0gyY3l2bGhNK29ma1lyMXE4ckpVNHl4L1BF?= =?utf-8?B?Z2QwdFRnNmo4aVRsZzZsVVJ2NHBIRHpPTzNvd0RycUtRSG13aUNqVnVBM1M1?= =?utf-8?B?aDAvZTN3ajNSck9JSVRlenVnUVlPOWZFZkorenRHMXlvbmUvK2pEcllIRmFX?= =?utf-8?B?WHdrbjhySGs3WDhVeEprZTJFdXVKTm9oc01yeWUxVnR6VDhiZ3FTckhUekxU?= =?utf-8?B?ZUJ5K0pIYis1UkxZdlc5UmtoWHp0Q2FTeC91N0kvbVVXVTNFVWNOM3piY3dG?= =?utf-8?B?QytRdXYyRmFrOW5HcUlldWRMQ3M4L3h0M1dSK2Y0NE0rMHBZQThyakEyQS96?= =?utf-8?B?RHRuSDRQMUVIOWZrUDdqdFZDN1NmbFNuZ0RzNmcvWWdKZGJFUEpESDZMdHYr?= =?utf-8?B?WXdSNUJPQmxEZDJsQ2VYSVFiSGpPa2NHOHYyNkROc1FxMDhrTGh1K0FTSWs4?= =?utf-8?B?bnJISGtIRlJzVFQ4bFVIM1pZUlJPKzdQcnJIWVBNNENiclJpaE8wNXJlbVJ2?= =?utf-8?B?aVJDeUNwVVNTMEVFbEFtSUZIK3FJdmpUUHhGc2ZpZVhnWkh1cmROcnRXWjRI?= =?utf-8?B?ZEdDbkQxWVlJSFlJZklhSWdtYk9kQWV2RUxPTjhXZ3RYQXBmeWpqR0VySTY3?= =?utf-8?B?UXJLNmdNT21YcmtXbTJmK2ErbklMeFFmTEdpaTlEZzB5U1FnTzg0V3FwcGdI?= =?utf-8?B?aTRXamxNQXYrTlhrT0FGYis5TDBXQ1hHZUtIZmtSdWh1WU1ibVFnN08zZEVP?= =?utf-8?B?YWlVaTBZL2tCZE1ZaWY0SjBQQ2tJejkxNWQ5dndtQ0N5TGppQWNXYmltOTdt?= =?utf-8?B?N2kxemhyMmJUMUhDRURWN0tXS2lWTWxKZVN4ZlNEejFuWVhaSVBVU2hrQTFQ?= =?utf-8?B?YmJyRTJHelY4bEw5RU41STdUT2xXK0VIQ1pLZmNyS1c1TGx6SVpBOEt2MDgw?= =?utf-8?B?Y2c5WTk0dE1zNkNIVGV6ZEdBdUMxWjNiSmpLYjFUb2FOZHdvVThsS1JnbEpo?= =?utf-8?B?YldWYk1nQ0NvcDRvVEJuQnVwUTJnSGlndzNGLzJNdGRSOVlINWhMS2I0UXd2?= =?utf-8?B?bXZNTkthTTQ0V1E1UzRNdytxM3pmTlh3WlJTQ2xHdkRweEhmRVZ5bGxNRFJS?= =?utf-8?B?RnhYZEtnWmRaK1VTNmRaR1l2d1JmUVpVVStkN2hEUTB3Mm1qUVlQNTVBOXps?= =?utf-8?B?OXA0bi9DaUp1RlhJd3NiVnVRWUJGVWZEK090d0o3WkNwTzVkV1ZxUW1VRCsr?= =?utf-8?B?M3gwU1BDbGlCTnZmd0lGUkJ1eUd4bmJOckhGaGQyamZrSHNzLy9nTDdDRU5N?= =?utf-8?B?NlJBN1pSTFlaMWxXMGUySVR2U0I1MDBGR25PT05zMHdiRVpzS0o0YTFsWEE2?= =?utf-8?B?bGVMdGQ0RHpWdmFOeko4SnVtV01lNjlpV2xYY3dZaDYvWFVGVm5qcUl0Z21H?= =?utf-8?B?SG16ZjVZQ2VXaE9ZN0VJQ2xkMXZ1Rnd0cm5GMkNncEF3R1FhbXp2SGZDMkdr?= =?utf-8?B?dFR0UWZra0pndmI3UldsejdQYmVOVzJVNm9ueUhSR0Z0WERaZXJXYy91N0Yz?= =?utf-8?B?RzNPekxFR1Q2Z1BQK0FNaGZ4VGFYNkllRlNCVThwdG5rT3ZMTmtmTjBrUEt6?= =?utf-8?B?bFhTZnVERGFwTWhUR1lMV01Fdi85Wk1DRElHd2U0YTVwTEhwNUdqZ1BmMW8x?= =?utf-8?B?MVZYNndvcUlEVlBuQ1dEcWJWbFM4amM1V3BVUjhMNGNTRjg4SXNXbnlDR2Jl?= =?utf-8?B?YXZiTFhGM3VGOG5OQTA3Zz09?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7822 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-SkipListedInternetSender: ip=[2603:10a6:10:2cc::19];domain=DB9PR08MB7179.eurprd08.prod.outlook.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00025F95.EURPRD83.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7fffc864-169c-438b-8f34-08dca7383e3d X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|35042699022|36860700013|34070700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VU01ekFKNmE5NVp4SUlMRytpcER0SVNyUS9DMUlabGhWSmpLZlVVN2hSTE01?= =?utf-8?B?ajc2eEtDVUg4bTBlYlZ3QjdSZjBWYUI1LzdOTU5OY3NsOGtKS2lZMDNaOWtm?= =?utf-8?B?YXJEWjhsUzJzQkpUSm9UemJmcFgwTFd5Y2tsbVlxRDQvZG81UGltdTJWU0pM?= =?utf-8?B?MGVoa1haNks0dGNZSnY4cWM4N3FodkZTR1JYdzluMWxWYU5UZkRyNFd5WkF3?= =?utf-8?B?UkQvcWVtUVBJKzRWdWdzR2ptQVdhVURZMFVJb3Urbm9HYm5aYTB4aGlTcE5F?= =?utf-8?B?WEtXWDNLM1VKRDdDamtHR1hNcUlES29UVHB6dzlrK1dxSWJaNFJISG1MOFNJ?= =?utf-8?B?L2ZHcWdOUWcwMFVaY2hWN29NYVFITkpXRUVINFd2MStxS2ZIaEJoWHFCQ3gx?= =?utf-8?B?UmxUT1YvejVmQzhrR3V6TlI1djdvYllLbE0vN2V2aTlFNWhDZEhKZlhpWllD?= =?utf-8?B?YnYyb3dtTEFPZDdNYWJYNkZidGwzOHdxbCtQb0RiWW1nV3JaSDZHZXRvRnlD?= =?utf-8?B?ZzBQK0R4NnZuVE9IdHZYOC9HVEIzSWw0aHNReEJzOTU5RWlIeTJ3bklwWFlB?= =?utf-8?B?Tk9idi9DOVEreFRSYmdwV1U0ekg5cW1FUHFjS2tzeXEzUGZDbHhCWXRwSnUz?= =?utf-8?B?MlB5cDFrMVFLZEFXa1FyS3Y0MWJnWlpRcTVFUUhuRHdtZnEvd2xJUHRFamNM?= =?utf-8?B?bnFPNHQ4NVRxVTJMeHNPLzBHL3JoYXhoVFFTaVBncXArMkN1ZE8rdnZES0dE?= =?utf-8?B?Z29WbzZBRnBSK0lqQXAvenFrVTV4QWx5OG5YbWJsOVFmeWtYa1gzT3pRVDVV?= =?utf-8?B?YTUxZHlxd2FicGJLbUdlakVqdGMyTDdYcEVGNkE2dENTekg3SVBHaTVQUW9m?= =?utf-8?B?ZXBBNmt0aWVYdjNuS0FMRTIwZWwzMGJBOHkvNDBSVHN2K3M5MGcxQjRIaFo0?= =?utf-8?B?SVVSN2tjdTVOU1RGZFJnVGR6b2ljZTJtdTVMenRnL2Y0VkxBUERrVFFQVWFo?= =?utf-8?B?aThzZE52bTBCYUJ1MU1pT09nMUExQlo1YUhhc1NTWTFIUlhFV3VCMXI2cEhx?= =?utf-8?B?SkErUzEvVG9TVWp5L1dXS0V3Zi9yN2hpaEJyL1F4UWhmZmY1ZDBWcmpFdGYv?= =?utf-8?B?U0s3cDRna0tCNXBYT1Y0cWJUQWJ1NVkxUGFEbiszeGlLVWx2a2Y1TVJsZTA5?= =?utf-8?B?QjdGcldVVGNXcXBKSHM5L2JjZEo5QVBOZ25UMmwzYmJiRVhxdUVVeDQxRlBD?= =?utf-8?B?c1huOGM0TytiMStZNlJkMVowYmE2cFRIZUZ6QXRWZ0dHdTEyeWF0cWs5aWZt?= =?utf-8?B?RlBNK0dEaTVyUkVNWnNzdFlJTlo1L2tnOGlvZEZwOU5DUk5NNUZDT3ZVZFdz?= =?utf-8?B?eE11YnQzbldFejBsS3VUWml0TVIwVlNYeXFXRHdEWGRIRnFZTzJaVjUwSy9O?= =?utf-8?B?eE5ab0o3V240b2tDUFFSS0JwclUyeUdrTEdheStFYmZTMFJ3dWZCdXlYYWVl?= =?utf-8?B?cU5MS1pSeUo1TVhiNFVsVlo1K295YllFY3dJYXhzK0Y5SkJYem9JMHBMVm0y?= =?utf-8?B?S2lyaG9qUmQ5ZXJPTDM5WmwyeVgwTUExdU5SNjRGd2kwTmlvYjhrYWFaNXZ0?= =?utf-8?B?Wk9oQWZ2eTlGWnlYZXE0UGRqYlU0NVU5LytqVC9BTmtDeE9UTHBMNVZSc2ZM?= =?utf-8?B?QzNDNWJoemhFVjEyTkJOY2VUYXc4dlNCV2xQYTMwa3pnbGNZU3VKRUE0ci9Q?= =?utf-8?B?UmFRYkh4d05FTXVHS2w0SGcrYkdmLzJnMUpZem5LSmU1NmdTQUFiR0UyVm1P?= =?utf-8?B?RDFxdDBQemZsZEJTeDdwenZBUmZxcnlIYW5aK1NVUHVkTFVyUHl6MEVqWldl?= =?utf-8?B?NC9QME9mWkI0OHA3N0FsQ3J1Zmt0Mk5HZjJ3T25VSEtMb2ZMMENDNDA2MGZa?= =?utf-8?Q?HG5GAofFZNfc+fjxSeQLN2YOvzKOWNBa?= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(35042699022)(36860700013)(34070700014);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2024 14:45:33.9393 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 514ac02d-57c5-434b-41c1-08dca738478a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00025F95.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9790 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240718_074546_478741_3ED963F5 X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 07/11/2024 10:50, Joey Gouly wrote: > On Mon, Jul 08, 2024 at 06:53:18PM +0100, Catalin Marinas wrote: > > On Mon, Jun 17, 2024 at 03:51:35PM +0100, Szabolcs Nagy wrote: > > > to me it makes sense to have abstract > > > > > > PKEY_DISABLE_READ > > > PKEY_DISABLE_WRITE > > > PKEY_DISABLE_EXECUTE > > > PKEY_DISABLE_ACCESS > > > > > > where access is handled like > > > > > > if (flags&PKEY_DISABLE_ACCESS) > > > flags |= PKEY_DISABLE_READ|PKEY_DISABLE_WRITE; > > > disable_read = flags&PKEY_DISABLE_READ; > > > disable_write = flags&PKEY_DISABLE_WRITE; > > > disable_exec = flags&PKEY_DISABLE_EXECUTE; ... > > On powerpc, PKEY_DISABLE_ACCESS also disables execution. AFAICT, the ... > Seems to me that PKEY_DISABLE_ACCESS leaves exec permissions as-is. assuming this is right the patch below looks reasonable to me. thanks. > Here is the patch I am planning to include in the next version of the series. > This should support all PKEY_DISABLE_* combinations. Any comments? > > commit ba51371a544f6b0a4a0f03df62ad894d53f5039b > Author: Joey Gouly > Date: Thu Jul 4 11:29:20 2024 +0100 > > arm64: add PKEY_DISABLE_READ and PKEY_DISABLE_EXEC it's PKEY_DISABLE_EXECUTE (fwiw i like the shorter exec better but ppc seems to use execute) > > TODO > > Signed-off-by: Joey Gouly > > diff --git arch/arm64/include/uapi/asm/mman.h arch/arm64/include/uapi/asm/mman.h > index 1e6482a838e1..e7e0c8216243 100644 > --- arch/arm64/include/uapi/asm/mman.h > +++ arch/arm64/include/uapi/asm/mman.h > @@ -7,4 +7,13 @@ > #define PROT_BTI 0x10 /* BTI guarded page */ > #define PROT_MTE 0x20 /* Normal Tagged mapping */ > > +/* Override any generic PKEY permission defines */ > +#define PKEY_DISABLE_EXECUTE 0x4 > +#define PKEY_DISABLE_READ 0x8 > +#undef PKEY_ACCESS_MASK > +#define PKEY_ACCESS_MASK (PKEY_DISABLE_ACCESS |\ > + PKEY_DISABLE_WRITE |\ > + PKEY_DISABLE_READ |\ > + PKEY_DISABLE_EXECUTE) > + > #endif /* ! _UAPI__ASM_MMAN_H */ > diff --git arch/arm64/mm/mmu.c arch/arm64/mm/mmu.c > index 68afe5fc3071..ce4cc6bdee4e 100644 > --- arch/arm64/mm/mmu.c > +++ arch/arm64/mm/mmu.c > @@ -1570,10 +1570,15 @@ int arch_set_user_pkey_access(struct task_struct *tsk, int pkey, unsigned long i > return -EINVAL; > > /* Set the bits we need in POR: */ > + new_por = POE_RXW; > + if (init_val & PKEY_DISABLE_WRITE) > + new_por &= ~POE_W; > if (init_val & PKEY_DISABLE_ACCESS) > - new_por = POE_X; > - else if (init_val & PKEY_DISABLE_WRITE) > - new_por = POE_RX; > + new_por &= ~POE_RW; > + if (init_val & PKEY_DISABLE_READ) > + new_por &= ~POE_R; > + if (init_val & PKEY_DISABLE_EXECUTE) > + new_por &= ~POE_X; > > /* Shift the bits in to the correct place in POR for pkey: */ > pkey_shift = pkey * POR_BITS_PER_PKEY; > > > > Thanks, > Joey