From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEF40C3DA5D for ; Fri, 19 Jul 2024 14:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XdlmiGKKf4P64YOv5lQSDuR8ybLle1v3kavGCeiCW+U=; b=459iRwW0TBaFqrKSy3RqPso47t RHVJHXQ+nh5YE7u6fVvxZ9Ab6d4szSp6PaSTOeMUi5Bi/SRawxcYxvCV8LOnHfNqqAKI0uZLN/vMn 80GC6BQWDxS+wlid7mFENkpaPOfU8VFvJtLiPvUA3pIY+znz3MeTkI5nrzGNVbevui3o+J3NDBgDu 1v+v8UBIAFJIFSgJqHrhATne9NtOmpgpoTNa4W1Le6Mu+QDP1Vj5XQxMJq5JLZwMjxEMXx6tEkcWb jeBRT4WvuiCUUHRUV54AryfeCLJC2MCYMRuEY0FyDz+19JcIaHqCeYaDtFxha4PpU4EpfiFJDTLnd KvQfW0Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUoiu-00000002xPD-1RVM; Fri, 19 Jul 2024 14:36:40 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUoiU-00000002xJa-0ISd for linux-arm-kernel@lists.infradead.org; Fri, 19 Jul 2024 14:36:19 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4266f344091so13324175e9.0 for ; Fri, 19 Jul 2024 07:36:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721399769; x=1722004569; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XdlmiGKKf4P64YOv5lQSDuR8ybLle1v3kavGCeiCW+U=; b=v9aVE1oCRMUBDafVD+q9hZPievFza7r6sIDYhqFBtLMUKXUQDpq+x1MhFN60c1QEey L/WlQPz0npaoWcidnw0twCFMfoxzNt/8XRi3v0OLNb8KcLGENFOfKS7vPWJmU+U4c1EJ 5qH/ftiqtpOQtWtuENFRFpIOIbLlpgjBiJuhMtnMa19pLsgWonFGrOa/xcSME9OziC1O qmCDhww0mJvasFDf+jhHTQ5UwP9fywb+aIfWNKUfPRLfio02TDKP7NCeqPeVDQ1h//TG UPq6v9JWlrFCKkng9yP+y6fzXTq+MOksINHevIHIG/leutSx3ylgRXSbOT0k5UdFM79A Lzog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721399769; x=1722004569; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XdlmiGKKf4P64YOv5lQSDuR8ybLle1v3kavGCeiCW+U=; b=CrNQW5RA23mWSTAzJ5p9abCd5vv4zB60CMdfX2t7lh1ZQSK2sSFkajOI/psmQKKmn+ O9DF/3T+5OHoscXdoKgYWGFcTiQVYT9KkT3HgJjEwot4MEXzFBhvwEkAaLY/MA11hr36 Jg0f58Ousk6FDHsjTUKx04h6UTki0w8LvhXM6jt2wbsaO+qwdHd+fgMDlyjAJnwWYgHz mktL5gQVs7MrDHKBl5YMOGFpDS8bZD3ZgErMlXtM5QvSrFoBcsd3fKhIBs6QNRL0Inf6 XaQwoP5xWNAp6vDlU4cj8dkho9jDmDdHDpD/A+T82aK/HgIetvAk56IWXT5VgW9k+LjU torQ== X-Forwarded-Encrypted: i=1; AJvYcCU6y3LRCAO5BT7KojqQDXq40Ahy4WqlFKTa4jrlSaX9DMf8gkcq8Ejbo2IuLYDbfnkNd423c3bMe9jIomFhtKiBLJV+gRlAjODTyay2LixvbvwVQeY= X-Gm-Message-State: AOJu0YyJjfCk90jZ0acwIKaoL0CDadK7wY6wO5OILf/GCb5Yv27FlqIv apShwaa1m+9qe8X+7pG32NrsDw4NfpJowhFeXspfenSZDp7rBPKqhflpxL01Dw== X-Google-Smtp-Source: AGHT+IFA/wA9e42Kh22TLUFramVCLKGDe8eWOeYO6wA/icFUlL9M4s7EtisnJ7yAOuE2+K35INQfAw== X-Received: by 2002:a05:600c:4e90:b0:426:6326:4cec with SMTP id 5b1f17b1804b1-427c2ce8d0emr61277055e9.29.1721399768362; Fri, 19 Jul 2024 07:36:08 -0700 (PDT) Received: from google.com (203.75.199.104.bc.googleusercontent.com. [104.199.75.203]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d2a43034sm54732375e9.3.2024.07.19.07.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jul 2024 07:36:07 -0700 (PDT) Date: Fri, 19 Jul 2024 15:36:04 +0100 From: Vincent Donnefort To: Sebastian Ene Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, mark.rutland@arm.com, maz@kernel.org, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v7 5/6] KVM: arm64: Initialize the ptdump parser with stage-2 attributes Message-ID: References: <20240621123230.1085265-1-sebastianene@google.com> <20240621123230.1085265-6-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240719_073618_086606_F1375A7C X-CRM114-Status: GOOD ( 25.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 19, 2024 at 02:09:19PM +0000, Sebastian Ene wrote: > On Tue, Jul 16, 2024 at 10:59:41AM +0100, Vincent Donnefort wrote: > > On Mon, Jul 01, 2024 at 02:18:39PM +0000, Sebastian Ene wrote: > > > On Mon, Jul 01, 2024 at 09:42:43AM +0100, Vincent Donnefort wrote: > > > > O Fri, Jun 21, 2024 at 12:32:29PM +0000, 'Sebastian Ene' via kernel-team wrote: > > > > > Define a set of attributes used by the ptdump parser to display the > > > > > properties of a guest memory region covered by a pagetable descriptor. > > > > > Build a description of the pagetable levels and initialize the parser > > > > > with this configuration. > > > > > > > > > > Signed-off-by: Sebastian Ene > > > > > --- > > > > > arch/arm64/kvm/ptdump.c | 143 ++++++++++++++++++++++++++++++++++++++-- > > > > > 1 file changed, 137 insertions(+), 6 deletions(-) > > > > > > > > > > diff --git a/arch/arm64/kvm/ptdump.c b/arch/arm64/kvm/ptdump.c > > > > > index 36dc7662729f..cc1d4fdddc6e 100644 > > > > > --- a/arch/arm64/kvm/ptdump.c > > > > > +++ b/arch/arm64/kvm/ptdump.c > > > > > @@ -14,6 +14,61 @@ > > > > > #include > > > > > > > > > > > > > > > +#define MARKERS_LEN (2) > > > > > +#define KVM_PGTABLE_MAX_LEVELS (KVM_PGTABLE_LAST_LEVEL + 1) > > > > > + > > > > > +struct kvm_ptdump_guest_state { > > > > > + struct kvm *kvm; > > > > > + struct pg_state parser_state; > > > > > + struct addr_marker ipa_marker[MARKERS_LEN]; > > > > > + struct pg_level level[KVM_PGTABLE_MAX_LEVELS]; > > > > > + struct ptdump_range range[MARKERS_LEN]; > > > > > +}; > > > > > + > > > > > +static const struct prot_bits stage2_pte_bits[] = { > > > > > + { > > > > > + .mask = PTE_VALID, > > > > > + .val = PTE_VALID, > > > > > + .set = " ", > > > > > + .clear = "F", > > > > > + }, { > > > > > + .mask = KVM_PTE_LEAF_ATTR_HI_S2_XN | PTE_VALID, > > > > > + .val = KVM_PTE_LEAF_ATTR_HI_S2_XN | PTE_VALID, > > > > KVM_PTE_LEAF_ATTR_HI_S2_XN is actually a mask covering > > It is not a mask covering here but in the ACK kernel. You're right, I should have double-checked upstream. That said, how about we move this __after__ RW ? and just use "X" on .clear so we can have something R W X ? > > > > > KVM_PTE_LEAF_ATTR_HI_S2_XN_XN, KVM_PTE_LEAF_ATTR_HI_S2_XN_PXN and > > KVM_PTE_LEAF_ATTR_HI_S2_XN_UXN. > > > > I believe here what we should do is something like? > > > > .val = FIELD_PREP_CONST(KVM_PTE_LEAF_ATTR_HI_S2_XN, > > KVM_PTE_LEAF_ATTR_HI_S2_XN_XN) | PTE_VALID > > > > > > > + .set = "XN", > > > > > + .clear = " ", > > > > > + }, { > > > > > + .mask = KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R | PTE_VALID, > > > > > + .val = KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R | PTE_VALID, > > > > > + .set = "R", > > > > > + .clear = " ", > > > > > + }, { > > > > [...]