From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37F92C3DA5D for ; Fri, 19 Jul 2024 14:10:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DPrxOA5Jo5X8ogv77DWTSjqpheBlFxY6lo9/95nhICY=; b=saZgPF/4PFAKD7hpQun/4xYNRW cZ9jhKgg9Z6LjOFh6a0uCF5rZ8KMoYngMg1Aw1np9WngvvbR6JrjHGsipUkCHS39J7j54J1euKXTF Rtb46caGavJ0SKdZ1KIu9Id1ExMT2aGQyYMlu5bw7QmhuM/AX6JjPIf0I6cE5pajTJQYeQSuy06Yn KR6bo7HUttvTDkdkAvQ6YRg+gQ769GQNK7f3ma455BkfQ66Yhcir0xwLnIMfsGBzU3HRNmVfBwP9Z XAVzzfBg4krAr87GeezBPZu9iZenYhbNMVL5/p79Xuf/lCBU//zErxOo8IF4k0mCVWRr3u4B+nZ0e VyrtSK7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUoIr-00000002sfU-3iAh; Fri, 19 Jul 2024 14:09:45 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUoIV-00000002sVk-1MRY for linux-arm-kernel@lists.infradead.org; Fri, 19 Jul 2024 14:09:24 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5a18a5dbb23so12482a12.1 for ; Fri, 19 Jul 2024 07:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721398161; x=1722002961; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DPrxOA5Jo5X8ogv77DWTSjqpheBlFxY6lo9/95nhICY=; b=AZU9hViu2g2NzcdXx10gSOS6tBHcJsHXm0VJPURTB7zvLqeeEPLXmnMutvG7Vltp4s BtsodDIiJ8aB1ks4njhmTZXAMBw1k3Nj8cf22/Wk0e+VbCQty+hHjtTSfKO/i8Q3e4BC DRRsmTbDYHOiLr/WymwlFNks4llTutkRKbMsXXPgEZjCs2dFRlcYc9w6wo+GZ7gZd2KE rfmZfueEQRlz7NZ4SN6J2N0XDNRNxkF8QYZHrexKjc7jisdtu2XjB3hj3X43Q8iekcLL ojJq/Me15Xr6PsoT6koP2yTgUzcz/d6a5MOpgaqYl8/sMJJRsvCiZNdtytKzXdP8pnMw WFXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721398161; x=1722002961; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DPrxOA5Jo5X8ogv77DWTSjqpheBlFxY6lo9/95nhICY=; b=RbrlLdtYP+Q9FqyjLaQHt1M7iqjhoHoHpJCXSulYIzkIak499k/iPBZf5Ajz1qApvo kUpWpyNRPTeWEn5uPbVeEdpKzY/g43kQw4FJfMAbrvhoqs4flJuxMhiRJSJHxhzIDLHg e7zK0sB0otMi9RlOWr15Ccv7SazAgcuxtEKqNsxT/5eOz3KU0Ow4zTIXAXNp6CZVXouR BwKH7b746aJ8xrjS69/HqD0w18B3g3iyFOR1basa9t4/vn+I5l4diyX7uK2azEkDHcd9 e1/mJ9WqTBAUS6W22hchWi7PBRto9sWGys0UZ84/7iTfXEgHYhG3eJWYl26MDCS788wT X8TQ== X-Forwarded-Encrypted: i=1; AJvYcCU4WLOUg6fq6VwSqoAppGlEucZsEmoJ8oN0kESw9SLftl9ml3bdp24tkCzREx7vYqJ7hIISUHn2paK4mhUghqyVYac/aUJa3JUVIZfPNvuLYp1UZ7g= X-Gm-Message-State: AOJu0YyWZ2RsWD4t/uhBXXyOyglGTFvACasxwrjXBQvaIcywTng5Pt4z f3FCPcbvqYsEHJz5S/Yl7GQaJwj5PwKuRsTf4WbYGlx6Q1aBTJ+FdIoxcsFaYQ== X-Google-Smtp-Source: AGHT+IGnXJyyFRlm/DzULfk3KGAkpy7LZO4NL6G+C38+3NI6Cxge1cG7pYzTXj+BCtoveuiX65kSqw== X-Received: by 2002:a05:6402:50c9:b0:57c:c5e2:2c37 with SMTP id 4fb4d7f45d1cf-5a2f262b220mr155977a12.3.1721398160978; Fri, 19 Jul 2024 07:09:20 -0700 (PDT) Received: from google.com (49.222.77.34.bc.googleusercontent.com. [34.77.222.49]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-368786848f9sm1722929f8f.1.2024.07.19.07.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jul 2024 07:09:20 -0700 (PDT) Date: Fri, 19 Jul 2024 14:09:19 +0000 From: Sebastian Ene To: Vincent Donnefort Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, mark.rutland@arm.com, maz@kernel.org, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v7 5/6] KVM: arm64: Initialize the ptdump parser with stage-2 attributes Message-ID: References: <20240621123230.1085265-1-sebastianene@google.com> <20240621123230.1085265-6-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240719_070923_386293_8D08243F X-CRM114-Status: GOOD ( 23.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2024 at 10:59:41AM +0100, Vincent Donnefort wrote: > On Mon, Jul 01, 2024 at 02:18:39PM +0000, Sebastian Ene wrote: > > On Mon, Jul 01, 2024 at 09:42:43AM +0100, Vincent Donnefort wrote: > > > O Fri, Jun 21, 2024 at 12:32:29PM +0000, 'Sebastian Ene' via kernel-team wrote: > > > > Define a set of attributes used by the ptdump parser to display the > > > > properties of a guest memory region covered by a pagetable descriptor. > > > > Build a description of the pagetable levels and initialize the parser > > > > with this configuration. > > > > > > > > Signed-off-by: Sebastian Ene > > > > --- > > > > arch/arm64/kvm/ptdump.c | 143 ++++++++++++++++++++++++++++++++++++++-- > > > > 1 file changed, 137 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/arch/arm64/kvm/ptdump.c b/arch/arm64/kvm/ptdump.c > > > > index 36dc7662729f..cc1d4fdddc6e 100644 > > > > --- a/arch/arm64/kvm/ptdump.c > > > > +++ b/arch/arm64/kvm/ptdump.c > > > > @@ -14,6 +14,61 @@ > > > > #include > > > > > > > > > > > > +#define MARKERS_LEN (2) > > > > +#define KVM_PGTABLE_MAX_LEVELS (KVM_PGTABLE_LAST_LEVEL + 1) > > > > + > > > > +struct kvm_ptdump_guest_state { > > > > + struct kvm *kvm; > > > > + struct pg_state parser_state; > > > > + struct addr_marker ipa_marker[MARKERS_LEN]; > > > > + struct pg_level level[KVM_PGTABLE_MAX_LEVELS]; > > > > + struct ptdump_range range[MARKERS_LEN]; > > > > +}; > > > > + > > > > +static const struct prot_bits stage2_pte_bits[] = { > > > > + { > > > > + .mask = PTE_VALID, > > > > + .val = PTE_VALID, > > > > + .set = " ", > > > > + .clear = "F", > > > > + }, { > > > > + .mask = KVM_PTE_LEAF_ATTR_HI_S2_XN | PTE_VALID, > > > > + .val = KVM_PTE_LEAF_ATTR_HI_S2_XN | PTE_VALID, > > KVM_PTE_LEAF_ATTR_HI_S2_XN is actually a mask covering It is not a mask covering here but in the ACK kernel. > > KVM_PTE_LEAF_ATTR_HI_S2_XN_XN, KVM_PTE_LEAF_ATTR_HI_S2_XN_PXN and > KVM_PTE_LEAF_ATTR_HI_S2_XN_UXN. > > I believe here what we should do is something like? > > .val = FIELD_PREP_CONST(KVM_PTE_LEAF_ATTR_HI_S2_XN, > KVM_PTE_LEAF_ATTR_HI_S2_XN_XN) | PTE_VALID > > > > > + .set = "XN", > > > > + .clear = " ", > > > > + }, { > > > > + .mask = KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R | PTE_VALID, > > > > + .val = KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R | PTE_VALID, > > > > + .set = "R", > > > > + .clear = " ", > > > > + }, { > > [...]