From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A617C3DA7F for ; Sat, 3 Aug 2024 01:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mn6019YORpOIN4p+uI+hS2FuSm00+ndoCRPl9w+srXE=; b=20CcVPjPDeDwvx46vwCyQTBv1x qVC1FcpdJoIZjUfPUrH+uNdKWvHSEhv/m8lphjpStuSzV9KO0u2HQGGPcqYj5f07K44w3/3C2ArV/ ABiQ9uCBNCwVzSBXkXzmAIJSx1CA3Bw5RqiqnQrVMv4PPQE6xqoNT7QnrxLmwpAB6u4BrJWwA1CVL p1U28pqtlyhSFP8Utwg4Kk1zvrHZt3W7hlEn7GTQfFwqz57XgudqQpm8FPpMx+GR7/fmw3d4rws/h 1VtFHZ0d+wQlroYTl82h+1IAiCQn4enmBaM8OoMt5Hahpq71nanQWbH7L0Uruu+927IlOJkqxUNeQ seOywNoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sa3Sg-0000000AV9a-0sPq; Sat, 03 Aug 2024 01:21:34 +0000 Received: from mail-pj1-f52.google.com ([209.85.216.52]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sa3SA-0000000AV3c-2k43 for linux-arm-kernel@lists.infradead.org; Sat, 03 Aug 2024 01:21:04 +0000 Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2cfd1b25aaaso3465890a91.0 for ; Fri, 02 Aug 2024 18:21:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722648061; x=1723252861; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mn6019YORpOIN4p+uI+hS2FuSm00+ndoCRPl9w+srXE=; b=YqA1dUxg9cX8PQyaEBmj0eqvyEZZfgTkiQ9qIAR+6B+bGYGonY8agfMVEtLo+niiNy kqXVKd6K05PWLrNd2S3xC/07wNDo0uXM6hD/+Mf8b5KURgMkUH9WPWvxH13K+xmhhc7H QYjSKQ3Py+enlzWIGnZ5eLNiNTqEw111iboVgs6p7do8SmoeDAm4OjF5Te3Bo61E9oTY zeXBb3+hw4hH8zPcGAv/2HzGzk0pXor2Ce8o76GDK7bNuFzreFQQ2s8qRkTE5ARpZSSz FXJPzCxgVQr7cmFWSoi3YkHzVDwErn8+wCTPOw37fakYQ7+kJoiEFF2WYmvYKE76R6Fu KHRw== X-Forwarded-Encrypted: i=1; AJvYcCV84oqMkUuDUMMdMElpD/IpTPobaBGbi0iGzY01e8Gh8Rkhm5LS5v3aLMwqbP0lZOXLv4liZkTkM7c1SWX3RBbXUm+1zczhTKEaoK2cXBV1abnHz/Q= X-Gm-Message-State: AOJu0YxzEixm0r7acIRB5y9HE8qGjaPqmkW00YA7sskFy4stoxmqiJYb Hmn4sWG9BnAt15kOktsPW+WPuAx/WJAyNvQHFSq7oiefLpyAivnO X-Google-Smtp-Source: AGHT+IGcypEO6f2Pzk3wUXNz0LUEZUBSbjvtENiURYxWYOfgVYejP9sulcneRglr4VAxIUSiI4HadA== X-Received: by 2002:a17:90a:fc92:b0:2c9:6b02:15ca with SMTP id 98e67ed59e1d1-2cff9544e21mr6464426a91.39.1722648061281; Fri, 02 Aug 2024 18:21:01 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([20.69.120.36]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cfca2a2af6sm4671139a91.0.2024.08.02.18.21.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 18:21:00 -0700 (PDT) Date: Sat, 3 Aug 2024 01:20:58 +0000 From: Wei Liu To: Roman Kisel Cc: arnd@arndb.de, bhelgaas@google.com, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, decui@microsoft.com, haiyangz@microsoft.com, hpa@zytor.com, kw@linux.com, kys@microsoft.com, lenb@kernel.org, lpieralisi@kernel.org, mingo@redhat.com, rafael@kernel.org, robh@kernel.org, tglx@linutronix.de, wei.liu@kernel.org, will@kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, apais@microsoft.com, benhill@microsoft.com, ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev Subject: Re: [PATCH v3 7/7] PCI: hv: Get vPCI MSI IRQ domain from DT Message-ID: References: <20240726225910.1912537-1-romank@linux.microsoft.com> <20240726225910.1912537-8-romank@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240726225910.1912537-8-romank@linux.microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240802_182102_720406_CEF390E9 X-CRM114-Status: GOOD ( 31.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 26, 2024 at 03:59:10PM -0700, Roman Kisel wrote: > The hyperv-pci driver uses ACPI for MSI IRQ domain configuration on > arm64. It won't be able to do that in the VTL mode where only DeviceTree > can be used. > > Update the hyperv-pci driver to get vPCI MSI IRQ domain in the DeviceTree > case, too. > > Signed-off-by: Roman Kisel > --- > drivers/hv/vmbus_drv.c | 23 +++++++----- > drivers/pci/controller/pci-hyperv.c | 55 +++++++++++++++++++++++++++-- > include/linux/hyperv.h | 2 ++ > 3 files changed, 69 insertions(+), 11 deletions(-) > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > index 7eee7caff5f6..038bd9be64b7 100644 > --- a/drivers/hv/vmbus_drv.c > +++ b/drivers/hv/vmbus_drv.c > @@ -45,7 +45,8 @@ struct vmbus_dynid { > struct hv_vmbus_device_id id; > }; > > -static struct device *hv_dev; > +/* VMBus Root Device */ > +static struct device *vmbus_root_device; You're changing the name of the variable. That should preferably be done in a separate patch. That's going to make this patch shorter and easier to review. > > static int hyperv_cpuhp_online; > > @@ -80,9 +81,15 @@ static struct resource *fb_mmio; > static struct resource *hyperv_mmio; > static DEFINE_MUTEX(hyperv_mmio_lock); > > +struct device *get_vmbus_root_device(void) > +{ > + return vmbus_root_device; > +} > +EXPORT_SYMBOL_GPL(get_vmbus_root_device); I would like you to add "hv_" prefix to this exported symbol, or rename it to "vmbus_get_root_device()". > + > static int vmbus_exists(void) > { > - if (hv_dev == NULL) > + if (vmbus_root_device == NULL) > return -ENODEV; > > return 0; > @@ -861,7 +868,7 @@ static int vmbus_dma_configure(struct device *child_device) > * On x86/x64 coherence is assumed and these calls have no effect. > */ > hv_setup_dma_ops(child_device, > - device_get_dma_attr(hv_dev) == DEV_DMA_COHERENT); > + device_get_dma_attr(vmbus_root_device) == DEV_DMA_COHERENT); > return 0; > } > > @@ -1892,7 +1899,7 @@ int vmbus_device_register(struct hv_device *child_device_obj) > &child_device_obj->channel->offermsg.offer.if_instance); > > child_device_obj->device.bus = &hv_bus; > - child_device_obj->device.parent = hv_dev; > + child_device_obj->device.parent = vmbus_root_device; > child_device_obj->device.release = vmbus_device_release; > > child_device_obj->device.dma_parms = &child_device_obj->dma_parms; > @@ -2253,7 +2260,7 @@ static int vmbus_acpi_add(struct platform_device *pdev) > struct acpi_device *ancestor; > struct acpi_device *device = ACPI_COMPANION(&pdev->dev); > > - hv_dev = &device->dev; > + vmbus_root_device = &device->dev; > > /* > * Older versions of Hyper-V for ARM64 fail to include the _CCA > @@ -2342,7 +2349,7 @@ static int vmbus_device_add(struct platform_device *pdev) > struct device_node *np = pdev->dev.of_node; > int ret; > > - hv_dev = &pdev->dev; > + vmbus_root_device = &pdev->dev; > > ret = of_range_parser_init(&parser, np); > if (ret) > @@ -2675,7 +2682,7 @@ static int __init hv_acpi_init(void) > if (ret) > return ret; > > - if (!hv_dev) { > + if (!vmbus_root_device) { > ret = -ENODEV; > goto cleanup; > } > @@ -2706,7 +2713,7 @@ static int __init hv_acpi_init(void) > > cleanup: > platform_driver_unregister(&vmbus_platform_driver); > - hv_dev = NULL; > + vmbus_root_device = NULL; > return ret; > } > > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c > index 5992280e8110..cdecefd1f9bd 100644 > --- a/drivers/pci/controller/pci-hyperv.c > +++ b/drivers/pci/controller/pci-hyperv.c > @@ -50,6 +50,7 @@ > #include > #include > #include > +#include > #include > > /* > @@ -887,6 +888,35 @@ static const struct irq_domain_ops hv_pci_domain_ops = { > .activate = hv_pci_vec_irq_domain_activate, > }; > > +#ifdef CONFIG_OF > + > +static struct irq_domain *hv_pci_of_irq_domain_parent(void) > +{ > + struct device_node *parent; > + struct irq_domain *domain; > + > + parent = of_irq_find_parent(to_platform_device(get_vmbus_root_device())->dev.of_node); > + domain = NULL; > + if (parent) { > + domain = irq_find_host(parent); > + of_node_put(parent); > + } > + I cannot really comment on the ARM side of things around how this system is set up. I will leave that to someone who's more familiar with the matter to review. Thanks, Wei.