From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D515C3DA4A for ; Sat, 3 Aug 2024 10:58:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=STiqmEzmdadRjckUvk86FbHYxNLG10L107+hHwZayc0=; b=a1TbdZ8h97sffNC/OWa+19zAQ2 D8Bc8lXNvofEJKHYmizlEFoc4/pmb3cy6d6yaQUPz714pVssm6K8mGWN7fJUVRqm9T9+AJpC6jnJm fqkNUuZmbFiMPZKG1+0Z91mfSZFBFRHuDAkBO2ceOvTrGMGE4uumP1gvvln7ii/yn/g8vRgk7+Slb CjZtl0m+4ldooMWx7NPGshaBUtJdqhEysjpGKM3F3ML7ciiMuikgS6jnt1LndwnkGBQ5km5XpY+Wt kPLRE8cnjWD+jY/rFS2iph8WetlZGI6UXrXPwKlBJIdPxqFTVn0b+mKxrQLcBZ/WQGHVcwGfGWnNT zFToetKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1saCSx-0000000BFCS-42js; Sat, 03 Aug 2024 10:58:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1saCSS-0000000BF4L-03pY for linux-arm-kernel@lists.infradead.org; Sat, 03 Aug 2024 10:57:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0B91EDA7; Sat, 3 Aug 2024 03:58:21 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6BC8C3F64C; Sat, 3 Aug 2024 03:57:54 -0700 (PDT) Date: Sat, 3 Aug 2024 11:57:51 +0100 From: Mark Rutland To: Luca Fancellu Cc: "linux-arm-kernel@lists.infradead.org" , Akos Denke , Andre Przywara , "maz@kernel.org" Subject: Re: [BOOT-WRAPPER 11/11] Boot CPUs sequentially Message-ID: References: <20240729161501.1806271-1-mark.rutland@arm.com> <20240729161501.1806271-12-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240803_035756_117763_1373E6CB X-CRM114-Status: GOOD ( 17.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 31, 2024 at 10:57:34AM +0100, Luca Fancellu wrote: > Hi Mark, > > > diff --git a/arch/aarch64/init.c b/arch/aarch64/init.c > > index 68c220b..81fe33a 100644 > > --- a/arch/aarch64/init.c > > +++ b/arch/aarch64/init.c > > @@ -6,6 +6,7 @@ > > * Use of this source code is governed by a BSD-style license that can be > > * found in the LICENSE.txt file. > > */ > > +#include > > #include > > #include > > #include > > @@ -159,24 +160,28 @@ static void cpu_init_el3(void) > > #ifdef PSCI > > extern char psci_vectors[]; > > > > -bool cpu_init_psci_arch(void) > > +static void cpu_init_psci_arch(unsigned int cpu) > > { > > - if (mrs(CurrentEL) != CURRENTEL_EL3) > > - return false; > > + if (mrs(CurrentEL) != CURRENTEL_EL3) { > > + print_cpu_warn(cpu, "PSCI could not be initialized (not booted at EL3).\r\n"); > > + return; > > + } > > > > msr(VBAR_EL3, (unsigned long)psci_vectors); > > isb(); > > - > > - return true; > > } > > +#else > > +static void cpu_init_psci_arch(unsigned int cpu); > > This needs {} otherwise I’m getting: > > | aarch64-poky-linux-ld: arch/aarch64/init.o: in function `cpu_init_arch’: > | /usr/src/debug/boot-wrapper-aarch64/gitAUTOINC+cd7fe8a88e-r0/arch/aarch64/init.c:246: undefined reference to `cpu_init_psci_arch’ > | aarch64-poky-linux-ld: /usr/src/debug/boot-wrapper-aarch64/gitAUTOINC+cd7fe8a88e-r0/arch/aarch64/init.c:246: undefined reference to `cpu_init_psci_arch’ > > When compiling without PSCI. Whoops; I've fixed that up locally. Thanks for the report. Mark.