From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 956F4C52D6D for ; Sat, 3 Aug 2024 11:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EouJaz57SDUqSx3IiHpCarnkKIu7a3frgx49cv8hGQ8=; b=atNkp3zu9kg2CTskQaBe+UABTL jjcIyGFpbvqapCG2GO3InIRegFd6hUI/vzyRmXMTzIQZPKAnLNmCquFlwTSaqSQJhUpk4QzEMMbcG zZq7T4B+JESnIX6k1R2S6g0OVKxgkS6QgI1bNCK5eHe3XccfC2CeQEYcxR1O2Lnl+P6FrUavlnd4q Vyu58k/SgIdSo2ldtw1gF+8+kXJw8eSQcPSrGC/MoS/NZEv+j4oir3XXyGNE4sljPyAQWA81h5nL/ Gx7tBh/7le/XSjjBOCCMnzZKZTv/DvCrt05f17KixrJA4Ze8wN1GDomPFCozGoy7wZRDVmyCNDuru BcG/Hlrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1saCZX-0000000BGwk-3l6s; Sat, 03 Aug 2024 11:05:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1saCWa-0000000BGLT-2beL for linux-arm-kernel@lists.infradead.org; Sat, 03 Aug 2024 11:02:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 582E2DA7; Sat, 3 Aug 2024 04:02:37 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D6A993F64C; Sat, 3 Aug 2024 04:02:10 -0700 (PDT) Date: Sat, 3 Aug 2024 12:02:08 +0100 From: Mark Rutland To: "Rob Herring (Arm)" Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf: arm_pmu: Use of_property_present() Message-ID: References: <20240731191312.1710417-15-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240731191312.1710417-15-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240803_040212_723830_C41709CD X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 31, 2024 at 01:12:53PM -0600, Rob Herring (Arm) wrote: > Use of_property_present() to test for property presence rather than > of_find_property(). This is part of a larger effort to remove callers > of of_find_property() and similar functions. of_find_property() leaks > the DT struct property and data pointers which is a problem for > dynamically allocated nodes which may be freed. > > Signed-off-by: Rob Herring (Arm) Acked-by: Mark Rutland I assume Will will pick this up. Mark. > --- > drivers/perf/arm_pmu_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/arm_pmu_platform.c b/drivers/perf/arm_pmu_platform.c > index 4b1a9a92ea11..118170a5cede 100644 > --- a/drivers/perf/arm_pmu_platform.c > +++ b/drivers/perf/arm_pmu_platform.c > @@ -59,7 +59,7 @@ static int pmu_parse_percpu_irq(struct arm_pmu *pmu, int irq) > > static bool pmu_has_irq_affinity(struct device_node *node) > { > - return !!of_find_property(node, "interrupt-affinity", NULL); > + return of_property_present(node, "interrupt-affinity"); > } > > static int pmu_parse_irq_affinity(struct device *dev, int i) > -- > 2.43.0 >