From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87CC6C3DA63 for ; Wed, 24 Jul 2024 14:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wvFTt7b0WXLWfdxmaWrJdNjsaAPYjbn1EkQtlcx+OVs=; b=OmuimTboGJSAqVW/1ecNOExKsv M4HPd2fKRdPVWvbOFceNtjtSCChRu7/6sYIgQGBusP6KRF3D9lx3dIs2GHYrTTYaHBZRQJQ3gJA73 0qoNsV1J3C9lVC2qiaZNlnvWaNp/pMmdPX4zku7HK1xp1MXCZTFK7wsBaLx5NzwuhPWEum/Q+sCJM 8+tnV0W80a49Ac5udnbDx8WGlcHGd1F8+52sM6LP3jVgkactprjvZPZfQ08kZpQ62lktIKsOmGRhk DJxa6xhKXJrOHTLeE5qpXn9Jpte9nsGr/ppct0wx3oFklQ92OhZelrVF8gs8eB/560+VNBsQpXG5l DVmtTNjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWcsW-0000000FZcp-0hmj; Wed, 24 Jul 2024 14:22:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWcs6-0000000FZUJ-1vFO for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2024 14:21:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 75E9A106F; Wed, 24 Jul 2024 07:22:01 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB2E63F5A1; Wed, 24 Jul 2024 07:21:34 -0700 (PDT) Date: Wed, 24 Jul 2024 15:21:31 +0100 From: Cristian Marussi To: Luke Parkin Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, cristian.marussi@arm.com Subject: Re: [PATCH v3 3/5] firmware: arm_scmi: Track basic SCMI statistics Message-ID: References: <20240715133751.2877197-1-luke.parkin@arm.com> <20240715133751.2877197-4-luke.parkin@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240715133751.2877197-4-luke.parkin@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_072138_699376_2CB2B987 X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 15, 2024 at 02:37:49PM +0100, Luke Parkin wrote: > Add tracking of initial statistics > > Signed-off-by: Luke Parkin > --- > V2->V3 > Add more statistics > Use new log_stats method. > V1->V2 > Drop unneccesary atomic_set's > Use new 'scmi_log_stats' to simplify incrementing of atomics > Move scmi_log_stats to locations which mean no extra conditionals > are needed > --- > drivers/firmware/arm_scmi/driver.c | 39 ++++++++++++++++++++++++++---- > 1 file changed, 34 insertions(+), 5 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 6edec6ec912d..b22f104cda36 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -126,6 +126,20 @@ struct scmi_debug_info { > }; > > enum debug_stat_counters { > + SENT_OK, > + SENT_FAIL, > + SENT_FAIL_POLLING_UNSUPPORTED, > + SENT_FAIL_CHANNEL_NOT_FOUND, > + RESPONSE_OK, > + NOTIF_OK, > + DLYD_RESPONSE_OK, > + XFERS_RESPONSE_TIMEOUT, > + XFERS_RESPONSE_POLLED_TIMEOUT, > + RESPONSE_POLLED_OK, > + ERR_MSG_UNEXPECTED, > + ERR_MSG_INVALID, > + ERR_MSG_NOMEM, > + ERR_PROTOCOL, > LAST > }; > > @@ -994,6 +1008,7 @@ scmi_xfer_command_acquire(struct scmi_chan_info *cinfo, u32 msg_hdr) > spin_unlock_irqrestore(&minfo->xfer_lock, flags); > > scmi_bad_message_trace(cinfo, msg_hdr, MSG_UNEXPECTED); > + scmi_log_stats(info->dbg_stats, ERR_MSG_UNEXPECTED); I'd be tempted to say why dont you wrap these scmi_log_stats() inside the scmi_bad_message_trace() ... BUT in order to avoid an additional conditional inside the scmi_bad_message_trace() you will need to somehow remap the MSG_UNEXPECTED to ERR_MSG_UNEXPECTED inside scmi_bad_message_trace (lets say with a local onstack array indexed by -err)...AND that would mean committing to keep such mapping in-sync with the the above enum, so as to avoid that adding a new definition into scmi_bad_msg BUT not to debug_stat_counters will end up in a buffer overflow....so at the end probably better/safer to keep it this way... Thanks, Cristian