From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E207C3DA61 for ; Wed, 24 Jul 2024 14:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bXpiJqYnCsdFdPuWGBBOeUtdF24CVsil3jdtB0FSEZ0=; b=zKb+P4bNXAM6UYXm2jLycVQsyM ehIkqdw51Lb9Y3Qte8dTepYslYrC1tE3PF9EWhjyNSNl0mx/kexXvWilUvJ+89N9UlMerDndks0BE yXy7d0w8XgTNuh1w2ETmcbBUcYVlZFYt7M6YT8rmL+675OsCsE73jqdgqRaOfE/gm+kISl1FW48Vr QsIfNUn2Zj9FW4Sqo6bZjyiTPvOgcoCCGTLVdZgMammIQ701t308LlmWWsBcbE5s2/sZLvlWLgl7C iPDXBT/2Qu8nxnElWEuoUDXWC9rMPRA8xBnJ5xhbWIN5ylRWXJcrHrDpJC+BNGp3sSbIEGMUVnF2C du7BUpKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWcvb-0000000FaDe-3JUK; Wed, 24 Jul 2024 14:25:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWcvA-0000000Fa8G-2TPI for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2024 14:24:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7D3A7106F; Wed, 24 Jul 2024 07:25:11 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 925F73F5A1; Wed, 24 Jul 2024 07:24:44 -0700 (PDT) Date: Wed, 24 Jul 2024 15:24:41 +0100 From: Cristian Marussi To: Luke Parkin Cc: Peng Fan , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "arm-scmi@vger.kernel.org" , "sudeep.holla@arm.com" , "cristian.marussi@arm.com" Subject: Re: [PATCH v3 3/5] firmware: arm_scmi: Track basic SCMI statistics Message-ID: References: <20240715133751.2877197-1-luke.parkin@arm.com> <20240715133751.2877197-4-luke.parkin@arm.com> <57e6bded-8d10-4db8-ad2e-11dfd126205f@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57e6bded-8d10-4db8-ad2e-11dfd126205f@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_072448_702835_105ABE21 X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 22, 2024 at 01:21:31PM +0100, Luke Parkin wrote: > > Just wonder that since ftrace is there, why need this? > > Hi, this series aims to provide a useful debug aid for running tests on the SCMI > subsystem. As you mentioned, ftrace does report some of these statistics, > however DEBUG_STATISTICS will allow a programatic interface to access the count > of failures, successes and an extended variety of other specific > errors/statistics for automated (or manual) testing. > > Hope this clears things up, > Luke Yes, the idea was to have some continuosuly running counters that can be looked up (when compiled-in, NOT in production) to check for anomalies...ftrace are certainly more detailed in these regards BUT you have to enable them at runtime and then dig into the log, and moreover do not cover all of the cases like these stats... Thanks, Cristian