From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3791AC3DA61 for ; Wed, 24 Jul 2024 14:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1FlDCQp6sgAJ/WyGO/YoVSJV7jvEJveCwD8uXgaDyp0=; b=GYa7MC2bgRNbqekS3cQnCIdB7q LwrQYgkJhPPKhvF7hSRmL/K7HuW7AX6EzruR7Zfy0KDVYUzEltE3SXM5JIkUw1qSbNCLSXVXZpbgo 9Y5AbJ25k58vNmUmrGZy8DhcJzPwHKMrv0SyZ7sjf3xOnH4d55yf0TVVZwfI4v9WE7xREKpdQzi5b /faFwWY+Dw8ebPPiHJsoT93CeGsriB673FSj6olI0CVaPwaCWegVWCOo4OdVW7DrI1A6IHON2GFRN XKSU3XXrnpoMlY6XQU3soeGlCy8iCBN1DYcbTFx8z0/Uz5N+M21maZuuMmcwqJwsTEBnpJSkKNAVC rl6B1JWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWcx9-0000000FaR4-1RGP; Wed, 24 Jul 2024 14:26:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWcwk-0000000FaMa-2o7S for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2024 14:26:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E53E8106F; Wed, 24 Jul 2024 07:26:50 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C0743F5A1; Wed, 24 Jul 2024 07:26:23 -0700 (PDT) Date: Wed, 24 Jul 2024 15:26:21 +0100 From: Cristian Marussi To: Luke Parkin Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, cristian.marussi@arm.com Subject: Re: [PATCH v3 4/5] firmware: arm_scmi: Create debugfs files for statistics Message-ID: References: <20240715133751.2877197-1-luke.parkin@arm.com> <20240715133751.2877197-5-luke.parkin@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240715133751.2877197-5-luke.parkin@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_072626_820813_E6F253B5 X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 15, 2024 at 02:37:50PM +0100, Luke Parkin wrote: > Create debugfs files for the statistics in the scmi_debug_stats struct > > Signed-off-by: Luke Parkin Here you missed the seprator --- before the changelog...so this will go into the final commit. Thanks, Cristian > v2->v3 > Add extra statistics also added in v3 > v1->v2 > Only create stats pointer if stats are enabled > Move stats debugfs creation into a seperate helper function > --- > drivers/firmware/arm_scmi/driver.c | 38 ++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index b22f104cda36..9378e2d8af4f 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -2865,6 +2865,41 @@ static int scmi_device_request_notifier(struct notifier_block *nb, > return NOTIFY_OK; > } > > +static void scmi_debugfs_stats_setup(struct scmi_info *info, > + struct dentry *trans) > +{ > + struct dentry *stats; > + > + stats = debugfs_create_dir("stats", trans); > + > + debugfs_create_atomic_t("sent_ok", 0400, stats, > + &info->dbg_stats[SENT_OK]); > + debugfs_create_atomic_t("sent_fail", 0400, stats, > + &info->dbg_stats[SENT_FAIL]); > + debugfs_create_atomic_t("sent_fail_polling_unsupported", 0400, stats, > + &info->dbg_stats[SENT_FAIL_POLLING_UNSUPPORTED]); > + debugfs_create_atomic_t("sent_fail_channel_not_found", 0400, stats, > + &info->dbg_stats[SENT_FAIL_CHANNEL_NOT_FOUND]); > + debugfs_create_atomic_t("response_ok", 0400, stats, > + &info->dbg_stats[RESPONSE_OK]); > + debugfs_create_atomic_t("notif_ok", 0400, stats, > + &info->dbg_stats[NOTIF_OK]); > + debugfs_create_atomic_t("dlyd_resp_ok", 0400, stats, > + &info->dbg_stats[DLYD_RESPONSE_OK]); > + debugfs_create_atomic_t("xfers_resp_timeout", 0400, stats, > + &info->dbg_stats[XFERS_RESPONSE_TIMEOUT]); > + debugfs_create_atomic_t("response_polled_ok", 0400, stats, > + &info->dbg_stats[RESPONSE_POLLED_OK]); > + debugfs_create_atomic_t("err_msg_unexpected", 0400, stats, > + &info->dbg_stats[ERR_MSG_UNEXPECTED]); > + debugfs_create_atomic_t("err_msg_invalid", 0400, stats, > + &info->dbg_stats[ERR_MSG_INVALID]); > + debugfs_create_atomic_t("err_msg_nomem", 0400, stats, > + &info->dbg_stats[ERR_MSG_NOMEM]); > + debugfs_create_atomic_t("err_protocol", 0400, stats, > + &info->dbg_stats[ERR_PROTOCOL]); > +} > + > static void scmi_debugfs_common_cleanup(void *d) > { > struct scmi_debug_info *dbg = d; > @@ -2931,6 +2966,9 @@ static struct scmi_debug_info *scmi_debugfs_common_setup(struct scmi_info *info) > debugfs_create_u32("rx_max_msg", 0400, trans, > (u32 *)&info->rx_minfo.max_msg); > > + if (IS_ENABLED(CONFIG_ARM_SCMI_DEBUG_STATISTICS)) > + scmi_debugfs_stats_setup(info, trans); > + > dbg->top_dentry = top_dentry; > > if (devm_add_action_or_reset(info->dev, > -- > 2.34.1 > >