From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B3E7C3DA63 for ; Wed, 24 Jul 2024 14:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q4Y8Hn9KJVdURVcwkjwEj6P1AyRYZiutQbV/3kie+94=; b=0T2bENS5qN/M5/l9040kaCx3o0 t+cYQDsdIos5ZE0As4jHhPpKiUdrzPfT50O6iaNlmtpkpyW8yeSVHZ3lUF72egfSqqYAjaQPj7O+J z4nO2BDtrmVLjclzx0k5m/J5Zpx7mtkTpeoI8AnxV6qJaH+qZmn3/NRcDO48Z5JBC64lJw4ii2bWd Oj9X/w05XHTIrGCg0XpuHhI6IRRLExamPPvuN0Hu/cIlD5LEJtBFMoa48DG0tdEUiZky4JJQjuNhC lAVcFr7ySpJXmxnbKwZUefC4zLVjwxPI3De6XcJGhFb0wej3Clh7XT3oz9vPQQ/JDyivKDcJ0uMOQ iU3bcA5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWdGK-0000000FejR-2KaM; Wed, 24 Jul 2024 14:46:40 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWdFq-0000000FeZj-3wsy for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2024 14:46:12 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A07B3106F; Wed, 24 Jul 2024 07:46:35 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C98F23F73F; Wed, 24 Jul 2024 07:46:08 -0700 (PDT) Date: Wed, 24 Jul 2024 15:46:05 +0100 From: Cristian Marussi To: Luke Parkin Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, cristian.marussi@arm.com Subject: Re: [PATCH v3 0/5] Add Per-transport SCMI debug statistics Message-ID: References: <20240715133751.2877197-1-luke.parkin@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240715133751.2877197-1-luke.parkin@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_074611_040621_23EB384B X-CRM114-Status: GOOD ( 12.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 15, 2024 at 02:37:46PM +0100, Luke Parkin wrote: > This series adds support for tracking Arm SCMI statistics [Patch 2/3] > A config option to enable this [Patch 2] > Cleans up a unneeded call to handle_scmi_info [Patch 1] > In [Patch 4] a selection of new debugfs entries to present these statistics > Then finally in [Patch 5] enabled writing on the debugfs entries to reset stats > > Based on v6.9, Tested on Arm Juno [1] > > Thanks, > Luke Beside the specific patch review comments, I have been just reminded by ATG that using SCMI stats is a bit ambigous since there are statistics in the protocol...so please in v4 take care to rename all the code/commmemts and commit msg to something else ... that could be... "counters" ? instead of stats...so you will have debug counters available under transport/counters instead of /stats....etc etc Thanks, Cristian