From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32D1AC3DA63 for ; Wed, 24 Jul 2024 18:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7WCpmXa82zyOZ922g0iRuHBkONYRB7p6kOaLY9TSJIg=; b=IVV3jDu0sx9n+YmT85AC73VQiv qDOlngqMazCyWCbjLX7IkPFLHcwOYMv3iwsRsEdHa2OVeC2qwuXeV+Yy+6UIQZCkUIrcZ/eHXgUcx 9KPrXl5GPAD3DoBVpuN1tzorW2qDzx5RWDawwBk7bPdIn1YQrapwJAxPc/yWiyYfU9PD61Y5kuhPB YJLM2reZ/3SGIAtmIGb5IQVVEWsml0KhU6eFBwbWgjx9D3cYOUd2EjyfN7/qXTy9RCLahM04kJ4+f 6dxpcr3kJXIIi8CnUv4gFN2oVw00AUhzUPoGNm1Li7WsuFjNktF0w/Rp/YIhvlXR6q6iU3wBbP3G2 hBK2s1ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWgcf-0000000GBlx-1CkC; Wed, 24 Jul 2024 18:21:57 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWgcG-0000000GBiH-2wpp for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2024 18:21:34 +0000 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-70d399da0b5so75166b3a.3 for ; Wed, 24 Jul 2024 11:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721845291; x=1722450091; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7WCpmXa82zyOZ922g0iRuHBkONYRB7p6kOaLY9TSJIg=; b=az6IRLxybp2O8lBrlRYaCQ2Gos0JilF++xEU7VYqWldPP0cozA6t3IyHYHAw7h/l6V EN7VN9/ofOK76s3tI/6ApWy2QMqHDXY0T35NYUrT0NSjWs/PaSC4igvTbXahDzvTYpMo bpVhKxX08SdZuBeEQmD/wZ/WOcn8AmdabfCbRaDqqpHNohzLqZOhqTr1F1ss/xYQVakl WWstkmOfFic6FcLWNQaS9HcMgEE5rZ6Y7/8htqA1EOBwxLHe0nGC3qopgUNFzOTPKygF gjXbUWsNFgvgqfa2M0J2zs2vRUYVcYGrT2BQbvKwR7NK8sjLHzEttpxQyGRcq2+Lf0NJ wtpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721845291; x=1722450091; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7WCpmXa82zyOZ922g0iRuHBkONYRB7p6kOaLY9TSJIg=; b=Y24hlhRJ1fLAKLb80K02G1nFGgHgde+89aoWtraqzE/Z55pcdtPZgVnf7hk3Hbh8AZ DKGUKe0s8/jIaD14KdTppBn2/byYMdyRlJXdMBuAtwYx7dZB/L3okHEARIPIRwTwlTrP haAOLMNoRp8mVFYSjtmOu9SUhzCuuRug7Zrzqo08lEiju3BemYh/wpjYc84KH51LL4kZ MZMvvBOxYocSrLowIMn7xbQXxdWf9tj9ZTuj2Hw4Dii910sCBpf6wLh3mvyqpyqs3suC b3GhUqM9Zav8cB7f4sQEE8ISGJ9kqbApsESuLhorM/tGZPmtVZPkyXDYM2N3QWN5gGp8 HLAQ== X-Forwarded-Encrypted: i=1; AJvYcCXvkeqaAxBn9BTKRArrJvkSkUy8DndW3LvcIRXoMRZmcA4HDHDG0Mi8nwNE+z46lKwwxhBeyosiBsNqJOFK1kMt3RbIMi0xyVcxetmpqMQhAU3pzCA= X-Gm-Message-State: AOJu0Yz4lugMpZEXkCkygt6H5LI/CqCZP5AOSjcDJ9aqMbAi7pt6OZln w6k9pMwOUPcOnqnUsHq2fAsyVLr5zP5RzpiEiwtHLsbnHyq4TUAH X-Google-Smtp-Source: AGHT+IHbXJnA2o0kEdtq8KjKxSCdIUUIOh5dEi8uNKi3kPgDUGk1zRWNY81M+lRRC8/X2Nrwwr7hGg== X-Received: by 2002:a05:6a00:6f61:b0:707:ffa4:de3f with SMTP id d2e1a72fcca58-70eaa8c59a2mr414328b3a.17.1721845291027; Wed, 24 Jul 2024 11:21:31 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:c2d6:b5c3:537e:3830]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70d1a09df58sm6258957b3a.112.2024.07.24.11.21.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 11:21:30 -0700 (PDT) Date: Wed, 24 Jul 2024 11:21:27 -0700 From: Dmitry Torokhov To: Frank Li Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Nitin Garg , Abel Vesa , "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." , "open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , open list Subject: Re: [PATCH v2 1/1] input: imx_sc_key: Enable wakeup according to dts property wakeup-source Message-ID: References: <20240719152259.760457-1-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240719152259.760457-1-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_112132_766278_231297A8 X-CRM114-Status: GOOD ( 19.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frank, On Fri, Jul 19, 2024 at 11:22:58AM -0400, Frank Li wrote: > From: Abel Vesa > > Enable default wakeup according to dts property 'wakeup-source'. > > Signed-off-by: Abel Vesa > Reviewed-by: Nitin Garg > Signed-off-by: Frank Li > --- > Change from v1 to v2 > - change int to bool > - move of_property_read_bool() just before device_init_wakeup() > - drop !! > --- > drivers/input/keyboard/imx_sc_key.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/input/keyboard/imx_sc_key.c b/drivers/input/keyboard/imx_sc_key.c > index d18839f1f4f60..fc1492088b645 100644 > --- a/drivers/input/keyboard/imx_sc_key.c > +++ b/drivers/input/keyboard/imx_sc_key.c > @@ -110,8 +110,10 @@ static void imx_sc_key_action(void *data) > > static int imx_sc_key_probe(struct platform_device *pdev) > { > + struct device_node *np = pdev->dev.of_node; > struct imx_key_drv_data *priv; > struct input_dev *input; > + bool wakeup; > int error; > > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > @@ -151,6 +153,9 @@ static int imx_sc_key_probe(struct platform_device *pdev) > priv->input = input; > platform_set_drvdata(pdev, priv); > > + wakeup = of_property_read_bool(np, "wakeup-source"); The driver uses generic device properties, why do you use OF-specific variant here? > + device_init_wakeup(&pdev->dev, wakeup); > + How does this actually work? Doesn't the call directly below unconditionally configures button as a wakeup source? > error = imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE, SC_IRQ_BUTTON, > true); > if (error) { Thanks. -- Dmitry