From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C94BC3DA5D for ; Thu, 25 Jul 2024 15:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mB7RDGJP+V2z7iYc0eLSsUomYnSG75kC6TcuY0knlE0=; b=th9CqbBBx+ok25F0PSBumSAOsp NJsV5DF8HPFdJr363iUqtkvA7U5TXQim7X1ekHbHEpIhfSuVw5tRQtNQzGRVf/f1HCwrulLbJKMsS +3JLceG6LECh0K4z3yXXxrTlmH8AzbVdCyjK3g5hRKrUu6XJVkvRfUhwcVM3OhZ5XH1EfuPsYi6Cq JtpOICamLYZBiwdwKmjGzWPNwwnsvAeQ5hjF862slKooldRrR6fClR65FwTLJxbTqaxFLhxVK8vFP B05igsgvvm/Yl4/4IjUmVSEq0ZEIeZ8BJuI0+S8TSopgSYZbl1JO0tPJtm2ykA/qh9fB4VR8gLGHE HZKQookA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sX0iP-00000001TLQ-14Xj; Thu, 25 Jul 2024 15:49:13 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sX0i0-00000001TG2-3fiC for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2024 15:48:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78FD21476; Thu, 25 Jul 2024 08:49:13 -0700 (PDT) Received: from e133380.arm.com (e133380.arm.com [10.1.197.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FA393F766; Thu, 25 Jul 2024 08:48:44 -0700 (PDT) Date: Thu, 25 Jul 2024 16:48:41 +0100 From: Dave Martin To: Anshuman Khandual Cc: Joey Gouly , linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 19/29] arm64: enable PKEY support for CPUs with S1POE Message-ID: References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-20-joey.gouly@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240725_084848_976777_86286A71 X-CRM114-Status: GOOD ( 19.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2024 at 04:17:12PM +0530, Anshuman Khandual wrote: > > > On 5/3/24 18:31, Joey Gouly wrote: > > Now that PKEYs support has been implemented, enable it for CPUs that > > support S1POE. > > > > Signed-off-by: Joey Gouly > > Cc: Catalin Marinas > > Cc: Will Deacon > > Acked-by: Catalin Marinas > > Reviewed-by: Anshuman Khandual > > > --- > > arch/arm64/include/asm/pkeys.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/include/asm/pkeys.h b/arch/arm64/include/asm/pkeys.h > > index a284508a4d02..3ea928ec94c0 100644 > > --- a/arch/arm64/include/asm/pkeys.h > > +++ b/arch/arm64/include/asm/pkeys.h > > @@ -17,7 +17,7 @@ int arch_set_user_pkey_access(struct task_struct *tsk, int pkey, > > > > static inline bool arch_pkeys_enabled(void) > > { > > - return false; > > + return system_supports_poe(); > > } > > > > static inline int vma_pkey(struct vm_area_struct *vma) > > Small nit. Would it better to be consistently using system_supports_poe() > helper rather than arch_pkeys_enabled() inside arch/arm64/ platform code > like - during POE fault handling i.e inside fault_from_pkey(). > (FWIW, arch_pkeys_enabled() looks like the hook for the arch to tell the pkeys generic code whether the arch support is there, so I guess the proposed change looks sensible to me. For the arch backend code that is agnostic to whether pkeys is actually in use, system_supports_poe() seems to be the more appropriate check.) Cheers ---Dave