From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50BD2C3DA49 for ; Fri, 26 Jul 2024 14:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4+OKcebUTzwEYDRKpe89RGalLrvCv+aySupvUj2PfYc=; b=gXcCzQtjL613fjfTTjL6q0HY2h 5oiXqLJOm7M9nLNbmntbgYQc532QPnsHYIdOStDJP6LettEcbT3sUjzncc7J2HyXAmxUaOaH5OZGE qv8zb94FD0+cAym9X1LiuZ+8CaHGhrhU5y+Khx2lgQQpbjJ6Ei+xZQ3eoaSjkSRMsPaj360sY9Mig FsE0fxROuplfcPLSPzyFm0JKLJMbttbcdrzJsvEskp9HZb7+OhXrcgUGmZH1ZpPj2HtnpxHkM22nP rIJ0/0cf2PBU4OPhwQ4roXXDMcAEMji54siQ7qY2HslVL20GCtHF3kV45M5/yU3y4OpYeEQh74e8m MeSvsLoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXM2r-000000049tT-3ADp; Fri, 26 Jul 2024 14:35:45 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXM2R-000000049oP-3Gh5 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2024 14:35:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DE13F616AE; Fri, 26 Jul 2024 14:35:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 416A1C4AF07; Fri, 26 Jul 2024 14:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722004518; bh=MCyLCmJ5ASG1+9SW/Nyj3XNaNWYtfUuNic9tED0Aahg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X5F45JHdnjm8t5TeQn45HlnxjEZLAjtqI2pUkpe7I0FmRd097w1cwUaS2JmoS0tVW WM5rTF0xl4wmnT8tvVRRv9+za6LjkSnw/4MbqD4pu7pPCjN8oQLVUeavZv19HFnkq7 5e2qmH2C/C9ckR5c3BOLNjP9HS+9RmjKmds7zZu2es9xzZsjQczVhadhY44kg+9E4c kkz/+biYCDBpBntuLO1WvIR64xNatV72IlmBWC4hzGvYeagSMiAIc8hqyrZIl41FrU KmJ8zRIBHyua2O1YvViP/1OvrwFgt80O6Z7J+EYJqhQLTVivNcgS19wtPItfdVK2tZ vFQV25XafX+Gg== Date: Fri, 26 Jul 2024 11:35:15 -0300 From: Arnaldo Carvalho de Melo To: Mike Leach Cc: James Clark , coresight@lists.linaro.org, gankulkarni@os.amperecomputing.com, leo.yan@arm.com, suzuki.poulose@arm.com, John Garry , Will Deacon , James Clark , Leo Yan , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] perf cs-etm: Output 0 instead of 0xdeadbeef when exception packets are flushed Message-ID: References: <20240722152756.59453-1-james.clark@linaro.org> <20240722152756.59453-2-james.clark@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240726_073519_909675_A055A338 X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 23, 2024 at 04:09:29PM +0100, Mike Leach wrote: > On Mon, 22 Jul 2024 at 16:28, James Clark wrote: > > > > Normally exception packets don't directly output a branch sample, but > > if they're the last record in a buffer then they will. Because they > > don't have addresses set we'll see the placeholder value > > CS_ETM_INVAL_ADDR (0xdeadbeef) in the output. > > > > Since commit 6035b6804bdf ("perf cs-etm: Support dummy address value for > > CS_ETM_TRACE_ON packet") we've used 0 as an externally visible "not set" > > address value. For consistency reasons and to not make exceptions look > > like an error, change them to use 0 too. > Reviewed-by: Mike Leach Thanks, applied to tmp.perf-tools-next, - Arnaldo