From: Sudeep Holla <sudeep.holla@arm.com>
To: Dhruva Gole <d-gole@ti.com>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
<cristian.marussi@arm.com>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, Sudeep Holla <sudeep.holla@arm.com>,
<linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <arm-scmi@vger.kernel.org>,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2] clk: scmi: add is_prepared hook
Date: Fri, 26 Jul 2024 15:44:06 +0100 [thread overview]
Message-ID: <ZqO2Nn7Wofs_wfkQ@bogus> (raw)
In-Reply-To: <20240726135231.hhzp3dqgx64e6kiw@dhruva>
On Fri, Jul 26, 2024 at 07:22:31PM +0530, Dhruva Gole wrote:
> On Jul 26, 2024 at 21:10:07 +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Some clks maybe default enabled by hardware, so add is_prepared hook
> > for non-atomic clk_ops to get the status of the clk. Then when disabling
> > unused clks, those unused clks but default hardware on clks could be
> > in off state to save power.
>
> Just a nit - reword the commit message as:
> Then when disabling the unused clocks, they can be simply turned OFF to
> save power.
>
Ah this was what it meant. I couldn't parse the original text and was about
to ask.
> Also if you can make it still verbose, explain when you expect this
> disabling of unused clks to take place exactly? During boot? Driver probe sequence?
> or By some user commands?
>
Agreed. Being little more verbose here would be beneficial IMO.
--
Regards,
Sudeep
next prev parent reply other threads:[~2024-07-26 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 13:10 [PATCH V2] clk: scmi: add is_prepared hook Peng Fan (OSS)
2024-07-26 13:44 ` Dhruva Gole
2024-07-26 14:11 ` Cristian Marussi
2024-07-26 14:41 ` Sudeep Holla
2024-07-26 13:52 ` Dhruva Gole
2024-07-26 14:44 ` Sudeep Holla [this message]
2024-08-01 3:35 ` Peng Fan
2024-08-02 6:15 ` Dhruva Gole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqO2Nn7Wofs_wfkQ@bogus \
--to=sudeep.holla@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=d-gole@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).