From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC8D9C3DA4A for ; Fri, 26 Jul 2024 14:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xqErGeQV8QramWv27VcLcFG2ze6nnxDj2phtfIrLwLA=; b=RGJpC9NSDDEjQ33rjZhSA5gMVF 4KSjjxtBIWkGKgb/3zH2zrZDCndyJKZn1jWj7VYRUA7nGNUFkXt+QGXI/jyZLALoOPYzrM60G0XeL n9QduBbRVYrUcPRaXw56MwX4JtaqOc3s8aDALbFeJOPPqcPx09e+F31mHY9rhNr2r106/3FGjiuM8 mTep5xTkXtpbAf9erEQ0L/+JnVV1EbCxrXRPZQCfz39Z2ysmJACARjVcrA1xUv9bzTPnbge6BBmGz 0KuQ8QO5uDvGgeWe6qhK0YDTSsk41D9eEp0aa2CRMCdcBYhU55GSkM9cvXR3wFCuzMyzpTz9V7i/G mJ6FMTEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXMBS-00000004BRm-0rZM; Fri, 26 Jul 2024 14:44:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXMB2-00000004BNz-1ocd for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2024 14:44:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 592611007; Fri, 26 Jul 2024 07:44:36 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E46A3F5A1; Fri, 26 Jul 2024 07:44:08 -0700 (PDT) Date: Fri, 26 Jul 2024 15:44:06 +0100 From: Sudeep Holla To: Dhruva Gole Cc: "Peng Fan (OSS)" , , , , Sudeep Holla , , , , , Peng Fan Subject: Re: [PATCH V2] clk: scmi: add is_prepared hook Message-ID: References: <20240726131007.1651996-1-peng.fan@oss.nxp.com> <20240726135231.hhzp3dqgx64e6kiw@dhruva> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240726135231.hhzp3dqgx64e6kiw@dhruva> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240726_074412_535081_1433EADB X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 26, 2024 at 07:22:31PM +0530, Dhruva Gole wrote: > On Jul 26, 2024 at 21:10:07 +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > Some clks maybe default enabled by hardware, so add is_prepared hook > > for non-atomic clk_ops to get the status of the clk. Then when disabling > > unused clks, those unused clks but default hardware on clks could be > > in off state to save power. > > Just a nit - reword the commit message as: > Then when disabling the unused clocks, they can be simply turned OFF to > save power. > Ah this was what it meant. I couldn't parse the original text and was about to ask. > Also if you can make it still verbose, explain when you expect this > disabling of unused clks to take place exactly? During boot? Driver probe sequence? > or By some user commands? > Agreed. Being little more verbose here would be beneficial IMO. -- Regards, Sudeep