From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01371C3DA4A for ; Fri, 26 Jul 2024 14:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t4SMe0hXctwdc4EVX4mRrLzaRmuHJsoFrCkUGBvHNPQ=; b=G5Vb/kzsD9FNeb4HF3HqPIxjzP qiLEf+FxYllP9p1DVXd2JzefHX0e/gJU/Nn4b1+lwLMSef5FqM5df8Wv/LnzGtRCZxg7FXRtCTWfX Wuuvi+gIhTQE5Di64Y9jW/6NgD4JmCkkdKpKxKWsrp7IgFf9XUU1H2qDe2gaPYks36NJxffZNFpPP ggEqEcqRv+oSmMOEgPXgvxPTvSkn7HWrWErocebYYLWXdzayXb5w4SPNTKP7iIIL1Fny1TIOAqCxn TfDscD9JAlo0iAtei/7hozXRwvvV8vMztMwozTUplMMf0cU5NWpxY+64gGqD/8v5kstLlxHEo3hhp z8SRmKVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXMDr-00000004BrR-1qNV; Fri, 26 Jul 2024 14:47:07 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXMDS-00000004Bnm-1eM2 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2024 14:46:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B457BCE1799; Fri, 26 Jul 2024 14:46:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7964C32782; Fri, 26 Jul 2024 14:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722005200; bh=9LBcqw02wGRos/TDIsMEJykASWkmlRP7kWte1/BH/50=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RktiwVqWIh5eWvnG4ClbvF9u9uSrJegW78Ves0LfcIHFndaFF+4QErxwEy5HGkjJq aCM6SteLpChozlI/BPsFzUchbIPe1bcqj79ziNaz4H+mxC8hkN6E1pPT/dhRrLTFgj 4GWm+DfnG4qt+eAEdTT5eAg9Ksxxofsq9kj/Cy/FQe8n5pRSciVchJbG3ndUp+Z+oe cNuAFIGSxAXBmPdwHQxSDn/YAGKk5GJhCBuPDduYgw07fjjyuXC8Hl3LxHQp27Aw9v YMfbkAUaCeCNG/kA/q3548PVsdJVLtf3gFhhpSmbE/m0d7fRiazG8/JqHqABvIY4c1 iPgi7ucLDAWVg== Date: Fri, 26 Jul 2024 11:46:36 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Namhyung Kim , Ingo Molnar , Mark Rutland , Alexander Shishkin , Heiko Carstens , Thomas Richter , Hendrik Brueckner , Suzuki K Poulose , Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Yicong Yang , Jonathan Cameron , Will Deacon , Jiri Olsa , Ian Rogers , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Leo Yan , Peter Zijlstra Subject: Re: [PATCH V9 06/13] perf tools: Enable evsel__is_aux_event() to work for S390_CPUMSF Message-ID: References: <20240715160712.127117-1-adrian.hunter@intel.com> <20240715160712.127117-7-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240726_074642_819512_0F326F45 X-CRM114-Status: GOOD ( 23.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 23, 2024 at 12:09:46PM +0300, Adrian Hunter wrote: > On 23/07/24 11:26, Leo Yan wrote: > > On 7/15/2024 5:07 PM, Adrian Hunter wrote: > >> > >> evsel__is_aux_event() identifies AUX area tracing selected events. > >> > >> S390_CPUMSF uses a raw event type (PERF_TYPE_RAW - refer > >> s390_cpumsf_evsel_is_auxtrace()) not a PMU type value that could be checked > >> in evsel__is_aux_event(). However it sets needs_auxtrace_mmap (refer > >> auxtrace_record__init()), so check that first. > >> > >> Currently, the features that use evsel__is_aux_event() are used only by > >> Intel PT, but that may change in the future. > >> > >> Signed-off-by: Adrian Hunter > >> Acked-by: Ian Rogers > >> Reviewed-by: Andi Kleen > > > > Reviewed-by: Leo Yan > > Namhyung, could we get patches 5 and 6 from this series > applied? They are independent and Leo's new patch set is > dependent on patch 5. I'm getting those two into tmp.perf-tools-next, probably should pick the rest as peterz has the kernel bits already in his queue.git/perf/core, right? - Arnaldo > > > >> --- > >> tools/perf/util/pmu.c | 6 +++++- > >> 1 file changed, 5 insertions(+), 1 deletion(-) > >> > >> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > >> index 986166bc7c78..0b38c51bd6eb 100644 > >> --- a/tools/perf/util/pmu.c > >> +++ b/tools/perf/util/pmu.c > >> @@ -1199,8 +1199,12 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu *pmu) > >> > >> bool evsel__is_aux_event(const struct evsel *evsel) > >> { > >> - struct perf_pmu *pmu = evsel__find_pmu(evsel); > >> + struct perf_pmu *pmu; > >> > >> + if (evsel->needs_auxtrace_mmap) > >> + return true; > >> + > >> + pmu = evsel__find_pmu(evsel); > >> return pmu && pmu->auxtrace; > >> } > >> > >> -- > >> 2.34.1 > >> > >>