From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ED62C3DA4A for ; Fri, 26 Jul 2024 15:01:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UWMlaVl2FNarq64KG1uanLogyiEZV7OZtuISNHZgVFo=; b=m17bQo870JAB4q/t3/xEjgppzy 96bmXmpk3GtyZNM8C7rYIsMr/raZO/WBxStLAAxDiF3Z4WX2P6/3gQZtyyTNxkFjNsxIIYDmdrqyR /WnlqPvuASQnB+dPJT5ytiUtLSmNA2VLagczbqqhSUJZViACxVjfWoSiVY6HBk9I/Npbno17yS8/c q5XiBHgFohTFWlpRaZy0TTzfFb526PE6o3/q3OYSLJEjNMakeOBDMqbNf5mOFBuj5c1JUgSRo2INO iKsWsJVotA8MYIN4khbFLu6U58MVMavWhv/Z9E5B8OefvgL8D/GUyvKLeJer0DWnfTzoduIWolCE8 yyTNjh2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXMRd-00000004E3v-0oCY; Fri, 26 Jul 2024 15:01:21 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXMRE-00000004DzA-1rax for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2024 15:00:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37ECD1007; Fri, 26 Jul 2024 08:01:21 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8AE383F73F; Fri, 26 Jul 2024 08:00:53 -0700 (PDT) Date: Fri, 26 Jul 2024 16:00:51 +0100 From: Cristian Marussi To: Etienne CARRIERE Cc: Cristian Marussi , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "arm-scmi@vger.kernel.org" , "sudeep.holla@arm.com" , "james.quinlan@broadcom.com" , "f.fainelli@gmail.com" , "vincent.guittot@linaro.org" , "peng.fan@oss.nxp.com" , "michal.simek@amd.com" , "quic_sibis@quicinc.com" , "quic_nkela@quicinc.com" , "ptosi@google.com" , "dan.carpenter@linaro.org" , "souvik.chakravarty@arm.com" Subject: Re: [PATCH v2 4/8] firmware: arm_scmi: Make MBOX transport a standalone driver Message-ID: References: <20240710173153.4060457-1-cristian.marussi@arm.com> <20240710173153.4060457-5-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240726_080056_559581_DC512D36 X-CRM114-Status: GOOD ( 21.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 23, 2024 at 01:41:04PM +0000, Etienne CARRIERE wrote: > Hi Cristian, > > On Wednesday, July 10, 2024, Cristian Marussi wrote: > > Make SCMI mailbox transport a standalne driver that can be optionally > > loaded as a module. > >  > > Signed-off-by: Cristian Marussi > > --- > >  drivers/firmware/arm_scmi/Kconfig             |  4 +- > >  drivers/firmware/arm_scmi/Makefile            |  3 +- > >  drivers/firmware/arm_scmi/common.h            |  3 -- > >  drivers/firmware/arm_scmi/driver.c            |  3 -- > >  .../{mailbox.c => scmi_transport_mailbox.c}   | 44 +++++++++++++------ > >  5 files changed, 36 insertions(+), 21 deletions(-) > >  rename drivers/firmware/arm_scmi/{mailbox.c => scmi_transport_mailbox.c} (88%) > >  > > diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig > > index aa5842be19b2..135e34aefd70 100644 > > --- a/drivers/firmware/arm_scmi/Kconfig > > +++ b/drivers/firmware/arm_scmi/Kconfig > > @@ -75,7 +75,7 @@ config ARM_SCMI_HAVE_MSG > >            available. > >   > >  config ARM_SCMI_TRANSPORT_MAILBOX > > -       bool "SCMI transport based on Mailbox" > > +       tristate "SCMI transport based on Mailbox" > >          depends on MAILBOX > >          select ARM_SCMI_HAVE_TRANSPORT > >          select ARM_SCMI_HAVE_SHMEM > > @@ -85,6 +85,8 @@ config ARM_SCMI_TRANSPORT_MAILBOX > >   > >            If you want the ARM SCMI PROTOCOL stack to include support for a > >            transport based on mailboxes, answer Y. > > +         This driver can also be built as a module.  If so, the module > > Nitpicking: replace the 2 space char before "if so," with a single one? > Applies also to patch 5/8, 6/8 and 7/8. > Fixed in V3. > Other wise LGTM , but my comment on patch 3/8 that would affect > use of DEFINE_SCMI_TRANSPORT_DRIVER() in patch 5 to 7. > Yes I reworked the macros params. Thanks, Cristian