From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C54FC3DA7F for ; Fri, 26 Jul 2024 11:30:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nIR74FHV2i912ka+rz0PNiFTMeGqcDGd3Anh7euKVEM=; b=WHNtM08wQPzU50MbCJZ459IzUA txVcHoB2veErcjVMZPQTIgEGvRi+Z+R1LUV3FJ8Nf/gJNUWZZRkUx0wBuBwmNmyfiH6YF7S5f5vaA OSVajbvddcgGAAtkabTbj8aoH0SX4JlPWYSKVU90Tzc/0TwQnmxcbBzjvMVl08IZV25MJTqdLaChF V0ytzCuLz8fhv3GtNiLckUNyqpKMixZ99rg3uo+dAESxQefPuxvN2APhPJ6L7kZdePPuq+8pKPXzq wklcAWQ5Wv4DeAslsj6nj4gMjTCXh/12Mk0go2v++UzaQhAuAr7spIx1JpzEUsSqsCdRSREhv2ymL cbez19cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXJ9M-00000003j14-0kxy; Fri, 26 Jul 2024 11:30:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXJ8q-00000003irK-3jl4 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2024 11:29:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DDE291007; Fri, 26 Jul 2024 04:30:09 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6996F3F73F; Fri, 26 Jul 2024 04:29:43 -0700 (PDT) Date: Fri, 26 Jul 2024 12:29:41 +0100 From: Cristian Marussi To: Etienne Carriere Cc: linux-kernel@vger.kernel.org, Sudeep Holla , Cristian Marussi , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: arm_scmi: fix voltage description in failure cases Message-ID: References: <20240725065317.3758165-1-etienne.carriere@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240725065317.3758165-1-etienne.carriere@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240726_042945_086183_4215FA4B X-CRM114-Status: GOOD ( 18.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 25, 2024 at 08:53:17AM +0200, Etienne Carriere wrote: > Reset the reception buffer max size when a voltage domain description Hi Etienne, Good catch, thanks for this. Maybe a Fixes: too ? Other than that, LGTM. Reviewed-by: Cristian Marussi Thanks, Cristian > request fails, for example when the voltage domain returns an access > permission error (SCMI_ERR_ACCESS) unless what only a single 32bit > word is read back for the remaining voltage description requests > responses leading to invalid information. The side effect of this > issue is that the voltage regulators registered from those remaining > SCMI voltage domain were assigned a wrong regulator name. > > Signed-off-by: Etienne Carriere > --- > drivers/firmware/arm_scmi/voltage.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/arm_scmi/voltage.c b/drivers/firmware/arm_scmi/voltage.c > index 2175ffd6cef5..f1a7c04ae820 100644 > --- a/drivers/firmware/arm_scmi/voltage.c > +++ b/drivers/firmware/arm_scmi/voltage.c > @@ -229,8 +229,10 @@ static int scmi_voltage_descriptors_get(const struct scmi_protocol_handle *ph, > /* Retrieve domain attributes at first ... */ > put_unaligned_le32(dom, td->tx.buf); > /* Skip domain on comms error */ > - if (ph->xops->do_xfer(ph, td)) > + if (ph->xops->do_xfer(ph, td)) { > + ph->xops->reset_rx_to_maxsz(ph, td); > continue; > + } > > v = vinfo->domains + dom; > v->id = dom; > -- > 2.25.1 >