From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4CADC3DA4A for ; Fri, 26 Jul 2024 14:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KlN/6WvKWROf6nVXUF1CcQzvxYzI1VyOGCqtc7/EWYs=; b=Z2IbghOyOGuXUZexDLZBVc77nk p7wa/pGkfRK2NalkgfK7QfTZDBiIE5njgBJUKQz43mDh70fabHYokGSFyUPd9BhBv+It5FP95mP/a GoLyMeY8jMAl0BzHewCrv0fQtWO6bV8fq+FTE2ZJdnb0iXGjMsBcsuabIlu6SQoxTNAEEoSzHn+q7 n0RYhu/ber7ubkmHCj3cg1eHFL+dpAPuqSy9Nx3FCQiZNh5bGjW9v/6hHrC2CWsfsjIlTDl+QLt3b rixafgcZ5wdQtfTaU33rAatfjB60k/homA2uruAA1qBcxzFeLyNKp8KBwe386aUdwb+gcofhKRL5x EMGTV7hQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXM0O-000000049cb-0j43; Fri, 26 Jul 2024 14:33:12 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXLzy-000000049YZ-0Xtw for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2024 14:32:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 623516181D; Fri, 26 Jul 2024 14:32:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C408C32786; Fri, 26 Jul 2024 14:32:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722004365; bh=tudKbC866T2Zw2ceclbscI8kDcEcCkJFfNi3n30+QIg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WdFDPYpIZ1KVl/mGCEDyE7XX6mAocpV2iK5Es34hQwRLGwe0b4GZnhNafvb8lh2m8 llLORaDWP1lar0HOlsjblkt1OTYAxAwjzXrbH8Y77f/z1DE6t9sS3fIKqqNIa0pnzR w68xzdB0+0+Z5Rho9VPVAbGzOv9XastJFEGpMcc8lKAkRHAtw5VXRozpArBi/ZvNyf s0lJQz9sDCYDTEz/Obuf7+9VzjhDBlKM89PoQtBTxZZgm0RtWlDf4HWqm2Zn20n3iD JG2F9IE54/3FzMqDAvIkQUKd/k3wtvta5/W0MSgCj3x0xc+vuUdv/TirS/iKvTDje4 wteSwo3erTERA== Date: Fri, 26 Jul 2024 11:32:42 -0300 From: Arnaldo Carvalho de Melo To: Suzuki K Poulose Cc: James Clark , coresight@lists.linaro.org, gankulkarni@os.amperecomputing.com, mike.leach@linaro.org, leo.yan@linux.dev, anshuman.khandual@arm.com, James Clark , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-perf-users@vger.kernel.org Subject: Re: [PATCH v6 00/17] coresight: Use per-sink trace ID maps for Perf sessions Message-ID: References: <20240722101202.26915-1-james.clark@linaro.org> <6476a228-847b-4804-9229-c11a881663c7@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6476a228-847b-4804-9229-c11a881663c7@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240726_073246_304139_2E3F9294 X-CRM114-Status: GOOD ( 49.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 26, 2024 at 03:26:04PM +0100, Suzuki K Poulose wrote: > Hi Arnaldo > > On 26/07/2024 15:18, Arnaldo Carvalho de Melo wrote: > > On Mon, Jul 22, 2024 at 11:11:42AM +0100, James Clark wrote: > > > This will allow sessions with more than CORESIGHT_TRACE_IDS_MAX ETMs > > > as long as there are fewer than that many ETMs connected to each sink. > > > > Hey, may I take the tools part, i.e. patches 0-7 and someone on the ARM > > kernel team pick the driver bits? > > I plan to pick the kernel driver bits for v6.12 Perhaps it is better for me to wait for that? - Arnaldo > Kind regards > Suzuki > > > > > - Arnaldo > > > Each sink owns its own trace ID map, and any Perf session connecting to > > > that sink will allocate from it, even if the sink is currently in use by > > > other users. This is similar to the existing behavior where the dynamic > > > trace IDs are constant as long as there is any concurrent Perf session > > > active. It's not completely optimal because slightly more IDs will be > > > used than necessary, but the optimal solution involves tracking the PIDs > > > of each session and allocating ID maps based on the session owner. This > > > is difficult to do with the combination of per-thread and per-cpu modes > > > and some scheduling issues. The complexity of this isn't likely to worth > > > it because even with multiple users they'd just see a difference in the > > > ordering of ID allocations rather than hitting any limits (unless the > > > hardware does have too many ETMs connected to one sink). > > > > > > Per-thread mode works but only until there are any overlapping IDs, at > > > which point Perf will error out. Both per-thread mode and sysfs mode are > > > left to future changes, but both can be added on top of this initial > > > implementation and only sysfs mode requires further driver changes. > > > > > > The HW_ID version field hasn't been bumped in order to not break Perf > > > which already has an error condition for other values of that field. > > > Instead a new minor version has been added which signifies that there > > > are new fields but the old fields are backwards compatible. > > > > > > Changes since v5: > > > * Hide queue number printout behind -v option > > > * Style change in cs_etm__process_aux_output_hw_id() > > > * Move new format enum to an earlier commit to reduce churn > > > > > > Changes since v4: > > > > > > * Fix compilation failure when TRACE_ID_DEBUG is set > > > * Expand comment about not freeing individual trace IDs in > > > free_event_data() > > > > > > Changes since v3: > > > > > > * Fix issue where trace IDs were overwritten by possibly invalid ones > > > by Perf in unformatted mode. Now the HW_IDs are also used for > > > unformatted mode unless the kernel didn't emit any. > > > * Add a commit to check the OpenCSD version. > > > * Add a commit to not save invalid IDs in the Perf header. > > > * Replace cs_etm_queue's formatted and formatted_set members with a > > > single enum which is easier to use. > > > * Drop CORESIGHT_TRACE_ID_UNUSED_FLAG as it's no longer needed. > > > * Add a commit to print the queue number in the raw dump. > > > * Don't assert on the number of unformatted decoders if decoders == 0. > > > > > > > > > Changes since v2: > > > > > > * Rebase on coresight-next 6.10-rc2 (b9b25c8496). > > > * Fix double free of csdev if device registration fails. > > > * Fix leak of coresight_trace_id_perf_start() if trace ID allocation > > > fails. > > > * Don't resend HW_ID for sink changes in per-thread mode. The existing > > > CPU field on AUX records can be used to track this instead. > > > * Tidy function doc for coresight_trace_id_release_all() > > > * Drop first two commits now that they are in coresight-next > > > * Add a commit to make the trace ID spinlock local to the map > > > > > > Changes since V1: > > > > > > * Rename coresight_device.perf_id_map to perf_sink_id_map. > > > * Instead of outputting a HW_ID for each reachable ETM, output > > > the sink ID and continue to output only the HW_ID once for > > > each mapping. > > > * Keep the first two Perf patches so that it applies cleanly > > > on coresight-next, although they have been applied on perf-tools-next > > > * Add new *_map() functions to the trace ID public API instead of > > > modifying existing ones. > > > * Collapse "coresight: Pass trace ID map into source enable" into > > > "coresight: Use per-sink trace ID maps for Perf sessions" because the > > > first commit relied on the default map being accessible which is no > > > longer necessary due to the previous bullet point. > > > > > > > > > James Clark (17): > > > perf: cs-etm: Create decoders after both AUX and HW_ID search passes > > > perf: cs-etm: Allocate queues for all CPUs > > > perf: cs-etm: Move traceid_list to each queue > > > perf: cs-etm: Create decoders based on the trace ID mappings > > > perf: cs-etm: Only save valid trace IDs into files > > > perf: cs-etm: Support version 0.1 of HW_ID packets > > > perf: cs-etm: Print queue number in raw trace dump > > > perf: cs-etm: Add runtime version check for OpenCSD > > > coresight: Remove unused ETM Perf stubs > > > coresight: Clarify comments around the PID of the sink owner > > > coresight: Move struct coresight_trace_id_map to common header > > > coresight: Expose map arguments in trace ID API > > > coresight: Make CPU id map a property of a trace ID map > > > coresight: Use per-sink trace ID maps for Perf sessions > > > coresight: Remove pending trace ID release mechanism > > > coresight: Emit sink ID in the HW_ID packets > > > coresight: Make trace ID map spinlock local to the map > > > > > > drivers/hwtracing/coresight/coresight-core.c | 37 +- > > > drivers/hwtracing/coresight/coresight-dummy.c | 3 +- > > > .../hwtracing/coresight/coresight-etm-perf.c | 43 +- > > > .../hwtracing/coresight/coresight-etm-perf.h | 18 - > > > .../coresight/coresight-etm3x-core.c | 9 +- > > > .../coresight/coresight-etm4x-core.c | 9 +- > > > drivers/hwtracing/coresight/coresight-priv.h | 1 + > > > drivers/hwtracing/coresight/coresight-stm.c | 3 +- > > > drivers/hwtracing/coresight/coresight-sysfs.c | 3 +- > > > .../hwtracing/coresight/coresight-tmc-etr.c | 5 +- > > > drivers/hwtracing/coresight/coresight-tmc.h | 5 +- > > > drivers/hwtracing/coresight/coresight-tpdm.c | 3 +- > > > .../hwtracing/coresight/coresight-trace-id.c | 138 ++-- > > > .../hwtracing/coresight/coresight-trace-id.h | 70 +- > > > include/linux/coresight-pmu.h | 17 +- > > > include/linux/coresight.h | 21 +- > > > tools/build/feature/test-libopencsd.c | 4 +- > > > tools/include/linux/coresight-pmu.h | 17 +- > > > tools/perf/Makefile.config | 2 +- > > > tools/perf/arch/arm/util/cs-etm.c | 11 +- > > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 49 +- > > > .../perf/util/cs-etm-decoder/cs-etm-decoder.h | 3 +- > > > .../util/cs-etm-decoder/cs-etm-min-version.h | 13 + > > > tools/perf/util/cs-etm.c | 629 +++++++++++------- > > > tools/perf/util/cs-etm.h | 12 +- > > > 25 files changed, 650 insertions(+), 475 deletions(-) > > > create mode 100644 tools/perf/util/cs-etm-decoder/cs-etm-min-version.h > > > > > > -- > > > 2.34.1